<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/src/push.c, branch cmn/error-buffer</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/'/>
<entry>
<title>push: fix the update constructor</title>
<updated>2015-05-14T08:34:42+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-14T08:34:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=254ff3e929fdda6ad747d23c2c24fa377b5f9d97'/>
<id>254ff3e929fdda6ad747d23c2c24fa377b5f9d97</id>
<content type='text'>
There was a copypasta error and the source and destination IDs were
reversed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There was a copypasta error and the source and destination IDs were
reversed.
</pre>
</div>
</content>
</entry>
<entry>
<title>push: free the update list</title>
<updated>2015-05-13T07:46:57+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-04T07:39:55+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=3251972e1fbab379d9ec5a94e455431d005446d1'/>
<id>3251972e1fbab379d9ec5a94e455431d005446d1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove the callbacks struct from the remote</title>
<updated>2015-05-13T07:46:35+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-04-21T20:10:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=8f0104ecc54db00a075310ab744a19eb60e3d740'/>
<id>8f0104ecc54db00a075310ab744a19eb60e3d740</id>
<content type='text'>
Having the setting be different from calling its actions was not a great
idea and made for the sake of the wrong convenience.

Instead of that, accept either fetch options, push options or the
callbacks when dealing with the remote. The fetch options are currently
only the callbacks, but more options will be moved from setters and
getters on the remote to the options.

This does mean passing the same struct along the different functions but
the typical use-case will only call git_remote_fetch() or
git_remote_push() and so won't notice much difference.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Having the setting be different from calling its actions was not a great
idea and made for the sake of the wrong convenience.

Instead of that, accept either fetch options, push options or the
callbacks when dealing with the remote. The fetch options are currently
only the callbacks, but more options will be moved from setters and
getters on the remote to the options.

This does mean passing the same struct along the different functions but
the typical use-case will only call git_remote_fetch() or
git_remote_push() and so won't notice much difference.
</pre>
</div>
</content>
</entry>
<entry>
<title>push: remove own copy of callbacks</title>
<updated>2015-05-13T07:46:35+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-04-21T18:16:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=05259114427234831cf4915cbe40a5bb8ea021b0'/>
<id>05259114427234831cf4915cbe40a5bb8ea021b0</id>
<content type='text'>
The push object knows which remote it's associated with, and therefore
does not need to keep its own copy of the callbacks stored in the
remote.

Remove the copy and simply access the callbacks struct within the
remote.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The push object knows which remote it's associated with, and therefore
does not need to keep its own copy of the callbacks stored in the
remote.

Remove the copy and simply access the callbacks struct within the
remote.
</pre>
</div>
</content>
</entry>
<entry>
<title>push: report the update plan to the caller</title>
<updated>2015-04-18T23:02:29+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-04-18T22:55:00+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=efc2fec50e3bb725b2b244fdeacfb2dfad6ee78e'/>
<id>efc2fec50e3bb725b2b244fdeacfb2dfad6ee78e</id>
<content type='text'>
It can be useful for the caller to know which update commands will be
sent to the server before the packfile is pushed up. git does this via
the pre-push hook.

We don't have hooks, but as it adds introspection into what is
happening, we can add a callback which performs the same function.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It can be useful for the caller to know which update commands will be
sent to the server before the packfile is pushed up. git does this via
the pre-push hook.

We don't have hooks, but as it adds introspection into what is
happening, we can add a callback which performs the same function.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed update_tips callback called for failed pushed references</title>
<updated>2015-03-11T18:51:12+00:00</updated>
<author>
<name>Pierre-Olivier Latour</name>
<email>pol@mac.com</email>
</author>
<published>2015-03-06T06:13:54+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=e22ffb42097671f1c6737be4c8bbf2ff36a9e290'/>
<id>e22ffb42097671f1c6737be4c8bbf2ff36a9e290</id>
<content type='text'>
The current implementation does not set 'fire_callback' back to 0 for failed updates so the callback still fires.

Instead of adding yet another condition check to set 'fire_callback' to 0 if needed, considering this function should be a no-op for failed updates anyway, the best fix is to simplify its logic to check upfront if the update is a failed one.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current implementation does not set 'fire_callback' back to 0 for failed updates so the callback still fires.

Instead of adding yet another condition check to set 'fire_callback' to 0 if needed, considering this function should be a no-op for failed updates anyway, the best fix is to simplify its logic to check upfront if the update is a failed one.
</pre>
</div>
</content>
</entry>
<entry>
<title>push: remove reflog message override</title>
<updated>2015-03-03T13:40:50+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-01-15T14:31:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=412a3808889de65d8f94f22502aba10b9afbf755'/>
<id>412a3808889de65d8f94f22502aba10b9afbf755</id>
<content type='text'>
We always use "update by push".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We always use "update by push".
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove the signature from ref-modifying functions</title>
<updated>2015-03-03T13:40:50+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-01-07T12:23:05+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=659cf2029f322ea876d663d85783b48945227e8f'/>
<id>659cf2029f322ea876d663d85783b48945227e8f</id>
<content type='text'>
The signature for the reflog is not something which changes
dynamically. Almost all uses will be NULL, since we want for the
repository's default identity to be used, making it noise.

In order to allow for changing the identity, we instead provide
git_repository_set_ident() and git_repository_ident() which allow a user
to override the choice of signature.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The signature for the reflog is not something which changes
dynamically. Almost all uses will be NULL, since we want for the
repository's default identity to be used, making it noise.

In order to allow for changing the identity, we instead provide
git_repository_set_ident() and git_repository_ident() which allow a user
to override the choice of signature.
</pre>
</div>
</content>
</entry>
<entry>
<title>push: fold unpack_ok() into finish()</title>
<updated>2014-12-10T17:55:54+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2014-12-10T16:23:33+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=d524b2d3d13cd306f4405b2e48cf586c04e4e5dc'/>
<id>d524b2d3d13cd306f4405b2e48cf586c04e4e5dc</id>
<content type='text'>
The push cannot be successful if we sent a bad packfile. We should
return an error in that case instead of storing it elsewhere.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The push cannot be successful if we sent a bad packfile. We should
return an error in that case instead of storing it elsewhere.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2713 from libgit2/jamill/push_fetch_first</title>
<updated>2014-11-20T12:13:46+00:00</updated>
<author>
<name>Vicent Marti</name>
<email>vicent@github.com</email>
</author>
<published>2014-11-20T12:13:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=fc6ac074ee7ea945819e0a1d6f65ba160ba403d7'/>
<id>fc6ac074ee7ea945819e0a1d6f65ba160ba403d7</id>
<content type='text'>
Update message for error during push</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update message for error during push</pre>
</div>
</content>
</entry>
</feed>
