delta/libgit2.git/src/refs.c, branch ethomson/github_actions github.com: libgit2/libgit2.git tree-wide: mark local functions as static 2020-06-09T12:57:06+00:00 Patrick Steinhardt ps@pks.im 2020-06-08T10:40:47+00:00 a6c9e0b367c4882ab0f8e78bd0ad4ab2904ac377 We've accumulated quite some functions which are never used outside of their respective code unit, but which are lacking the `static` keyword. Add it to reduce their linkage scope and allow the compiler to optimize better. 
We've accumulated quite some functions which are never used outside of
their respective code unit, but which are lacking the `static` keyword.
Add it to reduce their linkage scope and allow the compiler to optimize
better.
refs: refuse to delete HEAD 2020-01-15T21:55:58+00:00 Josh Bleecher Snyder josharian@gmail.com 2020-01-15T21:31:21+00:00 852c83ee44d6d53137f12443c9f82f70bbabbadc This requires adding a new symbolic ref to the testrepo fixture. Some of the existing tests attempt to delete HEAD, expecting a different failure. Introduce and use a non-HEAD symbolic ref instead. Adjust a few other tests as needed. Fixes #5357 
This requires adding a new symbolic ref to the testrepo fixture.
Some of the existing tests attempt to delete HEAD, expecting a different failure. Introduce and use a non-HEAD symbolic ref instead.
Adjust a few other tests as needed.

Fixes #5357
 refs: rename git_reference__set_name to git_reference__realloc 2019-12-13T11:01:10+00:00 Etienne Samson samson.etienne@gmail.com 2019-12-08T14:25:52+00:00 97b8491b01e99790a9f643a9571baf65fe168ba8 As git_reference__name will reallocate storage to account for longer names (it's actually allocator-dependent), it will cause all existing pointers to the old object to become dangling, as they now point to freed memory. Fix the issue by renaming to a more descriptive name, and pass a pointer to the actual reference that can safely be invalidated if the realloc succeeds. 
As git_reference__name will reallocate storage to account for longer
names (it's actually allocator-dependent), it will cause all existing
pointers to the old object to become dangling, as they now point to
freed memory.

Fix the issue by renaming to a more descriptive name, and pass a pointer
to the actual reference that can safely be invalidated if the realloc
succeeds.
fileops: rename to "futils.h" to match function signatures 2019-07-20T17:11:20+00:00 Patrick Steinhardt ps@pks.im 2019-06-29T07:17:32+00:00 e54343a4024e75dfaa940e652c2c9799d33634b2 Our file utils functions all have a "futils" prefix, e.g. `git_futils_touch`. One would thus naturally guess that their definitions and implementation would live in files "futils.h" and "futils.c", respectively, but in fact they live in "fileops.h". Rename the files to match expectations. 
Our file utils functions all have a "futils" prefix, e.g.
`git_futils_touch`. One would thus naturally guess that their
definitions and implementation would live in files "futils.h" and
"futils.c", respectively, but in fact they live in "fileops.h".

Rename the files to match expectations.
configuration: cvar -> configmap 2019-07-18T11:53:41+00:00 Patrick Steinhardt ps@pks.im 2019-07-18T11:53:41+00:00 658022c41affc7d9b5bd9b84b1d75ec909b820c6 `cvar` is an unhelpful name. Refactor its usage to `configmap` for more clarity. 
`cvar` is an unhelpful name.  Refactor its usage to `configmap` for more
clarity.
oid: `is_zero` instead of `iszero` 2019-06-15T23:16:47+00:00 Edward Thomson ethomson@edwardthomson.com 2019-06-08T22:28:35+00:00 5d92e54745eaad2c89aa6457d504411ceee3a4f4 The only function that is named `issomething` (without underscore) was `git_oid_iszero`. Rename it to `git_oid_is_zero` for consistency with the rest of the library. 
The only function that is named `issomething` (without underscore) was
`git_oid_iszero`.  Rename it to `git_oid_is_zero` for consistency with
the rest of the library.
refs: loosen restriction on wildcard "*" refspecs 2019-04-26T08:25:09+00:00 Patrick Steinhardt ps@pks.im 2019-04-26T08:15:49+00:00 51214b85dedc39b734cce9d09b9311221a31de4b In commit cd377f45c9 (refs: loosen restriction on wildcard "*" refspecs, 2015-07-22) in git.git, the restrictions on wildcard "*" refspecs has been loosened. While wildcards were previously only allowed if the component is a single "*", this was changed to also accept other patterns as part of the component. We never adapted to that change and still reject any wildcard patterns that aren't a single "*" only. Update our tests to reflect the upstream change and adjust our own code accordingly. 
In commit cd377f45c9 (refs: loosen restriction on wildcard "*"
refspecs, 2015-07-22) in git.git, the restrictions on wildcard
"*" refspecs has been loosened. While wildcards were previously
only allowed if the component is a single "*", this was changed
to also accept other patterns as part of the component.

We never adapted to that change and still reject any wildcard
patterns that aren't a single "*" only. Update our tests to
reflect the upstream change and adjust our own code accordingly.
branches: introduce flag to skip enumeration of certain HEADs 2019-02-14T13:01:27+00:00 Patrick Steinhardt ps@pks.im 2019-02-14T12:05:49+00:00 efb20825e16f1b924986be4c6bc0410ce64aaa81 Right now, the function `git_repository_foreach_head` will always iterate over all HEADs of the main repository and its worktrees. In some cases, it might be required to skip either of those, though. Add a flag in preparation for the following commit that enables this behaviour. 
Right now, the function `git_repository_foreach_head` will always
iterate over all HEADs of the main repository and its worktrees. In some
cases, it might be required to skip either of those, though. Add a flag
in preparation for the following commit that enables this behaviour.
git_error: use new names in internal APIs and usage 2019-01-22T22:30:35+00:00 Edward Thomson ethomson@edwardthomson.com 2018-12-27T19:47:34+00:00 f673e232afe22eb865cdc915e55a2df6493f0fbb Move to the `git_error` name in the internal API for error-related functions. 
Move to the `git_error` name in the internal API for error-related
functions.
references: use new names in internal usage 2019-01-17T10:32:29+00:00 Edward Thomson ethomson@edwardthomson.com 2019-01-17T00:32:31+00:00 ed8cfbf04181d6fc229582a09c5c7657a53cd2e3 Update internal usage to use the `git_reference` names for constants. 
Update internal usage to use the `git_reference` names for constants.