delta/libgit2.git/tests/merge/workdir, branch ethomson/test_https github.com: libgit2/libgit2.git path: separate git-specific path functions from util 2021-11-09T15:17:17+00:00 Edward Thomson ethomson@github.com 2021-10-31T13:45:46+00:00 95117d4744cf5a66f2bcde7991a925e9852d9b1e Introduce `git_fs_path`, which operates on generic filesystem paths. `git_path` will be kept for only git-specific path functionality (for example, checking for `.git` in a path). 
Introduce `git_fs_path`, which operates on generic filesystem paths.
`git_path` will be kept for only git-specific path functionality (for
example, checking for `.git` in a path).
str: introduce `git_str` for internal, `git_buf` is external 2021-10-17T13:49:01+00:00 Edward Thomson ethomson@edwardthomson.com 2021-09-07T21:53:49+00:00 f0e693b18afbe1de37d7da5b5a8967b6c87d8e53 libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again. 
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
tests: don't generate false positives on empty path segments 2021-08-08T11:34:06+00:00 Peter Pettersson boretrk@hotmail.com 2021-08-08T11:34:06+00:00 d095502ed797e20a73a00b65cc9d70d91f7d7ab4 






fileops: rename to "futils.h" to match function signatures
2019-07-20T17:11:20+00:00

Patrick Steinhardt
ps@pks.im

2019-06-29T07:17:32+00:00

e54343a4024e75dfaa940e652c2c9799d33634b2

Our file utils functions all have a "futils" prefix, e.g.
`git_futils_touch`. One would thus naturally guess that their
definitions and implementation would live in files "futils.h" and
"futils.c", respectively, but in fact they live in "fileops.h".

Rename the files to match expectations.





Our file utils functions all have a "futils" prefix, e.g.
`git_futils_touch`. One would thus naturally guess that their
definitions and implementation would live in files "futils.h" and
"futils.c", respectively, but in fact they live in "fileops.h".

Rename the files to match expectations.







tests: merge::analysis: use variants to deduplicate test suites
2019-06-13T09:59:50+00:00

Patrick Steinhardt
ps@pks.im

2019-06-13T09:57:16+00:00

70fae43c6ce804f0669ba68b17fe9087e6bd58f5

Since commit 394951ad4 (tests: allow for simple data-driven
tests, 2019-06-07), we have the ability to run a given test suite
with multiple variants. Use this new feature to deduplicate the
test suites for merge::{trees,workdir}::analysis into a single
test suite.





Since commit 394951ad4 (tests: allow for simple data-driven
tests, 2019-06-07), we have the ability to run a given test suite
with multiple variants. Use this new feature to deduplicate the
test suites for merge::{trees,workdir}::analysis into a single
test suite.







Review fixes:
2019-06-10T10:22:02+00:00

Robert Coup
robert@coup.net.nz

2019-06-07T14:22:42+00:00

21ddeabe6cb4a77899a6c7348493a2b45cc82a9c

- whitespace -> tabs
- comment style
- improve repo naming in merge/trees/analysis tests.





- whitespace -> tabs
- comment style
- improve repo naming in merge/trees/analysis tests.







Refactor testing:
2019-06-10T10:22:02+00:00

Robert Coup
robert@coup.net.nz

2019-06-06T15:32:09+00:00

7b27b6cf716429080fbc968d8f573977996ee112

- move duplication between merge/trees/ and merge/workdir/ into merge/analysis{.c,.h}
- remove merge-resolve.git resource, open the existing merge-resolve as a bare repo instead.





- move duplication between merge/trees/ and merge/workdir/ into merge/analysis{.c,.h}
- remove merge-resolve.git resource, open the existing merge-resolve as a bare repo instead.







merge: add doc header to analysis tests
2019-06-10T10:22:02+00:00

Robert Coup
robert@coup.net.nz

2019-03-19T22:51:24+00:00

5427461fb47d22760c0a5a80b6a5f33561e48820












object_type: use new enumeration names
2018-12-01T11:54:57+00:00

Edward Thomson
ethomson@edwardthomson.com

2018-11-28T14:26:57+00:00

168fe39bea3368972a8b1a33d5908e73bc790c18

Use the new object_type enumeration names within the codebase.





Use the new object_type enumeration names within the codebase.







Merge pull request #4770 from tiennou/feature/merge-analysis-any-branch
2018-11-30T08:46:14+00:00

Patrick Steinhardt
ps@pks.im

2018-11-30T08:46:14+00:00

0ddc60944ca4727246414e8bcf3170fe8286f854

Allow merge analysis against any reference




Allow merge analysis against any reference