delta/libgit2.git/tests/refs/branches, branch ethomson/diff_enum github.com: libgit2/libgit2.git Fix one memory leak in master 2021-07-30T14:18:57+00:00 lhchavez lhchavez@lhchavez.com 2021-07-30T14:18:57+00:00 d15b6132a6453d696b37c884765572a696e7af06 There was one test that wasn't correctly disposing of the repository. 
There was one test that wasn't correctly disposing of the repository.
tests: reformat upstream merge 2021-07-30T12:56:34+00:00 Edward Thomson ethomson@edwardthomson.com 2021-07-30T12:56:34+00:00 f2915ec488898efe956c90c322fff67d0030f92f 






tests: upstream merge test has been added.
2021-06-18T12:47:15+00:00

Dmitry Lobanov
gaussblurinc@gmail.com

2021-06-18T12:47:15+00:00

55f2abb834e28fc6f04327a1a24b73f0de2b9487












Add git_branch_name_is_valid
2020-10-25T16:33:28+00:00

Sven Strickroth
email@cs-ware.de

2020-09-08T19:05:18+00:00

fe11160c724853fe8469a9788c5992420e4638de

Signed-off-by: Sven Strickroth <email@cs-ware.de>





Signed-off-by: Sven Strickroth <email@cs-ware.de>







fileops: rename to "futils.h" to match function signatures
2019-07-20T17:11:20+00:00

Patrick Steinhardt
ps@pks.im

2019-06-29T07:17:32+00:00

e54343a4024e75dfaa940e652c2c9799d33634b2

Our file utils functions all have a "futils" prefix, e.g.
`git_futils_touch`. One would thus naturally guess that their
definitions and implementation would live in files "futils.h" and
"futils.c", respectively, but in fact they live in "fileops.h".

Rename the files to match expectations.





Our file utils functions all have a "futils" prefix, e.g.
`git_futils_touch`. One would thus naturally guess that their
definitions and implementation would live in files "futils.h" and
"futils.c", respectively, but in fact they live in "fileops.h".

Rename the files to match expectations.







branch: add test for git_branch_lookup to accept GIT_BRANCH_ALL
2019-02-22T21:19:44+00:00

Augustin Fabre
augustin@augfab.fr

2019-02-21T20:42:25+00:00

0a25141e7b39ed0bda19a97dbfcbe4789779a5c9












branch: fix `branch_is_checked_out` with bare repos
2019-02-14T13:01:27+00:00

Patrick Steinhardt
ps@pks.im

2019-02-14T12:30:33+00:00

bf013fc0a8c318570b109ce1516f1c49b5cd37c4

In a bare repository, HEAD usually points to the branch that is
considered the "default" branch. As the current implementation for
`git_branch_is_checked_out` only does a comparison of HEAD with the
branch that is to be checked, it will say that the branch pointed to by
HEAD in such a bare repo is checked out.

Fix this by skipping the main repo's HEAD when it is bare.





In a bare repository, HEAD usually points to the branch that is
considered the "default" branch. As the current implementation for
`git_branch_is_checked_out` only does a comparison of HEAD with the
branch that is to be checked, it will say that the branch pointed to by
HEAD in such a bare repo is checked out.

Fix this by skipping the main repo's HEAD when it is bare.







branches: do not assert that the given ref is a branch
2019-02-14T13:01:27+00:00

Patrick Steinhardt
ps@pks.im

2019-02-14T12:49:35+00:00

788cd2d5f070c496e5f66467d92bfd714f2878f4

Libraries should use assert(3P) only very scarcely. First, we usually
shouldn't cause the caller of our library to abort in case where the
assert fails. Second, if code is compiled with -DNDEBUG, then the assert
will not be included at all.

In our `git_branch_is_checked_out` function, we have an assert that
verifies that the given reference parameter is non-NULL and in fact a
branch. While the first check is fine, the second is not. E.g. when
compiled with -DNDEBUG, we'd proceed and treat the given reference as a
branch in all cases.

Fix the issue by instead treating a non-branch reference as not being
checked out. This is the obvious solution, as references other than
branches cannot be directly checked out.





Libraries should use assert(3P) only very scarcely. First, we usually
shouldn't cause the caller of our library to abort in case where the
assert fails. Second, if code is compiled with -DNDEBUG, then the assert
will not be included at all.

In our `git_branch_is_checked_out` function, we have an assert that
verifies that the given reference parameter is non-NULL and in fact a
branch. While the first check is fine, the second is not. E.g. when
compiled with -DNDEBUG, we'd proceed and treat the given reference as a
branch in all cases.

Fix the issue by instead treating a non-branch reference as not being
checked out. This is the obvious solution, as references other than
branches cannot be directly checked out.







branches: add tests for `git_branch_is_checked_out`
2019-02-14T13:01:27+00:00

Patrick Steinhardt
ps@pks.im

2019-02-14T12:26:30+00:00

a0f87e161b000558ed4aba70bfeb88ddf3329583

We currently do not have any tests at all for the
`git_branch_is_checked_out` function. Add some basic ones.





We currently do not have any tests at all for the
`git_branch_is_checked_out` function. Add some basic ones.







git_error: use new names in internal APIs and usage
2019-01-22T22:30:35+00:00

Edward Thomson
ethomson@edwardthomson.com

2018-12-27T19:47:34+00:00

f673e232afe22eb865cdc915e55a2df6493f0fbb

Move to the `git_error` name in the internal API for error-related
functions.





Move to the `git_error` name in the internal API for error-related
functions.