<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/tests, branch cmn/https-cap-no-hardcode</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/'/>
<entry>
<title>Merge pull request #4029 from libgit2/cmn/windows-no-concurrent-compress</title>
<updated>2016-12-16T00:19:49+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2016-12-16T00:19:49+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=c5e6ba289266e56b8e7f7c9b463aa7008d4b0258'/>
<id>c5e6ba289266e56b8e7f7c9b463aa7008d4b0258</id>
<content type='text'>
refdb: disable concurrent compress in the threading tests on Windows</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
refdb: disable concurrent compress in the threading tests on Windows</pre>
</div>
</content>
</entry>
<entry>
<title>refdb: disable concurrent compress in the threading tests on Windows</title>
<updated>2016-12-12T17:09:12+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2016-12-12T17:09:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=b31283a658eb6fdbfaf7256d5303f1ce06de404f'/>
<id>b31283a658eb6fdbfaf7256d5303f1ce06de404f</id>
<content type='text'>
This is far from an ideal situation, but this causes issues on Windows which
make it harder to develop anything, as these tests hit issues which relate
specifically to the Windows filesystem like permission errors for files we
should be able to access. There is an issue likely related to the ordering of
the repack, but there's enough noise that it does not currently help us to run
this aspect of the test in CI.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is far from an ideal situation, but this causes issues on Windows which
make it harder to develop anything, as these tests hit issues which relate
specifically to the Windows filesystem like permission errors for files we
should be able to access. There is an issue likely related to the ordering of
the repack, but there's enough noise that it does not currently help us to run
this aspect of the test in CI.
</pre>
</div>
</content>
</entry>
<entry>
<title>clar: mark `cl_git_thread_check()` as inline</title>
<updated>2016-12-12T08:16:33+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2016-11-25T13:58:16+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=ab0cc5a0598ecbfa2cffe7248deb5256993eb86e'/>
<id>ab0cc5a0598ecbfa2cffe7248deb5256993eb86e</id>
<content type='text'>
The function `cl_git_thread_check()` is defined as static. As the
function is defined in a header file which is included by our
tests, this can result in warnings for every test file where
`cl_git_thread_check` is never used.

Fix the issue by marking it as inline instead.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function `cl_git_thread_check()` is defined as static. As the
function is defined in a header file which is included by our
tests, this can result in warnings for every test file where
`cl_git_thread_check` is never used.

Fix the issue by marking it as inline instead.
</pre>
</div>
</content>
</entry>
<entry>
<title>git_rebase_init: correctly handle detached HEAD</title>
<updated>2016-12-02T04:11:57+00:00</updated>
<author>
<name>David Turner</name>
<email>dturner@twosigma.com</email>
</author>
<published>2016-12-02T04:06:41+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=4db1fc7e5ead5c29ffb6594b229b84f4392b40f1'/>
<id>4db1fc7e5ead5c29ffb6594b229b84f4392b40f1</id>
<content type='text'>
git_rebase_finish relies on head_detached being set, but
rebase_init_merge was only setting it when branch-&gt;ref_name was unset.
But branch-&gt;ref_name would be set to "HEAD" in the case of detached
HEAD being either implicitly (NULL) or explicitly passed to
git_rebase_init.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git_rebase_finish relies on head_detached being set, but
rebase_init_merge was only setting it when branch-&gt;ref_name was unset.
But branch-&gt;ref_name would be set to "HEAD" in the case of detached
HEAD being either implicitly (NULL) or explicitly passed to
git_rebase_init.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: handle life without threads</title>
<updated>2016-11-18T19:00:14+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2016-11-18T18:30:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=6367c58cd482288e5cd476bd48d0d4406e3bac7b'/>
<id>6367c58cd482288e5cd476bd48d0d4406e3bac7b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>threads::refdb tests: use new threaded clar assert</title>
<updated>2016-11-18T16:52:28+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2016-11-18T12:37:47+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=6a05c7a0efd60dce3e99673c3256bf60516693ed'/>
<id>6a05c7a0efd60dce3e99673c3256bf60516693ed</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>clar: Introduce assertion helpers for threads</title>
<updated>2016-11-18T16:52:28+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2016-11-18T12:34:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=bbf22f8229718571059cd579945b134772f9a73d'/>
<id>bbf22f8229718571059cd579945b134772f9a73d</id>
<content type='text'>
Don't `cl_git_pass` in a child thread.  When the assertion fails, clar
will `longjmp` to its error handler, but:

&gt; The effect of a call to longjmp() where initialization of the jmp_buf
&gt; structure was not performed in the calling thread is undefined.

Instead, set up an error context that threads can populate, and the
caller can check.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't `cl_git_pass` in a child thread.  When the assertion fails, clar
will `longjmp` to its error handler, but:

&gt; The effect of a call to longjmp() where initialization of the jmp_buf
&gt; structure was not performed in the calling thread is undefined.

Instead, set up an error context that threads can populate, and the
caller can check.
</pre>
</div>
</content>
</entry>
<entry>
<title>core::init tests: reverse init/shutdown</title>
<updated>2016-11-18T16:52:28+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2016-11-18T16:50:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=99479062dbb738ebc5892e163b701680cea91980'/>
<id>99479062dbb738ebc5892e163b701680cea91980</id>
<content type='text'>
We want a predictable number of initializations in our multithreaded
init test, but we also want to make sure that we have _actually_
initialized `git_libgit2_init` before calling `git_thread_create` (since
it now has a sanity check that `git_libgit2_init` has been called).

Since `git_thread_create` is internal-only, keep this sanity check.
Flip the invocation so that we `git_libgit2_init` before our thread
tests and `git_libgit2_shutdown` again after.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We want a predictable number of initializations in our multithreaded
init test, but we also want to make sure that we have _actually_
initialized `git_libgit2_init` before calling `git_thread_create` (since
it now has a sanity check that `git_libgit2_init` has been called).

Since `git_thread_create` is internal-only, keep this sanity check.
Flip the invocation so that we `git_libgit2_init` before our thread
tests and `git_libgit2_shutdown` again after.
</pre>
</div>
</content>
</entry>
<entry>
<title>threads: introduce `git_thread_exit`</title>
<updated>2016-11-18T12:34:09+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2016-11-18T12:19:22+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=82f15896deb06d396d76d706f6c0146197d14b2c'/>
<id>82f15896deb06d396d76d706f6c0146197d14b2c</id>
<content type='text'>
Introduce `git_thread_exit`, which will allow threads to terminate at an
arbitrary time, returning a `void *`.  On Windows, this means that we
need to store the current `git_thread` in TLS, so that we can set its
`return` value when terminating.

We cannot simply use `ExitThread`, since Win32 returns `DWORD`s from
threads; we return `void *`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Introduce `git_thread_exit`, which will allow threads to terminate at an
arbitrary time, returning a `void *`.  On Windows, this means that we
need to store the current `git_thread` in TLS, so that we can set its
`return` value when terminating.

We cannot simply use `ExitThread`, since Win32 returns `DWORD`s from
threads; we return `void *`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #3998 from pks-t/pks/repo-discovery</title>
<updated>2016-11-14T16:10:43+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>carlosmn@github.com</email>
</author>
<published>2016-11-14T16:10:43+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/libgit2.git/commit/?id=a39f18ac770e1a4bac72212236614db57c1de5be'/>
<id>a39f18ac770e1a4bac72212236614db57c1de5be</id>
<content type='text'>
Repository discovery starting from files</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Repository discovery starting from files</pre>
</div>
</content>
</entry>
</feed>
