diff options
| author | Carlos Martín Nieto <cmn@dwim.me> | 2012-10-07 11:19:19 +0200 |
|---|---|---|
| committer | Carlos Martín Nieto <cmn@dwim.me> | 2012-10-07 11:19:19 +0200 |
| commit | acd1700630ea1159a55dc5e8cee12e4a725afe18 (patch) | |
| tree | 27f31788a629df14160e6063f1c5e93f8295e103 | |
| parent | 22935b06d160c8b33e90784d43480859ca65d3b6 (diff) | |
| download | libgit2-acd1700630ea1159a55dc5e8cee12e4a725afe18.tar.gz | |
remote: only keep a weak pointer in update_tips
The reference is only needed inside the function. We mistakenly
increased the reference counter causing the ODB not to get freed and
leaking descriptors.
| -rw-r--r-- | src/remote.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/remote.c b/src/remote.c index c01e41dce..b73af0128 100644 --- a/src/remote.c +++ b/src/remote.c @@ -467,7 +467,7 @@ int git_remote_update_tips(git_remote *remote) if (refs->length == 0) return 0; - if (git_repository_odb(&odb, remote->repo) < 0) + if (git_repository_odb__weakptr(&odb, remote->repo) < 0) return -1; if (git_refspec__parse(&tagspec, GIT_REFSPEC_TAGS, true) < 0) |