diff options
| author | Carlos Martín Nieto <cmn@dwim.me> | 2014-06-04 17:31:42 +0200 |
|---|---|---|
| committer | Carlos Martín Nieto <cmn@dwim.me> | 2014-06-04 17:31:42 +0200 |
| commit | 57cb1179e5c9c8f5c27c9115f13f1cae5d0f87a0 (patch) | |
| tree | 67871086b1437dcd410979b423cd3ba140ab9257 /src/diff.c | |
| parent | 90befde4a1938641dfdb9a7bdb9f361d1de5c26f (diff) | |
| download | libgit2-cmn/config-default-snapshot.tar.gz | |
Make the default repository config getter return a snapshotcmn/config-default-snapshot
You should always use a snapshot, with the sole exception of writing to
the configuration.
Any reads that are not against a snapshot have race conditions, both in
terms of returned values as well as dangling pointers.
Diffstat (limited to 'src/diff.c')
| -rw-r--r-- | src/diff.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/diff.c b/src/diff.c index 325c599e0..287530893 100644 --- a/src/diff.c +++ b/src/diff.c @@ -406,7 +406,7 @@ static int diff_list_apply_options( diff->opts.flags |= GIT_DIFF_INCLUDE_UNTRACKED; /* load config values that affect diff behavior */ - if ((val = git_repository_config_snapshot(&cfg, repo)) < 0) + if ((val = git_repository_config(&cfg, repo)) < 0) return val; if (!git_config__cvar(&val, cfg, GIT_CVAR_SYMLINKS) && val) |