Make giterr_set_str public

There has been discussion for a while about making some set of
the `giterr_set` type functions part of the public API for code
that is implementing new backends to libgit2.  This makes the
`giterr_set_str()` and `giterr_set_oom()` functions public.

2 files changed, 18 insertions, 4 deletions

diff --git a/src/common.h b/src/common.h
index 1d85428b3..747bbf7ce 100644
--- a/src/common.h
+++ b/src/common.h
@@ -49,14 +49,24 @@
 
 #include <regex.h>
 
+/**
+ * Check a pointer allocation result, returning -1 if it failed.
+ */
 #define GITERR_CHECK_ALLOC(ptr) if (ptr == NULL) { return -1; }
 
-void giterr_set_oom(void);
+/**
+ * Set the error message for this thread, formatting as needed.
+ */
 void giterr_set(int error_class, const char *string, ...);
-void giterr_clear(void);
-void giterr_set_str(int error_class, const char *string);
+
+/**
+ * Set the error message for a regex failure, using the internal regex
+ * error code lookup.
+ */
 void giterr_set_regex(const regex_t *regex, int error_code);
 
+/* NOTE: other giterr functions are in the public errors.h header file */
+
 #include "util.h"
 
 typedef struct git_transport git_transport;
diff --git a/src/errors.c b/src/errors.c
index 802ad3647..942a2f799 100644
--- a/src/errors.c
+++ b/src/errors.c
@@ -94,7 +94,11 @@ void giterr_set(int error_class, const char *string, ...)
 
 void giterr_set_str(int error_class, const char *string)
 {
-	char *message = git__strdup(string);
+	char *message;
+
+	assert(string);
+
+	message = git__strdup(string);
 
 	if (message)
 		set_error(error_class, message);