summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authornulltoken <emeric.fermas@gmail.com>2014-08-27 10:28:46 +0200
committernulltoken <emeric.fermas@gmail.com>2014-08-27 10:28:46 +0200
commite75a9ee45fa8cd8311151730dcbdf3befab2bd16 (patch)
treea612e7cef703e95f65cbb3b023dceb4b686083cf /src
parentcb92467bc284b87c38cdf32f8803a528846d094b (diff)
downloadlibgit2-ntk/propagate_url_parsing_error.tar.gz
winhttp: Prevent swallowing of url parsing errorntk/propagate_url_parsing_error
Diffstat (limited to 'src')
-rw-r--r--src/transports/winhttp.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/transports/winhttp.c b/src/transports/winhttp.c
index 1e46dfaee..836c488cc 100644
--- a/src/transports/winhttp.c
+++ b/src/transports/winhttp.c
@@ -1116,9 +1116,9 @@ static int winhttp_action(
int ret = -1;
if (!t->connection)
- if (gitno_connection_data_from_url(&t->connection_data, url, NULL) < 0 ||
- winhttp_connect(t, url) < 0)
- return -1;
+ if ((ret = gitno_connection_data_from_url(&t->connection_data, url, NULL)) < 0 ||
+ (ret = winhttp_connect(t, url)) < 0)
+ return ret;
if (winhttp_stream_alloc(t, &s) < 0)
return -1;