summaryrefslogtreecommitdiff
path: root/tests/clar_libgit2.c
diff options
context:
space:
mode:
authorCarlos Martín Nieto <cmn@dwim.me>2014-06-04 17:31:42 +0200
committerCarlos Martín Nieto <cmn@dwim.me>2014-06-04 17:31:42 +0200
commit57cb1179e5c9c8f5c27c9115f13f1cae5d0f87a0 (patch)
tree67871086b1437dcd410979b423cd3ba140ab9257 /tests/clar_libgit2.c
parent90befde4a1938641dfdb9a7bdb9f361d1de5c26f (diff)
downloadlibgit2-cmn/config-default-snapshot.tar.gz
Make the default repository config getter return a snapshotcmn/config-default-snapshot
You should always use a snapshot, with the sole exception of writing to the configuration. Any reads that are not against a snapshot have race conditions, both in terms of returned values as well as dangling pointers.
Diffstat (limited to 'tests/clar_libgit2.c')
-rw-r--r--tests/clar_libgit2.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/clar_libgit2.c b/tests/clar_libgit2.c
index 0a4c3e8e5..60a3d46e0 100644
--- a/tests/clar_libgit2.c
+++ b/tests/clar_libgit2.c
@@ -398,7 +398,7 @@ void cl_repo_commit_from_index(
void cl_repo_set_bool(git_repository *repo, const char *cfg, int value)
{
git_config *config;
- cl_git_pass(git_repository_config(&config, repo));
+ cl_git_pass(git_repository_config_writable(&config, repo));
cl_git_pass(git_config_set_bool(config, cfg, value != 0));
git_config_free(config);
}
@@ -417,7 +417,7 @@ int cl_repo_get_bool(git_repository *repo, const char *cfg)
void cl_repo_set_string(git_repository *repo, const char *cfg, const char *value)
{
git_config *config;
- cl_git_pass(git_repository_config(&config, repo));
+ cl_git_pass(git_repository_config_writable(&config, repo));
cl_git_pass(git_config_set_string(config, cfg, value));
git_config_free(config);
}