diff options
| author | Carlos Martín Nieto <cmn@dwim.me> | 2014-12-10 17:23:33 +0100 |
|---|---|---|
| committer | Carlos Martín Nieto <cmn@dwim.me> | 2014-12-10 18:55:54 +0100 |
| commit | d524b2d3d13cd306f4405b2e48cf586c04e4e5dc (patch) | |
| tree | c26d1f28514936ee311e8628a611d904194d7eba /tests/network | |
| parent | cd305c2f567678c96bccecab69f715b6063089bc (diff) | |
| download | libgit2-d524b2d3d13cd306f4405b2e48cf586c04e4e5dc.tar.gz | |
push: fold unpack_ok() into finish()
The push cannot be successful if we sent a bad packfile. We should
return an error in that case instead of storing it elsewhere.
Diffstat (limited to 'tests/network')
| -rw-r--r-- | tests/network/remote/local.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tests/network/remote/local.c b/tests/network/remote/local.c index 170d67ef9..baeb25df4 100644 --- a/tests/network/remote/local.c +++ b/tests/network/remote/local.c @@ -216,7 +216,6 @@ void test_network_remote_local__push_to_bare_remote(void) cl_git_pass(git_push_new(&push, localremote)); cl_git_pass(git_push_add_refspec(push, "refs/heads/master")); cl_git_pass(git_push_finish(push)); - cl_assert(git_push_unpack_ok(push)); /* Clean up */ git_push_free(push); @@ -262,7 +261,6 @@ void test_network_remote_local__push_to_bare_remote_with_file_url(void) cl_git_pass(git_push_new(&push, localremote)); cl_git_pass(git_push_add_refspec(push, "refs/heads/master")); cl_git_pass(git_push_finish(push)); - cl_assert(git_push_unpack_ok(push)); /* Clean up */ git_push_free(push); @@ -305,7 +303,6 @@ void test_network_remote_local__push_to_non_bare_remote(void) cl_git_pass(git_push_new(&push, localremote)); cl_git_pass(git_push_add_refspec(push, "refs/heads/master")); cl_git_fail_with(git_push_finish(push), GIT_EBAREREPO); - cl_assert_equal_i(0, git_push_unpack_ok(push)); /* Clean up */ git_push_free(push); @@ -452,7 +449,6 @@ void test_network_remote_local__update_tips_for_new_remote(void) { cl_git_pass(git_push_new(&push, new_remote)); cl_git_pass(git_push_add_refspec(push, "refs/heads/master")); cl_git_pass(git_push_finish(push)); - cl_assert(git_push_unpack_ok(push)); /* Update tips and make sure remote branch has been created */ cl_git_pass(git_push_update_tips(push, NULL, NULL)); |