str: introduce `git_str` for internal, `git_buf` is externalethomson/gitstr

libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.

1 files changed, 7 insertions, 5 deletions

diff --git a/tests/patch/parse.c b/tests/patch/parse.c
index 3f89eb51a..a3c4c6730 100644
--- a/tests/patch/parse.c
+++ b/tests/patch/parse.c
@@ -27,13 +27,14 @@ static void ensure_patch_validity(git_patch *patch)
 	cl_assert_equal_i(0, delta->new_file.size);
 }
 
-static void ensure_identical_patch_inout(const char *content) {
+static void ensure_identical_patch_inout(const char *content)
+{
 	git_buf buf = GIT_BUF_INIT;
 	git_patch *patch;
 
 	cl_git_pass(git_patch_from_buffer(&patch, content, strlen(content), NULL));
 	cl_git_pass(git_patch_to_buf(&buf, patch));
-	cl_assert_equal_strn(git_buf_cstr(&buf), content, strlen(content));
+	cl_assert_equal_strn(buf.ptr, content, strlen(content));
 
 	git_patch_free(patch);
 	git_buf_dispose(&buf);
@@ -131,12 +132,13 @@ void test_patch_parse__files_with_whitespaces_succeeds(void)
 
 void test_patch_parse__lifetime_of_patch_does_not_depend_on_buffer(void)
 {
-	git_buf diff = GIT_BUF_INIT, rendered = GIT_BUF_INIT;
+	git_str diff = GIT_STR_INIT;
+	git_buf rendered = GIT_BUF_INIT;
 	git_patch *patch;
 
-	cl_git_pass(git_buf_sets(&diff, PATCH_ORIGINAL_TO_CHANGE_MIDDLE));
+	cl_git_pass(git_str_sets(&diff, PATCH_ORIGINAL_TO_CHANGE_MIDDLE));
 	cl_git_pass(git_patch_from_buffer(&patch, diff.ptr, diff.size, NULL));
-	git_buf_dispose(&diff);
+	git_str_dispose(&diff);
 
 	cl_git_pass(git_patch_to_buf(&rendered, patch));
 	cl_assert_equal_s(PATCH_ORIGINAL_TO_CHANGE_MIDDLE, rendered.ptr);