summaryrefslogtreecommitdiff
path: root/src/common.h
Commit message (Collapse)AuthorAgeFilesLines
* win32: move type definitions for improved inclusionEdward Thomson2019-05-191-74/+2
| | | | | Move some win32 type definitions to a standalone file so that they can be included before other header files try to use the definitions.
* regexec: prefix all regexec function calls with p_Edward Thomson2019-05-191-2/+3
| | | | | | | Prefix all the calls to the the regexec family of functions with `p_`. This allows us to swap out all the regular expression functions with our own implementation. Move the declarations to `posix_regex.h` for simpler inclusion.
* deprecation: ensure we GIT_EXTERN deprecated funcsEdward Thomson2019-02-141-0/+6
| | | | | | | | | | Although the error functions were deprecated, we did not properly mark them as deprecated. We need to include the `deprecated.h` file in order to ensure that the functions get their export attributes. Similarly, do not define `GIT_DEPRECATE_HARD` within the library, or those functions will also not get their export attributes. Define that only on the tests and examples.
* git_error: use new names in internal APIs and usageEdward Thomson2019-01-221-29/+29
| | | | | Move to the `git_error` name in the internal API for error-related functions.
* treewide: avoid use of `inline` attributePatrick Steinhardt2018-07-131-1/+3
| | | | | | | | | | | | | ISO C90 does not specify the `inline` attribute, and as such we cannot use it in our code. While we already use `__inline` when building in Microsoft Visual Studio, we should also be using the `__inline__` attribute from GCC/Clang. Otherwise, if we're using neither MSVC nor GCC/Clang, we should simply avoid using `inline` at all and just define functions as static. This commit adjusts our own `GIT_INLINE` macro as well as the inline macros specified by khash and xdiff. This allows us to enable strict C90 mode in a later commit.
* Merge pull request #4489 from libgit2/ethomson/conflicts_crlfEdward Thomson2018-02-041-0/+6
|\ | | | | Conflict markers should match EOL style in conflicting files
| * xdiff: upgrade to git's included xdiffEdward Thomson2018-01-211-0/+6
| | | | | | | | | | | | Upgrade xdiff to git's most recent version, which includes changes to CR/LF handling. Now CR/LF included in the input files will be detected and conflict markers will be emitted with CR/LF when appropriate.
* | consistent header guardsethomson/header_guardsEdward Thomson2018-02-011-1/+1
|/ | | | use consistent names for the #include / #define header guard pattern.
* features.h: allow building without CMake-generated feature headerPatrick Steinhardt2017-09-121-1/+4
| | | | | | | | | | | | | | | | | | | | | In commit a390a8464 (cmake: move defines into "features.h" header, 2017-07-01), we have introduced a new "features.h" header. This file is being generated by the CMake build system based on how the libgit2 build has been configured, replacing the preexisting method of simply setting the defines inside of the CMake build system. This was done to help splitting up the build instructions into multiple separate subdirectories. An overlooked shortcoming of this approach is that some projects making use of libgit2 build the library with custom build systems, without making use of CMake. For those users, the introduction of the "features.h" file makes their life harder as they would have to also generate this file. Fix this issue by guarding all inclusions of the generated header file by the `LIBGIT2_NO_FEATURES_H` define. Like this, other build systems can skip the feature header and simply define all used features by specifying `-D` flags for the compiler again.
* cmake: move defines into "features.h" headerPatrick Steinhardt2017-08-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a future commit, we will split out the build instructions for our library directory and move them into a subdirectory. One of the benefits is fixing scoping issues, where e.g. defines do not leak to build targets where they do not belong to. But unfortunately, this does also pose the problem of how to propagate some defines which are required by both the library and the test suite. One way would be to create another variable keeping track of all added defines and declare it inside of the parent scope. While this is the most obvious and simplest way of going ahead, it is kind of unfortunate. The main reason to not use this is that these defines become implicit dependencies between the build targets. By simply observing a define inside of the CMakeLists.txt file, one cannot reason whether this define is only required by the current target or whether it is required by different targets, as well. Another approach would be to use an internal header file keeping track of all defines shared between targets. While configuring the library, we will set various variables and let CMake configure the file, adding or removing defines based on what has been configured. Like this, one can easily keep track of the current environment by simply inspecting the header file. Furthermore, these dependencies are becoming clear inside the CMakeLists.txt, as instead of simply adding a define, we now call e.g. `SET(GIT_THREADSAFE 1)`. Having this header file though requires us to make sure it is always included before any "#ifdef"-preprocessor checks are executed. As we have already refactored code to always include the "common.h" header file before any statement inside of a file, this becomes easy: just make sure "common.h" includes the new "features.h" header file first.
* win32: fix circular include deps with w32_crtdbgPatrick Steinhardt2017-06-301-4/+0
| | | | | | | | | | | | | | The current order of declarations and includes between "common.h" and "w32_crtdbg_stacktrace.h" is rather complicated. Both header files make use of things defined in the other one and are thus circularly dependent on each other. This makes it currently impossible to compile the "w32_crtdbg_stacktrace.c" file when including "common.h" inside of "w32_crtdbg_stacktrace.h". We can disentangle the mess by moving declaration of the inline crtdbg functions into the "w32_crtdbg_stacktrace.h" file and adding additional includes inside of it, such that all required functions are available to it. This allows us to break the dependency cycle.
* giterr_set: consistent error messagesEdward Thomson2016-12-291-1/+1
| | | | | | | | Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one
* common: mark printf-style formatting for `giterr_set`Patrick Steinhardt2016-11-141-1/+2
|
* win32: rename pthread.{c,h} to thread.{c,h}Patrick Steinhardt2016-06-201-1/+1
| | | | | | | | | | The old pthread-file did re-implement the pthreads API with exact symbol matching. As the thread-abstraction has now been split up between Unix- and Windows-specific files within the `git_` namespace to avoid symbol-clashes between libgit2 and pthreads, the rewritten wrappers have nothing to do with pthreads anymore. Rename the Windows-specific pthread-files to honor this change.
* common: introduce GITERR_CHECK_ALLOC_BUFPatrick Steinhardt2016-02-231-0/+5
| | | | | | | | We commonly have to check if a git_buf has been allocated correctly or if we ran out of memory. Introduce a new macro similar to `GITERR_CHECK_ALLOC` which checks if we ran OOM and if so returns an error. Provide a `#nodef` for Coverity to mark the error case as an abort path.
* xplat: use st_mtimespec everywhere on macEdward Thomson2016-02-091-0/+6
|
* Merge pull request #3170 from CmdrMoozy/nsec_fixCarlos Martín Nieto2015-11-121-0/+1
|\ | | | | git_index_entry__init_from_stat: set nsec fields in entry stats
| * win32: define our own POSIX struct stat, and support USE_NSECAxel Rasmussen2015-09-181-0/+1
| |
* | GITERR_CHECK_ALLOC_ADDn: multi-arg addersEdward Thomson2015-10-051-0/+9
|/
* errors: tighten up git_error_state OOMs a bit moreEdward Thomson2015-08-031-4/+9
| | | | | When an error state is an OOM, make sure that we treat is specially and do not try to free it.
* Include stacktrace summary in memory leak output.Jeff Hostetler2015-06-291-0/+4
|
* centralizing all IO buffer size valuesJ Wyman2015-05-111-0/+5
|
* Include ws2tcpip.h in order to get in6_addrAki Koskinen2015-03-021-0/+1
| | | | It's currently required in src/openssl_stream.c only.
* integer overflow: use compiler intrinsics if supportedEdward Thomson2015-02-131-0/+5
| | | | | gcc and clang support __builtin_add_overflow, use it whenever possible, falling back to our naive routines.
* Make our overflow check look more like gcc/clang'sEdward Thomson2015-02-131-10/+10
| | | | | | | | | Make our overflow checking look more like gcc and clang's, so that we can substitute it out with the compiler instrinsics on platforms that support it. This means dropping the ability to pass `NULL` as an out parameter. As a result, the macros also get updated to reflect this as well.
* Introduce git__add_sizet_overflow and friendsEdward Thomson2015-02-121-2/+4
| | | | | Add some helper functions to check for overflow in a type-specific manner.
* overflow checking: don't make callers set oomEdward Thomson2015-02-121-10/+4
| | | | | | Have the ALLOC_OVERFLOW testing macros also simply set_oom in the case where a computation would overflow, so that callers don't need to.
* allocations: test for overflow of requested sizeEdward Thomson2015-02-121-0/+22
| | | | | Introduce some helper macros to test integer overflow from arithmetic and set error message appropriately.
* bswap: remove unused bswapEdward Thomson2015-02-031-1/+0
|
* Spelling fixesWill Stamper2014-12-041-1/+1
|
* Make init_options fns use unsigned ints and macroRussell Belfer2014-05-021-0/+5
| | | | | Use an unsigned int for the version and add a helper macro so the code is simplified (and so the error message is a common string).
* strcasecmp is in <strings.h>Jacques Germishuys2014-04-301-0/+1
|
* Index locking and entry allocation changesRussell Belfer2014-04-171-0/+1
| | | | | | | | | | | | | | | | | This makes the lock management on the index a little bit broader, having a number of routines hold the lock across looking up the item to be modified and actually making the modification. Still not true thread safety, but more pure index modifications are now safe which allows the simple cases (such as starting up a diff while index modifications are underway) safe enough to get the snapshot without hitting allocation problems. As part of this, I simplified the allocation of index entries to use a flex array and just put the path at the end of the index entry. This makes every entry self-contained and makes it a little easier to feel sure that pointers to strings aren't being accidentally copied and freed while other references are still being held.
* Address PR commentsRussell Belfer2014-02-201-0/+7
| | | | | | | * Make GIT_INLINE an internal definition so it cannot be used in public headers * Fix language in CONTRIBUTING * Make index caps API use signed instead of unsigned values
* One more rename/cleanup for callback err functionsRussell Belfer2013-12-111-3/+6
|
* Fix C99 __func__ for MSVCRussell Belfer2013-12-111-0/+4
|
* Remove converting user error to GIT_EUSERRussell Belfer2013-12-111-10/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the behavior of callbacks so that the callback error code is not converted into GIT_EUSER and instead we propagate the return value through to the caller. Instead of using the giterr_capture and giterr_restore functions, we now rely on all functions to pass back the return value from a callback. To avoid having a return value with no error message, the user can call the public giterr_set_str or some such function to set an error message. There is a new helper 'giterr_set_callback' that functions can invoke after making a callback which ensures that some error message was set in case the callback did not set one. In places where the sign of the callback return value is meaningful (e.g. positive to skip, negative to abort), only the negative values are returned back to the caller, obviously, since the other values allow for continuing the loop. The hardest parts of this were in the checkout code where positive return values were overloaded as meaningful values for checkout. I fixed this by adding an output parameter to many of the internal checkout functions and removing the overload. This added some code, but it is probably a better implementation. There is some funkiness in the network code where user provided callbacks could be returning a positive or a negative value and we want to rely on that to cancel the loop. There are still a couple places where an user error might get turned into GIT_EUSER there, I think, though none exercised by the tests.
* Improve GIT_EUSER handlingRussell Belfer2013-12-111-14/+28
| | | | | | | | | | | This adds giterr_user_cancel to return GIT_EUSER and clear any error message that is sitting around. As a result of using that in places, we need to be more thorough with capturing errors that happen inside a callback when used internally. To help with that, this also adds giterr_capture and giterr_restore so that when we internally use a foreach-type function that clears errors and converts them to GIT_EUSER, it is easier to restore not just the return value, but the actual error message text.
* Clean up warningsEdward Thomson2013-12-091-0/+2
|
* preserve windows error numbers as wellEdward Thomson2013-11-011-0/+24
|
* Add git_has_win32_version helperPhilip Kelley2013-03-311-1/+2
|
* Implement global/system file search pathsRussell Belfer2013-03-151-0/+6
| | | | | | | | | | | | | | | | | | | | | | | The goal of this work is to expose the search logic for "global", "system", and "xdg" files through the git_libgit2_opts() interface. Behind the scenes, I changed the logic for finding files to have a notion of a git_strarray that represents a search path and to store a separate search path for each of the three tiers of config file. For each tier, I implemented a function to initialize it to default values (generally based on environment variables), and then general interfaces to get it, set it, reset it, and prepend new directories to it. Next, I exposed these interfaces through the git_libgit2_opts interface, reusing the GIT_CONFIG_LEVEL_SYSTEM, etc., constants for the user to control which search path they were modifying. There are alternative designs for the opts interface / argument ordering, so I'm putting this phase out for discussion. Additionally, I ended up doing a little bit of clean up regarding attr.h and attr_file.h, adding a new attrcache.h so the other two files wouldn't have to be included in so many places.
* Fix some deprecation warnings on WindowsRussell Belfer2013-02-281-3/+1
| | | | | This fixes some snprintf and vsnprintf related deprecation warnings we've been having on Windows with recent compilers.
* Add GIT_STDLIB_CALLRussell Belfer2013-02-281-0/+2
| | | | | | This removes the one-off GIT_CDECL and adds a new standard way of doing this named GIT_STDLIB_CALL with a src/win32 specific def when on the Windows platform.
* Deduplicate FormatMessage UTF-16 to UTF-8 conversion codeSven Strickroth2013-02-021-0/+1
| | | | Signed-off-by: Sven Strickroth <email@cs-ware.de>
* update copyrightsEdward Thomson2013-01-081-1/+1
|
* versions: MSVC build fixesVicent Marti2012-12-051-5/+5
|
* common: Silly vmg.Vicent Marti2012-12-051-1/+2
|
* common: Silly MSVCVicent Marti2012-12-051-1/+2
|
* Merge pull request #1115 from ben/struct-versionsVicent Martí2012-12-051-0/+27
|\ | | | | Version info for public structs
View Lorry Controller Status