summaryrefslogtreecommitdiff
path: root/src/mailmap.c
Commit message (Collapse)AuthorAgeFilesLines
* path: use new length validation functionsEdward Thomson2021-11-091-1/+2
|
* path: separate git-specific path functions from utilEdward Thomson2021-11-091-3/+3
| | | | | | Introduce `git_fs_path`, which operates on generic filesystem paths. `git_path` will be kept for only git-specific path functionality (for example, checking for `.git` in a path).
* str: introduce `git_str` for internal, `git_buf` is externalethomson/gitstrEdward Thomson2021-10-171-33/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
* use git_repository_workdir_path to generate pathsEdward Thomson2021-04-281-0/+4
| | | | | Use `git_repository_workdir_path` to generate workdir paths since it will validate the length.
* mailmap: use GIT_ASSERTEdward Thomson2020-11-271-10/+19
|
* git_error: use new names in internal APIs and usageEdward Thomson2019-01-221-6/+6
| | | | | Move to the `git_error` name in the internal API for error-related functions.
* object_type: use new enumeration namesethomson/index_fixesEdward Thomson2018-12-011-1/+1
| | | | Use the new object_type enumeration names within the codebase.
* mailmap: Undefined or garbage value returned to callerEtienne Samson2018-08-211-1/+1
| | | | In case there was nothing to parse in the buf, we'd return uninitialized stack data.
* Require the length argument to git_mailmap_from_buffer and make ↵Nika Layzell2018-06-171-8/+4
| | | | mailmap_add_buffer internal
* mailmap: git_buf_free => git_buf_disposeNika Layzell2018-06-141-9/+9
|
* mailmap: Hide EEXISTS to simplify git_mailmap_add_entry callersNika Layzell2018-06-141-2/+4
|
* mailmap: Free the mailmap vectorNika Layzell2018-06-141-0/+2
|
* mailmap: API and style cleanupNika Layzell2018-06-141-53/+79
|
* mailmap: Rewrite API to support accurate mailmap resolutionNika Layzell2018-06-141-136/+246
|
* mailmap: API and style cleanupNika Layzell2018-06-141-33/+47
|
* mailmap: Switch mailmap parsing to use the git_parse moduleNika Layzell2018-06-141-193/+147
|
* mailmap: Fix more bugs which snuck in when I rebasedNika Layzell2018-06-141-2/+2
|
* mailmap: Make everything a bit more style conformingNika Layzell2018-06-141-25/+82
|
* mailmap: Don't error out when there's junk at the end of the lineEmilio Cobos Álvarez2018-06-141-3/+0
| | | | Also matches git.
* mailmap: Don't return a freed pointer, even if we return an error codeEmilio Cobos Álvarez2018-06-141-1/+3
|
* mailmap: Do not error out when the mailmap contains an invalid lineEmilio Cobos Álvarez2018-06-141-4/+4
| | | | This matches git.
* mailmap: Be consistent about checking len vs. len > 0Emilio Cobos Álvarez2018-06-141-1/+1
| | | | Not that it matters much anyway but...
* mailmap: git_vector_get already checks boundsEmilio Cobos Álvarez2018-06-141-4/+1
|
* mailmap: Some more style cleanupNika Layzell2018-06-141-3/+6
|
* mailmap: Clean up mailmap parser, and finish APINika Layzell2018-06-141-157/+274
|
* mailmap: WIP mailmap supportEmilio Cobos Álvarez2018-06-141-0/+208