summaryrefslogtreecommitdiff
path: root/src/oid.c
Commit message (Collapse)AuthorAgeFilesLines
* str: introduce `git_str` for internal, `git_buf` is externalethomson/gitstrEdward Thomson2021-10-171-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
* oid: use GIT_ASSERTEdward Thomson2020-11-271-2/+3
|
* global: separate global state from thread-local stateEdward Thomson2020-10-111-2/+2
| | | | | | | | | | | | | Our "global initialization" has accumulated some debris over the years. It was previously responsible for both running the various global initializers (that set up various subsystems) _and_ setting up the "global state", which is actually the thread-local state for things like error reporting. Separate the thread local state out into "threadstate". Use the normal subsystem initialization functions that we already have to set it up. This makes both the global initialization system and the threadstate system simpler to reason about.
* tree-wide: do not compile deprecated functions with hard deprecationPatrick Steinhardt2020-06-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h" header to be empty. As a result, no function declarations are made available to callers, but the implementations are still available to link against. This has the problem that function declarations also aren't visible to the implementations, meaning that the symbol's visibility will not be set up correctly. As a result, the resulting library may not expose those deprecated symbols at all on some platforms and thus cause linking errors. Fix the issue by conditionally compiling deprecated functions, only. While it becomes impossible to link against such a library in case one uses deprecated functions, distributors of libgit2 aren't expected to pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real" hard deprecation still makes sense in the context of CI to test we don't use deprecated symbols ourselves and in case a dependant uses libgit2 in a vendored way and knows it won't ever use any of the deprecated symbols anyway.
* oid functions: return an intEdward Thomson2020-01-241-7/+13
| | | | | Stop returning a void for functions, future-proofing them to allow them to fail.
* oid: `is_zero` instead of `iszero`Edward Thomson2019-06-161-1/+6
| | | | | | The only function that is named `issomething` (without underscore) was `git_oid_iszero`. Rename it to `git_oid_is_zero` for consistency with the rest of the library.
* git_error: use new names in internal APIs and usageEdward Thomson2019-01-221-6/+6
| | | | | Move to the `git_error` name in the internal API for error-related functions.
* Make sure to always include "common.h" firstPatrick Steinhardt2017-07-031-1/+2
| | | | | | | | | | | | | | | | | | | | | | Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.
* giterr_set: consistent error messagesEdward Thomson2016-12-291-5/+5
| | | | | | | | Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one
* git__*allocarray: safer realloc and mallocEdward Thomson2015-02-121-2/+1
| | | | | | | | Introduce git__reallocarray that checks the product of the number of elements and element size for overflow before allocation. Also introduce git__mallocarray that behaves like calloc, but without the `c`. (It does not zero memory, for those truly worried about every cycle.)
* allocations: test for overflow of requested sizeEdward Thomson2015-02-121-0/+1
| | | | | Introduce some helper macros to test integer overflow from arithmetic and set error message appropriately.
* Removed some useless variable assignmentsPierre-Olivier Latour2014-10-271-1/+1
|
* oid: Export `git_oid_tostr_s` instead of `_allocfmt`vmg/tostr_sVicent Marti2014-08-181-0/+8
| | | | | | The old `allocfmt` is of no use to callers, as they are not able to free the returned buffer. Export a new API that returns a static string that doesn't need to be freed.
* git_oid_fromstrn: Simplify the implementation and fix memory access issuesJiri Pospisil2014-03-071-15/+9
|
* Make git_oid_equal a non-inline APIRussell Belfer2014-02-201-0/+5
|
* oid: handle NULL pointers passed to git_oid_shorten_free()Brodie Rao2014-01-121-0/+3
| | | | Signed-off-by: Brodie Rao <brodie@sf.io>
* Fix warningLinquize2013-09-191-1/+1
|
* oid: git_oid_shorten_add() sets GITERR_INVALID when OID set is fullLinquize2013-08-311-3/+12
|
* Merge pull request #1595 from arrbee/even-more-rename-fixesVicent Martí2013-05-241-19/+27
|\ | | | | Even more rename detection fixes
| * Add git_oid_nfmt - a flexible OID formatterRussell Belfer2013-05-171-19/+27
| | | | | | | | | | | | I frequently want to the the first N digits of an OID formatted as a string and I'd like it to be efficient. This function makes that easy and I could rewrite the OID formatters in terms of it.
* | Bugfix: Return NULL in push_leaf, when trie is fullAxel Wagner2013-05-221-1/+3
|/ | | | | os->full was set 1, but the overflowed idx_leaf was still used to index into os->nodes a little later. Returning NULL fixes that.
* Make git_oid_cmp public and add git_oid__cmpRussell Belfer2013-04-291-2/+2
|
* Add git_oid_strcmp and use it for git_oid_streqRussell Belfer2013-04-291-5/+22
| | | | | | | | Add a new git_oid_strcmp that compares a string OID with a hex oid for sort order, and then reimplement git_oid_streq using it. This actually should speed up git_oid_streq because it only reads as far into the string as it needs to, whereas previously it would convert the whole string into an OID and then use git_oid_cmp.
* Fix fragile git_oid_ncmpRussell Belfer2013-04-291-2/+5
| | | | | | | git_oid_ncmp was making some assumptions about the length of the data - this shifts the check to the top of the loop so it will work more robustly, limits the max, and adds some tests to verify the functionality.
* Introduce git_oid_compare, an exported oid cmpRussell Belfer2013-04-291-0/+5
|
* oid: Do not parse OIDs longer than 40Vicent Marti2013-03-251-1/+1
|
* git_oid_fromstrn already sets a maximum on the length of the stringXavier L2013-03-211-1/+1
|
* Added an oid function that accepts nul-terminated stringsXavier L2013-03-211-0/+5
|
* update copyrightsEdward Thomson2013-01-081-1/+1
|
* Fix oid tostr issue with NULL oidRussell Belfer2013-01-041-1/+4
| | | | | I made a small change to the behavior of this code and apparently got it wrong. Sigh.
* Make git_oid_tostr use out buffer for NULL oidRussell Belfer2013-01-041-2/+2
| | | | | | Previously a NULL oid was handled like an empty buffer and returned a status empty string. This makes git_oid_tostr() set the output buffer to the empty string instead.
* Remove use of English expletivesMartin Woodward2012-11-231-1/+1
| | | | | | Remove words such as fuck, crap, shit etc. Remove other potentially offensive words from comments. Tidy up other geopolicital terms in comments.
* Revparse: GIT_EAMBIGUOUSBen Straub2012-08-251-3/+0
| | | | Revparse now returns EAMBIGUOUS if the the spec doesn't match any refs/tags, and is <4 characters.
* Merge remote-tracking branch 'nulltoken/topic/amd64-compat' into developmentVicent Marti2012-08-021-1/+1
|\ | | | | | | | | | | | | Conflicts: src/netops.c src/netops.h src/oid.c
| * portability: Improve x86/amd64 compatibilitynulltoken2012-07-241-1/+1
| |
* | git_oid_cmp: inline memcmp by hand to optimizeMichael Schubert2012-07-291-5/+0
|/ | | | | | | | | git.git uses an inlined hashcmp function instead of memcmp, since it performes much better when comparing hashes (most hashes compared diverge within the first byte). Measurements and rationale for the curious reader: http://thread.gmane.org/gmane.comp.version-control.git/172286
* Merge branch 'new-error-handling' into developmentVicent Martí2012-05-021-35/+42
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: .travis.yml include/git2/diff.h src/config_file.c src/diff.c src/diff_output.c src/mwindow.c src/path.c tests-clar/clar_helpers.c tests-clar/object/tree/frompath.c tests/t00-core.c tests/t03-objwrite.c tests/t08-tag.c tests/t10-refs.c tests/t12-repo.c tests/t18-status.c tests/test_helpers.c tests/test_main.c
| * Fix warnings on 64-bit windows buildsRussell Belfer2012-04-171-5/+8
| | | | | | | | | | This fixes all the warnings on win64 except those in deps, which come from the regex code.
| * error-handling: Commit (WIP)Vicent Martí2012-04-021-3/+3
| |
| * Migrate index, oid, and utils to new errorsRussell Belfer2012-03-191-30/+34
| | | | | | | | | | | | | | | | | | | | | | | | This includes a few cleanups that came up while converting these files. This commit introduces a could new git error classes, including the catchall class: GITERR_INVALID which I'm using as the class for invalid and out of range values which are detected at too low a level of library to use a higher level classification. For example, an overflow error in parsing an integer or a bad letter in parsing an OID string would generate an error in this class.
* | Rename git_oid_to_string to git_oid_tostrAuthmillenon2012-03-061-1/+1
|/ | | | | To conform the naming scheme of git_oid_fromstr we should change the name of git_oid_to_string to git_oid_tostr.
* Update diff to use iteratorsRussell Belfer2012-03-021-0/+10
| | | | | | | | | | | | | This is a major reorganization of the diff code. This changes the diff functions to use the iterators for traversing the content. This allowed a lot of code to be simplified. Also, this moved the functions relating to outputting a diff into a new file (diff_output.c). This includes a number of other changes - adding utility functions, extending iterators, etc. plus more tests for the diff code. This also takes the example diff.c program much further in terms of emulating git-diff command line options.
* Update Copyright headerschu2012-02-131-1/+1
| | | | Signed-off-by: schu <schu-github@schulog.org>
* util: add git__fromhex()nulltoken2011-12-281-23/+5
|
* global: Properly use `git__` memory wrappersVicent Marti2011-10-281-4/+4
| | | | | Ensure that all memory related functions (malloc, calloc, strdup, free, etc) are using their respective `git__` wrappers.
* oid: Add git_oid_streq() which checks if an oid and an hex formatted string ↵nulltoken2011-10-131-0/+11
| | | | are equal
* oid: add missing check to git_oid_fromstrnJ. David Ibáñez2011-10-021-0/+3
| | | | Signed-off-by: J. David Ibáñez <jdavid.ibp@gmail.com>
* oid: now git_oid_fromstrn checks whether the given string is too shortJ. David Ibáñez2011-09-301-0/+3
| | | | Signed-off-by: J. David Ibáñez <jdavid.ibp@gmail.com>
* oid: optimize git_oid_fromstrn by using memsetJ. David Ibáñez2011-09-301-2/+1
| | | | Signed-off-by: J. David Ibáñez <jdavid.ibp@gmail.com>
* oid: make git_oid_fromstrn support hex strings of odd lengthJ. David Ibáñez2011-09-301-5/+9
| | | | | | This fixes issue #433. Signed-off-by: J. David Ibáñez <jdavid.ibp@gmail.com>
View Lorry Controller Status