From 854eccbb2d86c2910f9d98dc52f9ebd0e37c262a Mon Sep 17 00:00:00 2001 From: Russell Belfer Date: Wed, 29 Feb 2012 12:04:59 -0800 Subject: Clean up GIT_UNUSED macros on all platforms It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5 did not fix the GIT_USUSED behavior on all platforms. This commit walks through and really cleans things up more thoroughly, getting rid of the unnecessary stuff. To remove the use of some GIT_UNUSED, I ended up adding a couple of new iterators for hashtables that allow you to iterator just over keys or just over values. In making this change, I found a bug in the clar tests (where we were doing *count++ but meant to do (*count)++ to increment the value). I fixed that but then found the test failing because it was not really using an empty repo. So, I took some of the code that I wrote for iterator testing and moved it to clar_helpers.c, then made use of that to make it easier to open fixtures on a per test basis even within a single test file. --- tests-clar/diff/index.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'tests-clar/diff/index.c') diff --git a/tests-clar/diff/index.c b/tests-clar/diff/index.c index 0941c7c21..171815df5 100644 --- a/tests-clar/diff/index.c +++ b/tests-clar/diff/index.c @@ -5,16 +5,12 @@ static git_repository *g_repo = NULL; void test_diff_index__initialize(void) { - cl_fixture_sandbox("status"); - cl_git_pass(p_rename("status/.gitted", "status/.git")); - cl_git_pass(git_repository_open(&g_repo, "status/.git")); + g_repo = cl_git_sandbox_init("status"); } void test_diff_index__cleanup(void) { - git_repository_free(g_repo); - g_repo = NULL; - cl_fixture_cleanup("status"); + cl_git_sandbox_cleanup(); } void test_diff_index__0(void) -- cgit v1.2.1