delta/libvirt.git/src/admin, branch master

util: virtypedparam: Remove return values from virTypedParamListAdd* APIs

2023-05-02T12:32:46+00:00

The function now return always 0. Refactor the code and remove return
values.

Signed-off-by: Peter Krempa 
Reviewed-by: Ján Tomko

util: virtypedparam: Refactor return value of virTypedParamListStealParams

2023-05-02T12:32:46+00:00

Return the number of parameters via pointer passed as argument to free
up possibility to report errors. Strangely all callers actually use
'int' as type for storing the count of elements, thus this function will
use the same.

The function is also renamed to virTypedParamListSteal.

Signed-off-by: Peter Krempa 
Reviewed-by: Ján Tomko

util: virtypedparam: Introduce virTypedParamListNew()

2023-05-02T12:32:46+00:00

Add an allocator function and refactor all allocations to use it. In
upcoming patches 'struct _virTypedParamList' will be made private.

Signed-off-by: Peter Krempa 
Reviewed-by: Ján Tomko 
Reviewed-by: Martin Kletzander

meson: drop explicit python interpreter

2023-04-17T13:02:35+00:00

meson wraps python scripts already on win32, so we end up with these
failing commands:

[1/359] "C:/msys64/ucrt64/bin/meson" "--internal" "exe" "--capture" "src/util/virkeycodetable_atset1.h" "--" "sh" "C:/msys64/home/marca/src/libvirt/scripts/meson-python.sh" "C:/msys64/ucrt64/bin/python3.EXE" "python" "C:/msys64/home/marca/src/libvirt/src/keycodemapdb/tools/keymap-gen" "code-table" "--lang" "stdc" "--varname" "virKeyCodeTable_atset1" "C:/msys64/home/marca/src/libvirt/src/keycodemapdb/data/keymaps.csv" "atset1"
FAILED: src/util/virkeycodetable_atset1.h
"C:/msys64/ucrt64/bin/meson" "--internal" "exe" "--capture" "src/util/virkeycodetable_atset1.h" "--" "sh" "C:/msys64/home/marca/src/libvirt/scripts/meson-python.sh" "C:/msys64/ucrt64/bin/python3.EXE" "python" "C:/msys64/home/marca/src/libvirt/src/keycodemapdb/tools/keymap-gen" "code-table" "--lang" "stdc" "--varname" "virKeyCodeTable_atset1" "C:/msys64/home/marca/src/libvirt/src/keycodemapdb/data/keymaps.csv" "atset1"

If LC_ALL, LANG and LC_CTYPE need to be set, it would probably be better
to use a meson environment() instead.

Signed-off-by: Marc-André Lureau 
Reviewed-by: Michal Privoznik

admin: Update format strings in translated messages

2023-04-01T09:40:32+00:00

Signed-off-by: Jiri Denemark 
Reviewed-by: Daniel P. Berrangé

Drop checks for virURIFormat() retval

2023-02-08T15:50:45+00:00

The virURIFormat() function either returns a string, or aborts
(on OOM). There's no way this function can return NULL (as of
v7.2.0-rc1~277). Therefore, it doesn't make sense to check its
retval against NULL.

Signed-off-by: Michal Privoznik 
Reviewed-by: Peter Krempa

admin: use struct zero initializer instead of memset

2023-01-17T17:33:54+00:00

This is a more concise approach and guarantees there is
no time window where the struct is uninitialized.

Reviewed-by: Ján Tomko 
Signed-off-by: Daniel P. Berrangé

admin: use VIR_LOCK_GUARD in client code

2023-01-17T17:33:54+00:00

Using VIR_LOCK_GUARD enables the 'done' goto label to be
eliminated.

Reviewed-by: Ján Tomko 
Signed-off-by: Daniel P. Berrangé

admin: fix leak of typed parameters on error

2023-01-10T13:26:04+00:00

A few admin client methods had the xdr_free call the wrong
side of the cleanup label, so typed parameters would not
be freed on error.

Reviewed-by: Martin Kletzander 
Signed-off-by: Daniel P. Berrangé

util: remove virObjectUnref() adapters

2022-07-15T21:44:39+00:00

These wrapper functions were used to adapt the virObjectUnref() function
signature for different callbacks. But in commit 0d184072, the
virObjectUnref() function was changed to return a void instead of a
bool, so these adapters are no longer necessary.

Signed-off-by: Jonathon Jongsma 
Reviewed-by: Erik Skultety