delta/libvirt.git/src/util/virnetdevbandwidth.c, branch master

util: Update format strings in translated messages (part 3)

2023-04-01T09:40:35+00:00

Signed-off-by: Jiri Denemark 
Reviewed-by: Daniel P. Berrangé

virnetdevbandwidth: Unbreak tc filter update on Linux-4.20+

2022-11-24T14:51:42+00:00

Guests are allowed to change their MAC addresses. Subsequently,
we may respond to that with tweaking that part of host side
configuration that depends on it. In this particular case: QoS.

Some parts of QoS are in fact set on corresponding bridge, where
overall view on traffic can be seen. Here, TC filters are used to
place incoming packets into qdiscs. These filters match source
MAC address. Therefore, upon guest changing its MAC address, the
corresponding TC filter needs to be updated too. This is done by
simply removing the old one and instantiating a new one, with new
MAC address.

Now, u32 filters (which we use) use a hash table for matching,
internally. And when deleting the old filter, we used to remove
the hash table (ID = 800::) and let the new filter instantiate
new hash table. This used to work, until kernel release 4.20
(specifically commit v4.20-rc1~27^2~131^2~11 and its friends)
where this practice was turned into error.

But that's okay - we can delete the specific filter we are after
and not touch the hash table at all.

Signed-off-by: Michal Privoznik 
Reviewed-by: Jiri Denemark

util: Remove unused includes

2022-06-16T04:43:57+00:00

Signed-off-by: Peng Liang 
Reviewed-by: Ján Tomko

util: refactor virNetDevBandwidthUnplug

2022-01-28T19:38:44+00:00

Remove pointless 'ret', cmd variable reuse and use g_auto.

Signed-off-by: Ján Tomko 
Reviewed-by: Michal Privoznik

util: refactor virNetDevBandwidthPlug

2022-01-28T19:38:44+00:00

Use g_auto, split the double use of 'cmd' variable and remove useless
ret variable.

Signed-off-by: Ján Tomko 
Reviewed-by: Michal Privoznik

util: virNetDevBandwidthClear: use g_auto

2022-01-28T19:38:44+00:00

Separate the two uses of 'cmd' to avoid mixing manual and automatic
cleanup.

Signed-off-by: Ján Tomko 
Reviewed-by: Michal Privoznik

util: virNetDevBandwidthManipulateFilter: use g_auto

2022-01-28T19:38:44+00:00

Reduce the scope of the variable to avoid renaming it.

Signed-off-by: Ján Tomko 
Reviewed-by: Michal Privoznik

util: virNetDevBandwidthUpdateRate: refactor

2022-01-28T19:38:44+00:00

Use automatic cleanup and remove the 'ret' variable in favor of
direct returns.

Signed-off-by: Ján Tomko 
Reviewed-by: Michal Privoznik

virnetdev: move virNetDevSetRootQDisc to virnetdevbandwidth

2021-04-21T12:19:34+00:00

The function in question uses "tc" binary so virnetdevbandwidth feels
like better place for it.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrangé

lib: Drop internal virXXXPtr typedefs

2021-04-13T15:00:38+00:00

Historically, we declared pointer type to our types:

  typedef struct _virXXX virXXX;
  typedef virXXX *virXXXPtr;

But usefulness of such declaration is questionable, at best.
Unfortunately, we can't drop every such declaration - we have to
carry some over, because they are part of public API (e.g.
virDomainPtr). But for internal types - we can do drop them and
use what every other C project uses 'virXXX *'.

This change was generated by a very ugly shell script that
generated sed script which was then called over each file in the
repository. For the shell script refer to the cover letter:

https://listman.redhat.com/archives/libvir-list/2021-March/msg00537.html

Signed-off-by: Michal Privoznik 
Reviewed-by: Peter Krempa