Reno was assuming all tags ending in -eol represented an old, EOL'd stable branch. That's not true for Ironic projects which have bugfix branches. Update the regexp to exclude those branches. Co-Authored-By: Adam McArthur <adam@mcaq.me> Change-Id: I265969ab40a98a02962c2fc8460b6519ab576f99 (cherry picked from commit f8fc7e52f36de5c3515e60f5d2e6347a538a80d8)
IPA dropped support for Python2 long ago, and now Python2 is not even available in newer distros, breaking installation if IPA binary dependencies. WIP because we should consider switching the check-requirements job to use a bionic node instead of jammy, or remove it entirely Change-Id: I75a618f94de58f6de2bd96b37de1894bb0e61998 (cherry picked from commit d8a6bf5f61eb1365294c6c07840286f46c9535fc) (cherry picked from commit 5cc653cbfe32699c9940d34842d5b4a5e2fe35a0) (cherry picked from commit b62f13aeb776b9d6995b623d802ebaf3a20e3879) (cherry picked from commit 25bcef86b52c2a7458c1197133ed0c07191108e4) (cherry picked from commit 107c0e3ea34cabe6eaf15e8bf76b99f4868c78fb)
In case no BOM is present in the CSV file the utf-16 codec won't work.
We fail over to utf-16-le as Little Endian is commonly used.
NOTE: The original change landed this fix in efi_utils.py, however
that was introduced after the Xena development cycle, so this
backport moves the original change to where the code originally
came from to populate the efi_utils.py file.
Change-Id: I3e25ce4997f5dd3df87caba753daced65838f85a
(cherry picked from commit 697fa6f3b6db10408eaadd57450456de87f13519)
(cherry picked from commit 99b9d1403cacd3bbd489a6cf6913f32746ef6083)
Change-Id: I1e7a3b3c9ded13b10002bb47e98d4a7b486e1dd4
Use add instead of update to re-read the partition table with partx. See [1] for more details. Co-authored-by: Arne Wiebalck <arne.wiebalck@cern.ch> [1] https: //opendev.org/openstack/ironic-python-agent/commit/dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0 Change-Id: I2336e22dadc790cfbde87904612fcaa3b8c501db (cherry picked from commit 23e67b5fea58295d0320f99d4513a66d720f09ee) (cherry picked from commit 56e63ce36a72448e128c01605d98492c80dca38f)
Re-read the partition table with 'partx -a', rather than 'partx -u'. This should fix an timing issue where the bootloader installation fails to mount the EFI partition from a whole disk image since it is not yet aware of the new partitions (observed with both, the iscsi and the direct deploy interface). Change-Id: If5da3075e813ae01df3decf8f0647aba111b0515 (cherry picked from commit dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0) (cherry picked from commit ab3e8a75badf2719602b2416af9e3c19d7511c79)
I accidently put colons on the test data and remembered taking the colon character out of the regex I was working on, but apparently left it in, and accounted for the active entry indicator flag which appears to have inconsistent support across vendors. The regex has been fixed, and a test added from a Lenovo SR650 which has some additional string entry data in the UEFI output which may separate entries. Change-Id: I1f67b0fb1f645fa82e98bd7c7bba3ffc7755cc74 (cherry picked from commit e10f052c06c03016b0ff4d9c1f3191c79fc50a1a) (cherry picked from commit 87a30ff4fa93e710efa2f9eeb227c779d40c16af) (cherry picked from commit 25f89e4d8859ec1a3e811c3d916cf49d603754fc)
Some firmware seems to take an objection with EFI nvram entries being deleted after one is added, resulting in the entire entry table being reset to the last known good state. This is problematic, as ultimately deployments can time out if we previously booted with Networking, and the machine, while commanded to do other wise, reboots back to networking regardless. We will now delete entries first, before proceeding. Additionally, for general use, this pattern may serve the community better by avoiding cases where we would have previously just relied upon efibootmgr[0] to warn us of duplicate entries. [0]: https://github.com/rhboot/efibootmgr/blob/103aa22ece98f09fe3ea2a0c83988f0ee2d0e5a8/src/efibootmgr.c#L228 Change-Id: Ib61a7100a059e79a8b0901fd8f46b9bc41d657dc Story: 2009649 Task: 43808 (cherry picked from commit 67eddfa7e3fedbb530045f5b43a2c89db832fa2a) (cherry picked from commit 33b39705a50513c5af411216b48e2a6f6ac9ab14) (cherry picked from commit 8fca1457399ac7892427fac1b9ab74a4ac653f05) (cherry picked from commit 47ac40a7f943d0ce6e58f43330a73ac144c23aa1)
When debugging boot manager problems it can be advantageous to see all the full entries rather then just their labels. Depends-On: https://review.opendev.org/c/openstack/ironic/+/818394 Change-Id: I6a1bb78acaf5a4284727bdf533d4be6db2099f50 (cherry picked from commit caf695f70ab366498b46cb6f07f6751369c67e30) (cherry picked from commit 9753b61a51008da4f0b948b0c89665b762eb95c4) (cherry picked from commit 750934a20794efdcfe8340eec75996466c4c7665)