delta/openstack/ironic-python-agent.git/ironic_python_agent/shell/write_image.sh, branch master

Rewrite write_image.sh in Python

2021-05-18T12:45:13+00:00

Change-Id: I0caa65561948f4e0934943a7a0d3a209701b5a59

Enable out-of-order writes when writing whole disk images

2021-05-18T12:41:21+00:00

Per documentation it improves performance when using -O host_device.

Change-Id: Ic6a97af9f865d07c9cb4257397a320475a28f88b

Add a call to "udevadm settle" in write_image.sh

2021-04-20T16:48:46+00:00

After GPT and MBR are destroyed systemd-udevd gets triggered
which may hold /dev/sda open preventing qemu-img from writting
its image.

Story: 2008830
Task: 42312
Change-Id: I6105192a16fcb7f6898910e8d0ab824d731d491d

Increase the memory limit for qemu-img

2021-03-02T11:38:57+00:00

We appear to be bumping up against this limit when deploying
RHCOS images(currently 977MB). Curiously the problem isn't
happening all the time but increasing the limit eliminates it.

This limit was intruduced to guard against a malicious image
allocating an arbitrary amount of memory. Nothing else runs
on hosts when IPA is running so we should be ok bumping up
the limit.

Story: #2008667
Task: #41955
Change-Id: I9405995915a874b00b7177c9642c5469d05d66a8

Clear GPT and MBR headers with dd to avoid sgdisk CRC errors

2018-08-08T16:40:22+00:00

This change adds a dd before the existing sgdisk -Z command to
workaround CRC verification errors.

Change-Id: Ia1ac4e1c0faf14ad4bb11c2a1c796c93ca8cb5e3
Closes-Bug: #1737556
Story: 1737556
Task: 11496

Fix for fatal error when GPT was used and only MBR was cleaned

2018-05-17T10:51:55+00:00

You can generate this error if after having provisioned a node
using GPT partitioning, you clean its MBR using say
dd if=/dev/zero bs=1024 count=1 of=/dev/sda
and then cleanup all Ironic/Bifrost informations to get it
reprovisioned.
In this case sgdisk -Z returns an error and last_error field
in Ironic contains:
Error writing image to device: Writing image to device
        /dev/sda failed with exit code 2
Caution: invalid main GPT header, but valid backup;
        regenerating main header\nfrom backup!\n
        \nInvalid partition data!\

Change-Id: Ib617737fff5e40cb376edda0232e0726d9c71231

Limit memory usage when running qemu-img convert

2017-01-19T18:01:30+00:00

This patch is limiting the memory address space to 1 GiB when invoking
qemu-img convert. The qemu-img command can be exploited so we better
play on the safe side (See: bug #1449062).

Change-Id: I2088f74b32d1392310c569cfaa7fd368cb737421
Closes-Bug: #1657808

Add bash scripts style checking for IPA

2016-11-09T22:14:40+00:00

Updated file tox.ini allows to check code style in all ".sh" files
included in Ironic Python Agent. Checking can be invoked by calling either
"tox" or "tox -e pep8".

Change-Id: Ie76605737c7db10a064f2aebfda388372a4c0591
Closes-Bug: #1625215

Clear GPT and MBR data structures on disk before imaging

2016-02-09T17:13:07+00:00

This patch clears all GPT and MBR data structures on the disk.
GPT maintains its data structures at start and at end of the
disk.

Change-Id: I8d0b367755b568cb44f02f62b873659b4bea0f14
Closes-Bug: #1543339

Use host_device mode for qemu-img

2015-06-18T20:00:25+00:00

When writing to a host device, possibly one that does not support holes,
it is preferable to use host_device instead of the raw mode. Not doing so
means holes are simply skipped and the deployed image is invalid.

Change-Id: I24f8b4daf099af8bb03c3a4f6417b6c87bd49021
Closes-Bug: #1466632