delta/openstack/ironic-python-agent.git/ironic_python_agent/tests/unit/test_api.py, branch 3.2.0

Prevent tests' unmocked access to utils.execute()

2017-05-15T00:48:43+00:00

This change introduces a new base test class that mocks out
utils.execute and forces an exception if it gets called.
This has rooted out many tests that were doing this as a side effect of
calling other functions, doing things like modprobe and running iscsi
on the host's actual machine.

The tests are all now appropriately patched in places where this was
happening, and the new base class permanently prevents this from
accidentally happening again.

If you really want to call utils.execute() then you need to re-mock it
in your unit test.

Change-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518

Add missing 'autospec' argument to mock.patch

2017-03-19T17:04:19+00:00

Add missing 'autospec' keyword argument to mock.patch and
mock.patch.object calls. Use 'autospec=True' except for a few cases
where it fails because the mocked function is a @classmethod and it
doesn't work. In that case explicity set it to 'autospec=False'

Change-Id: I620dce91abaa4440e1803aeefb3e93c0b65d1419

Merge "Removes the use of mutables as default args"

2016-06-20T17:25:29+00:00

Removes the use of mutables as default args

2016-06-20T06:08:12+00:00

Passing mutable objects as default args is a known Python pitfall.
We'd better avoid this. This commit changes mutable default args with
None, 'arg = [] if arg is None else arg'.

TrivialFix

Change-Id: I384b24e81543999a8b873e3223cd409ed799ffa0

Use assertIn and assertNotIn

2016-06-17T16:01:43+00:00

Tests should use:
  self.assertIn(value, list)
  self.assertNotIn(value, list)

instead of:
  self.assertTrue(value in list)
  self.assertFalse(value in list)

because assertIn and assertNotIn raise more meaningful errors:
  self.assertIn(3, [1, 2]
  >>> MismatchError: 3 not in [1, 2]

  self.assertTrue(3 in [1, 2])
  >>> AssertionError: False is not true

Change-Id: I2d1c78fe71fe03e350b1035123b0a48b7186a6ec
Closes-Bug: #1510007

Remove unused parameter

2016-06-14T14:21:26+00:00

unit.test_api have an unused parameter in _make_app.

Change-Id: I1e313803e43a0e69c547695333116cc0432043da

Fix params order in assertEqual

2016-01-13T02:03:11+00:00

Fix params order to correspond to real signature:
    assertEqual(expected, actual)

Change-Id: I129aad5d8bb7ca0541c07913cb5edd8eef9e90ba
Closes-Bug: #1277104

Add base for IPA functional tests

2015-08-18T16:19:47+00:00

Starts up an agent in a thread and then runs functional tests against
it.

Add the first functional test of the API: a simple test of the
commands API.

Co-Authored-By: Mario Villaplana 
Change-Id: If4ad611929d388a2a9454224646cb296bd0ba0ce