delta/openstack/ironic-python-agent.git/ironic_python_agent, branch 2.2.4 opendev.org: openstack/ironic-python-agent.git Merge "[LLDP] Skip NICs that say they are ready but are unreadable." into stable/pike 2018-06-27T14:09:00+00:00 Zuul zuul@review.openstack.org 2018-06-27T14:09:00+00:00 44a27d26bdb90575eaabb764da304e29cb7fb613 






Fix for fatal error when GPT was used and only MBR was cleaned
2018-06-04T11:39:34+00:00

Olivier Bourdon
obourdon@opennext.io

2018-05-17T10:50:41+00:00

957b48703d70c7b315221d55a3296a84f8096eb3

You can generate this error if after having provisioned a node
using GPT partitioning, you clean its MBR using say
dd if=/dev/zero bs=1024 count=1 of=/dev/sda
and then cleanup all Ironic/Bifrost informations to get it
reprovisioned.
In this case sgdisk -Z returns an error and last_error field
in Ironic contains:
Error writing image to device: Writing image to device
        /dev/sda failed with exit code 2
Caution: invalid main GPT header, but valid backup;
        regenerating main header\nfrom backup!\n
        \nInvalid partition data!\

Change-Id: Ib617737fff5e40cb376edda0232e0726d9c71231
(cherry picked from commit 5fcf3f066ccdbcc081ae35ab25f1c18737b94778)





You can generate this error if after having provisioned a node
using GPT partitioning, you clean its MBR using say
dd if=/dev/zero bs=1024 count=1 of=/dev/sda
and then cleanup all Ironic/Bifrost informations to get it
reprovisioned.
In this case sgdisk -Z returns an error and last_error field
in Ironic contains:
Error writing image to device: Writing image to device
        /dev/sda failed with exit code 2
Caution: invalid main GPT header, but valid backup;
        regenerating main header\nfrom backup!\n
        \nInvalid partition data!\

Change-Id: Ib617737fff5e40cb376edda0232e0726d9c71231
(cherry picked from commit 5fcf3f066ccdbcc081ae35ab25f1c18737b94778)







[LLDP] Skip NICs that say they are ready but are unreadable.
2018-05-28T08:36:25+00:00

Sam Betts
sam@code-smash.net

2017-02-15T16:31:33+00:00

14ac444f7c8e708ef71ba7d83277768bac0de9c0

While listening for LLDP packets, if one of the sockets marks itself as
ready to read then our code will try to read data from that socket, but
if something goes wrong while reading that data then it causes IPA to
raise out of the loop skipping any other of the other NICs which might
have worked. This patch adds code to catch and LOG any exception that is
raised while we are trying to read data from one of the sockets so that
we can proceed to process all the NICs.

Change-Id: I8546097f5ae23755a5fdb448902007a2d823b7bf
Closes-Bug: #1665025
(cherry picked from commit b536fbba616d958e58b110c8f86ea569f8834d7c)





While listening for LLDP packets, if one of the sockets marks itself as
ready to read then our code will try to read data from that socket, but
if something goes wrong while reading that data then it causes IPA to
raise out of the loop skipping any other of the other NICs which might
have worked. This patch adds code to catch and LOG any exception that is
raised while we are trying to read data from one of the sockets so that
we can proceed to process all the NICs.

Change-Id: I8546097f5ae23755a5fdb448902007a2d823b7bf
Closes-Bug: #1665025
(cherry picked from commit b536fbba616d958e58b110c8f86ea569f8834d7c)







Ignore IPv6 link local addresses
2017-11-21T17:11:05+00:00

Derek Higgins
derekh@redhat.com

2017-11-16T12:38:21+00:00

07050db1d1b27f0d7c7e662324feceac1420f8d9

Prevent IPA from picking up the IPv6 link-local address
as a callback_url in cases where it gets tried before other
addressing methods havn't complete yet. In this scenario IPA
sleeps for 10 seconds and then retries giving the nic a chance to
configure its routable IP address.

Change-Id: Ic53334c630180f0d77bb0231e548d2c44bfe55ca
Closes-Bug: #1732692
(cherry picked from commit 214790d17e35edd48e1b18f3ceabba91859e3247)





Prevent IPA from picking up the IPv6 link-local address
as a callback_url in cases where it gets tried before other
addressing methods havn't complete yet. In this scenario IPA
sleeps for 10 seconds and then retries giving the nic a chance to
configure its routable IP address.

Change-Id: Ic53334c630180f0d77bb0231e548d2c44bfe55ca
Closes-Bug: #1732692
(cherry picked from commit 214790d17e35edd48e1b18f3ceabba91859e3247)







Fix waiting for target disk to appear
2017-10-17T14:25:05+00:00

Lucas Alvares Gomes
lucasagomes@gmail.com

2017-03-09T14:02:06+00:00

bd8c6c7420c5a913ff407da569c1b8dfbc0a488a

This patch is changing the _wait_for_disks() method behavior to wait to
a specific disk if any device hints is specified. There are cases where
the deployment might fail or succeed randomly depending on the order and
time that the disks shows up.

If no root device hints is specified, the method will just wait for any
suitable disk to show up, like before.

The _wait_for_disks call was made into a proper hardware manager method.
It is now also called each time the cached node is updated, not only
on start up. This is to ensure that we wait for the device, matching
root device hints (which are part of the node).

The loop was corrected to avoid redundant sleeps and warnings.

Finally, this patch adds more logging around detecting the root device.

Co-Authored-By: Dmitry Tantsur <dtantsur@redhat.com>
Change-Id: I10ca70d6a390ed802505c0d10d440dfb52beb56c
Closes-Bug: #1670916
(cherry picked from commit 3189c16a5e95ade468fa8bc37302eb9979f5a8c9)





This patch is changing the _wait_for_disks() method behavior to wait to
a specific disk if any device hints is specified. There are cases where
the deployment might fail or succeed randomly depending on the order and
time that the disks shows up.

If no root device hints is specified, the method will just wait for any
suitable disk to show up, like before.

The _wait_for_disks call was made into a proper hardware manager method.
It is now also called each time the cached node is updated, not only
on start up. This is to ensure that we wait for the device, matching
root device hints (which are part of the node).

The loop was corrected to avoid redundant sleeps and warnings.

Finally, this patch adds more logging around detecting the root device.

Co-Authored-By: Dmitry Tantsur <dtantsur@redhat.com>
Change-Id: I10ca70d6a390ed802505c0d10d440dfb52beb56c
Closes-Bug: #1670916
(cherry picked from commit 3189c16a5e95ade468fa8bc37302eb9979f5a8c9)







Remove hard-coded path to grub binaries
2017-09-26T10:25:24+00:00

Vasyl Saienko
vsaienko@mirantis.com

2017-09-14T13:05:25+00:00

f05702e9f2157259fd9e8c7d927ea13da98f7f9d

Use PATH variable to find grub binaries.

Closes-Bug: 1717255

Change-Id: Ic6a2bafdc87e33c4e1c4534fa355f995c824b945
(cherry picked from commit db5272cfea9fa894675690d54b7d042cb3d01df3)





Use PATH variable to find grub binaries.

Closes-Bug: 1717255

Change-Id: Ic6a2bafdc87e33c4e1c4534fa355f995c824b945
(cherry picked from commit db5272cfea9fa894675690d54b7d042cb3d01df3)







Remove assumption that a valid IPMI channel cannot follow an invalid one
2017-09-12T15:31:56+00:00

Dmitry Tantsur
divius.inside@gmail.com

2017-09-11T14:08:33+00:00

81ac0b4115633437a53da99cd73ac6663e0b98e4

It seems to be incorrect at least for some iLO machines.
Also harden the code against invalid output from ipmitool.

Change-Id: I733785e9c7d86eadca963f0776910504bf91bcfe
Closes-Bug: #1714944
(cherry picked from commit d6ff5116f4a5586238d44a196ec89d844b151f9d)





It seems to be incorrect at least for some iLO machines.
Also harden the code against invalid output from ipmitool.

Change-Id: I733785e9c7d86eadca963f0776910504bf91bcfe
Closes-Bug: #1714944
(cherry picked from commit d6ff5116f4a5586238d44a196ec89d844b151f9d)







Merge "BMC can be configured using different lan channel"
2017-08-10T09:39:55+00:00

Jenkins
jenkins@review.openstack.org

2017-08-10T09:39:55+00:00

a48712018724eb9c24d41f901ed411a9f3cd4806












BMC can be configured using different lan channel
2017-08-09T13:35:57+00:00

Mateusz Kowalski
mateusz.kowalski@cern.ch

2017-07-05T16:20:43+00:00

7c28332e9a59da316a9d6e6652f4269b27b3ca66

It may happen that BMC is configured to use non-zero channel.
In this case we should iterate across all of them as long as we
get a correct IP address (in this case different than "0.0.0.0"
which is a placeholder for not configured console).

Change-Id: I3c351af1882b24c8f56e4363249b19b5c3a4a446
Closes-Bug: #1702514





It may happen that BMC is configured to use non-zero channel.
In this case we should iterate across all of them as long as we
get a correct IP address (in this case different than "0.0.0.0"
which is a placeholder for not configured console).

Change-Id: I3c351af1882b24c8f56e4363249b19b5c3a4a446
Closes-Bug: #1702514







Collect processor, memory and BIOS output of dmidecode - follow-up
2017-07-27T14:30:54+00:00

Ramamani Yeleswarapu
ramamani.yeleswarapu@intel.com

2017-07-27T14:29:00+00:00

3ab779c8976116db3b9c6edc5ea8227a19e41f3f

Fixes nits, modifies unit tests.

This is a follow-up to commit c5544fb7a0d9d2a1481b3256c3587259368b599e.

Change-Id: Ibca82cc6e32311b1ff0be7137d8392f63e12639b
Closes-Bug: #1635057





Fixes nits, modifies unit tests.

This is a follow-up to commit c5544fb7a0d9d2a1481b3256c3587259368b599e.

Change-Id: Ibca82cc6e32311b1ff0be7137d8392f63e12639b
Closes-Bug: #1635057