summaryrefslogtreecommitdiff
path: root/ironic_python_agent/tests/unit
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Fix failure of bind mount in _install_grub2"9.2.0bugfix/9.2Zuul2022-10-171-3/+45
|\
| * Fix failure of bind mount in _install_grub2Vanou Ishii2022-09-221-3/+45
| | | | | | | | | | | | | | | | | | | | | | | | When IPA runs _install_grub2, IPA tries to bind mount /dev, /proc and /run to <temporal directory path root partition mounted>/{dev,proc,run}. However that bind mount fails because there aren't such mount point path under temporal directory. To fix this failure, this patch add mkdir command before bind mount. Story: 2010292 Task: 46273 Change-Id: I434ce1bf1863ee0f11c4d09918d6d2d8dc065c02
* | prioritize lsblk as a source of device serialsRozzii2022-10-103-68/+165
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current way of prioritizing ID/DM_SERIAL_SHORT or ID/DM_SERIAL works in most cases but the udev values seem to be unreliable. Based on experience it looks like lsblk might be a better source of truth than udev in regerards to serial number information. This commit makes lsblk the default provider of block device serial number information. Story: 2010263 Task: 46161 Change-Id: I16039b46676f1a61b32ee7ca7e6d526e65829113
* | SoftwareRAID: Enable skipping RAIDSJakub Jelinek2022-09-053-3/+495
|/ | | | | | | | | | | | | | Extend the ability to skip disks to RAID devices This allows users to specify the volume name of a logical device in the skip list which is then not cleaned or created again during the create/apply configuration phase The volume name can be specified in target raid config provided the change https://review.opendev.org/c/openstack/ironic-python-agent/+/853182/ passes Story: 2010233 Change-Id: Ib9290a97519bc48e585e1bafb0b60cc14e621e0f
* Merge "Create RAIDs with volume name"Zuul2022-09-022-40/+92
|\
| * Create RAIDs with volume nameJakub Jelinek2022-09-022-40/+92
| | | | | | | | | | | | | | | | Use 'volume_name' field from 'target_raid_config' to create logical disks if it is present Do not allow two logical disks to have the same volume name Change-Id: If3e4e9f8698ec3e0cb49717f8ed2087d2ba03f2c
* | Fix software raid output poisoningJulia Kreger2022-08-242-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In the event a device name is set to contain a raid device path, it is possible for the Name and Events field values of mdadm's detailed output to contain text which inadvertently gets captured and mapped as component data for the "holder" devices of the RAID set. This would cause invalid values to get passed to UEFI methods which would cause a deployment to fail under these circumstances. We now ignore the Name and Events fields in mdadm output. Change-Id: If721dfe1caa5915326482969e55fbf4697538231
* | Merge "Enable skipping disks for cleaning"9.0.0Zuul2022-08-161-2/+199
|\ \ | |/ |/|
| * Enable skipping disks for cleaningJakub Jelinek2022-08-111-2/+199
| | | | | | | | | | | | | | | | | | | | | | | | Introduce a field skip_block_devices in properties - this is a list of dictionaries Create a helper function list_block_devices_check_skip_list Update tests of erase_devices_express to use node when calling _list_erasable_devices Add tests covering various options of the skip list definition Use the helper function in get_os_install_device when node is cached Story: 2009914 Change-Id: I3bdad3cca8acb3e0a69ebb218216e8c8419e9d65
* | Merge "Use lsblk json output for safety_check_block_device"Zuul2022-08-031-15/+17
|\ \ | |/ |/|
| * Use lsblk json output for safety_check_block_deviceRiccardo Pittau2022-07-201-15/+17
| | | | | | | | Change-Id: Ibfc2e203287d92e66567c33dc48f59392852b88e
* | Merge "Guard shared device/cluster filesystems"Zuul2022-07-201-6/+196
|\ \ | |/
| * Guard shared device/cluster filesystemsJulia Kreger2022-07-191-6/+196
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Certain filesystems are sometimes used in specialty computing environments where a shared storage infrastructure or fabric exists. These filesystems allow for multi-host shared concurrent read/write access to the underlying block device by *not* locking the entire device for exclusive use. Generally ranges of the disk are reserved for each interacting node to write to, and locking schemes are used to prevent collissions. These filesystems are common for use cases where high availability is required or ability for individual computers to collaborate on a given workload is critical, such as a group of hypervisors supporting virtual machines because it can allow for nearly seamless transfer of workload from one machine to another. Similar technologies are also used for cluster quorum and cluster durable state sharing, however that is not specifically considered in scope. Where things get difficult is becuase the entire device is not exclusively locked with the storage fabrics, and in some cases locking is handled by a Distributed Lock Manager on the network, or via special sector interactions amongst the cluster members which understand and support the filesystem. As a reult of this IO/Interaction model, an Ironic-Python-Agent performing cleaning can effectively destroy the cluster just by attempting to clean storage which it percieves as attached locally. This is not IPA's fault, often this case occurs when a Storage Administrator forgot to update LUN masking or volume settings on a SAN as it relates to an individual host in the overall computing environment. The net result of one node cleaning the shared volume may include restoration from snapshot, backup storage, or may ultimately cause permenant data loss, depending on the environment and the usage of that environment. Included in this patch: - IBM GPFS - Can be used on a shared block device... apparently according to IBM's documentation. The standard use of GPFS is more Ceph like in design... however GPFS is also a specially licensed commercial offering, so it is a red flag if this is encountered, and should be investigated by the environment's systems operator. - Red Hat GFS2 - Is used with shared common block devices in clusters. - VMware VMFS - Is used with shared SAN block devices, as well as local block devices. With shared block devices, ranges of the disk are locked instead of the whole disk, and the ranges are mapped to virtual machine disk interfaces. It is unknown, due to lack of information, if this will detect and prevent erasure of VMFS logical extent volumes. Co-Authored-by: Jay Faulkner <jay@jvf.cc> Change-Id: Ic8cade008577516e696893fdbdabf70999c06a5b Story: 2009978 Task: 44985
* | Drop support for instance netbootDmitry Tantsur2022-07-072-39/+13
|/ | | | Change-Id: I2b4c543537dac8904028fdcdb590c1c214238e10
* Merge "Fix passing kwargs in clean steps"Zuul2022-07-041-0/+28
|\
| * Fix passing kwargs in clean stepswaleedm2022-07-011-0/+28
| | | | | | | | | | | | | | | | Pass kwargs to dispatch_to_managers method in execute_clean_step Change-Id: Ida4ed4646659b2ee3f8f92b0a4d73c0266dd5a99 Story: 2010123 Task: 45705
* | Merge "Gather details about bond interfaces if present"Zuul2022-07-021-10/+54
|\ \
| * | Gather details about bond interfaces if presentDerek Higgins2022-06-211-10/+54
| |/ | | | | | | | | | | | | | | | | If present gather information about bonded interfaces. Story: #2010093 Task: #45637 Change-Id: I394187640b4788ebec21c3391d33ed728fb72ffa
* | Merge "Remove oslo.serialization dependency"Zuul2022-07-023-11/+10
|\ \
| * | Remove oslo.serialization dependencyRiccardo Pittau2022-06-173-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | Use pure json instead of jsonutils. Borrow encode function from oslo.serialization to be used in the utils module. Change-Id: Ied9a2259a4329a86b4f0853bd1fb187563c0a036
* | | Merge "Collect udev properties in the ramdisk logs"Zuul2022-07-021-4/+41
|\ \ \
| * | | Collect udev properties in the ramdisk logsDmitry Tantsur2022-06-171-4/+41
| | |/ | |/| | | | | | | Change-Id: Ifcf3dfff00b604dec1e2f430369ab8053f50f137
* | | Merge "Use json for lsblk output"Zuul2022-06-303-167/+184
|\ \ \ | | |/ | |/|
| * | Use json for lsblk outputRiccardo Pittau2022-06-143-167/+184
| |/ | | | | | | | | | | | | | | | | The lsblk output is available in json format since version 2.27 of util-linux [1] https: //mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.27/v2.27-ReleaseNotes Change-Id: I0c5812736b7a320cc4ecc333f80db70eb78cc76d
* | Fix discovering WWN/serial for devicemapper devicesDmitry Tantsur2022-06-141-9/+12
|/ | | | | | | UDev prefix is DM_ not ID_ for them. On top of that, they don't have short serials (or at least don't always have). Change-Id: I5b6075fbff72201a2fd620f789978acceafc417b
* Multipath Hardware path handlingJulia Kreger2022-05-185-54/+579
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes multipath base devices from consideration by default, and instead allows the device-mapper device managed by multipath to be picked up and utilized instead. In effect, allowing us to ignore standby paths *and* leverage multiple concurrent IO paths if so offered via ALUA. In reality, anyone who has previously built IPA with multipath tooling might not have encountered issues previously because they used Active/Active SAN storage environments. They would have worked because the IO lock would have been exchanged between controllers and paths. However, Active/Passive environments will block passive paths from access, ultimately preventing new locks from being established without proper negotiation. Ultimately requiring multipathing *and* the agent to be smart enough to know to disqualify underlying paths to backend storage volumes. An additional benefit of this is active/active MPIO devices will, as long as ``multipath`` is present inside the ramdisk, no longer possibly result in duplicate IO wipes occuring accross numerous devices. Story: #2010003 Task: #45108 Resolves: rhbz#2076622 Resolves: rhbz#2070519 Change-Id: I0fd6356f036d5ff17510fb838eaf418164cdfc92
* Merge "Collect a full lsblk output in the ramdisk logs"Zuul2022-05-091-16/+4
|\
| * Collect a full lsblk output in the ramdisk logsDmitry Tantsur2022-04-291-16/+4
| | | | | | | | | | | | | | | | The existing lsblk call is very handy for an overview, but there a lot more useful pairs to collect. Collect them in a machine-readable format to be able to use in debugging and further development. Change-Id: Ib27843524421944ee93de975d275e93276a5597a
* | Merge "Do not try to guess EFI partition path by its number"8.6.0Zuul2022-05-053-39/+81
|\ \
| * | Do not try to guess EFI partition path by its numberDmitry Tantsur2022-05-043-39/+81
| |/ | | | | | | | | | | | | The logic of adding a partition number to the device path does not work for devicemapper devices (e.g. a multipath storage device). Change-Id: I9a445e847d282c50adfa4bad5e7136776861005d
* | Use a pre-defined partition UUID to detect configdrive on GPTDmitry Tantsur2022-04-291-24/+7
|/ | | | | | | | Using partition numbers is currently broken for devicemapper devices. Fortunately, GPT has partition UUIDs, so we can just generate one and use it for lookup. Change-Id: I41ffe4f8e4c6e43182090b5aa2a2b4b34f32efd5
* Use Werkzeug modern versionRiccardo Pittau2022-04-141-2/+1
| | | | | | | | | | Request class from Werkzeug now includes json capability by default. See [1] and [2] for more info. [1] https://github.com/pallets/werkzeug/commit/2cd4fa9484b5d55284a86ac200df603552ba2300 [2] https://github.com/pallets/werkzeug/commit/7b52ecd8f3a67e19df32467a832761f4f0d97c8b Change-Id: I3c74b26ef4aff07c371364203a5b39c658b552a7
* Merge "Refactor efi_utils for easier maintaining and debugging"8.5.0Zuul2022-03-181-0/+98
|\
| * Refactor efi_utils for easier maintaining and debuggingDmitry Tantsur2022-02-141-0/+98
| | | | | | | | | | | | | | | | | | | | * Move irrelevant code from inside the giant try..except block * Do not bother removing the (empty) temporary mountpoint * Fix log messages according to the actual code * Fix some code duplication * Add missing unit tests for failure case Change-Id: Id7b557419d513375816d73901e2ab6f139d765ad
* | Merge "Improve efficiency of storage cleaning in mixed media envs"Zuul2022-03-151-4/+37
|\ \
| * | Improve efficiency of storage cleaning in mixed media envsJacob Anders2022-03-151-4/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://storyboard.openstack.org/#!/story/2008290 added support for NVMe-native storage cleaning, greatly improving storage clean times on NVMe-based nodes as well as reducing device wear. This is a follow up change which aims to make further improvements to cleaning efficiency in mixed NVMe-HDD environments. This is achieved by combining NVMe-native cleaning methods on NVMe devices with traditional metadata clean on non-NVMe devices. Story: 2009264 Task: 43498 Change-Id: I445d8f4aaa6cd191d2e540032aed3148fdbff341
* | | Merge "Create fstab entry with appropriate label"Zuul2022-03-113-4/+76
|\ \ \
| * | | Create fstab entry with appropriate labelJulia Kreger2022-03-103-4/+76
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on the how the stars align with partition images being written to a remote system, we *may* end up with *either* a Partition UUID value, or a Partition's UUID value. Which are distinctly different. This is becasue the value, when collected as a result of writing an image to disk *falls* back and passes the value to enable partition discovery and matching. Later on, when we realized we ought to create an fstab entry, we blindly re-used the value thinking it was, indeed, always a Partition's UUID and not the Partition UUID. Obviously, the label type is quite explicit, either UUID or PARTUUID respectively, when initial ramdisk utilities such as dracut are searching and mounting filesystems. Adds capability to identify the correct label to utilize based upon the current state of the block devices on disk. Granted, we are likely only exposed to this because of IO race conditions under high concurrecy load operations. Normally this would only be seen on test VMs, but systems being backed by a Storage Area Network *can* exibit the same IO race conditions as virtual machines. Change-Id: I953c936cbf8fad889108cbf4e50b1a15f511b38c Resolves: rhbz#2058717 Story: #2009881 Task: 44623
* | | Merge "Run partx in verbose mode to simplify debugging"Zuul2022-03-083-54/+54
|\ \ \
| * | | Run partx in verbose mode to simplify debuggingDmitry Tantsur2022-02-143-54/+54
| | |/ | |/| | | | | | | | | | | | | Otherwise the actual failure cause is not recorded. Change-Id: If66ee97016ddf0e5c3f40ad9400ff3bc6fdebedc
* | | Merge "Add `mount` and `parted -l` to the collected commands"Zuul2022-03-081-4/+8
|\ \ \
| * | | Add `mount` and `parted -l` to the collected commandsDmitry Tantsur2022-02-141-4/+8
| |/ / | | | | | | | | | Change-Id: I1c759552220291890704d0002a62ea3f51701691
* | | Merge "Rescan device after filesystem creation"Zuul2022-03-071-4/+13
|\ \ \ | |_|/ |/| |
| * | Rescan device after filesystem creationVanou Ishii2022-02-111-4/+13
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | In work_on_disk function, IPA runs mkfs commands without following device rescan operation. This leads to incorrect content of uuids_to_return to be returned. These mkfs commands modify partition label but IPA fails to catch such changes because of no following device rescan operation. This commit adds call of device rescan function before uuids_to_return construction. Change-Id: I4e8b30deb5e2247f51ce8f10bd3271f64a264089
* | Move prepare_boot_partitions_for_softraid to raid_utilsArne Wiebalck2022-02-143-210/+222
|/ | | | | | | | | | | prepare_boot_partitions_for_softraid() is used in BIOS and UEFI modes to prepare the partitions for the bootloader. Move it from the image extensions to raid_utils to reflect this and avoid the import of an extension to efi_utils. Follow-up to 62c5674a600baeeef0af3b12baeab486870eb103. Change-Id: I9f5974fbbfea5e8cdfbb7e49bea375e5cbfdd145
* Use canonical device name for RAID device for ESPDmitry Tantsur2022-02-012-15/+53
| | | | | | | | | | It seems like tinyIPA silently replaces /dev/md/esp with /dev/md127. Find the next free /dev/md device and use it instead. Also rescan the resulting device before copying files. Change-Id: Ie04f530be434c4b1561e75f387b9da679e4607e0 Depends-On: https://review.opendev.org/c/openstack/ironic/+/827129/
* SoftwareRAID: Use efibootmgr (and drop grub2-install)Arne Wiebalck2022-01-263-27/+94
| | | | | | | | | | | | | | | Move the software RAID code path from grub2-install to efibootmgr: - remove the UEFI efibootmgr exception for software RAID - create and populate the ESPs on the holder disks - update the NVRAM with all ESPs (the component devices of the ESP mirror, use unique labels to avoid unintentional deduplication of entries in the NVRAM) Story: #2009794 Change-Id: I7ed34e595215194a589c2f1cd0b39ff0336da8f1
* Burn-in: Dynamic network pairingArne Wiebalck2022-01-101-0/+136
| | | | | | | | | | | | | Pair nodes dynamically via a distributed coordination backend for network burn-in. The algorithm uses a group to pair nodes: after acquiring a lock, a first node joins the group, releases the lock, waits for a second node, then they both leave, and release the lock for the next pair. Story: #2007523 Task: #42796 Change-Id: I572093b144bc90a49cd76929c7e8685ed45d9f6e
* Merge "Burn-in: Add options for named log files"8.3.0Zuul2021-12-091-14/+77
|\
| * Burn-in: Add options for named log filesArne Wiebalck2021-12-081-14/+77
| | | | | | | | | | | | | | | | | | | | | | | | In order to ease logging of the various burn-in steps, this patch proposes options to define the outpout files for all burn-in steps: {'agent_burnin_cpu', 'agent_burnin_vm', 'agent_burnin_fio_network', 'agent_burnin_fio_disk'}_outputfile via a node's driver-info. Story: #2007523 Task: #44102 Change-Id: I327cae5949d38e738d3c535487b3795d00ad8f1e
View Lorry Controller Status