summaryrefslogtreecommitdiff
path: root/ironic_python_agent
Commit message (Collapse)AuthorAgeFilesLines
...
* | Multipath Hardware path handlingJulia Kreger2022-05-187-57/+730
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes multipath base devices from consideration by default, and instead allows the device-mapper device managed by multipath to be picked up and utilized instead. In effect, allowing us to ignore standby paths *and* leverage multiple concurrent IO paths if so offered via ALUA. In reality, anyone who has previously built IPA with multipath tooling might not have encountered issues previously because they used Active/Active SAN storage environments. They would have worked because the IO lock would have been exchanged between controllers and paths. However, Active/Passive environments will block passive paths from access, ultimately preventing new locks from being established without proper negotiation. Ultimately requiring multipathing *and* the agent to be smart enough to know to disqualify underlying paths to backend storage volumes. An additional benefit of this is active/active MPIO devices will, as long as ``multipath`` is present inside the ramdisk, no longer possibly result in duplicate IO wipes occuring accross numerous devices. Story: #2010003 Task: #45108 Resolves: rhbz#2076622 Resolves: rhbz#2070519 Change-Id: I0fd6356f036d5ff17510fb838eaf418164cdfc92
* | Merge "Collect a full lsblk output in the ramdisk logs"Zuul2022-05-092-16/+5
|\ \
| * | Collect a full lsblk output in the ramdisk logsDmitry Tantsur2022-04-292-16/+5
| | | | | | | | | | | | | | | | | | | | | | | | The existing lsblk call is very handy for an overview, but there a lot more useful pairs to collect. Collect them in a machine-readable format to be able to use in debugging and further development. Change-Id: Ib27843524421944ee93de975d275e93276a5597a
* | | Merge "Do not try to guess EFI partition path by its number"8.6.0Zuul2022-05-054-58/+137
|\ \ \
| * | | Do not try to guess EFI partition path by its numberDmitry Tantsur2022-05-044-58/+137
| |/ / | | | | | | | | | | | | | | | | | | The logic of adding a partition number to the device path does not work for devicemapper devices (e.g. a multipath storage device). Change-Id: I9a445e847d282c50adfa4bad5e7136776861005d
* | | Use a pre-defined partition UUID to detect configdrive on GPTDmitry Tantsur2022-04-292-38/+38
|/ / | | | | | | | | | | | | | | Using partition numbers is currently broken for devicemapper devices. Fortunately, GPT has partition UUIDs, so we can just generate one and use it for lookup. Change-Id: I41ffe4f8e4c6e43182090b5aa2a2b4b34f32efd5
* | Use Werkzeug modern versionRiccardo Pittau2022-04-142-4/+2
| | | | | | | | | | | | | | | | | | | | Request class from Werkzeug now includes json capability by default. See [1] and [2] for more info. [1] https://github.com/pallets/werkzeug/commit/2cd4fa9484b5d55284a86ac200df603552ba2300 [2] https://github.com/pallets/werkzeug/commit/7b52ecd8f3a67e19df32467a832761f4f0d97c8b Change-Id: I3c74b26ef4aff07c371364203a5b39c658b552a7
* | Merge "Refactor efi_utils for easier maintaining and debugging"8.5.0Zuul2022-03-182-68/+161
|\ \ | |/ |/|
| * Refactor efi_utils for easier maintaining and debuggingDmitry Tantsur2022-02-142-68/+161
| | | | | | | | | | | | | | | | | | | | * Move irrelevant code from inside the giant try..except block * Do not bother removing the (empty) temporary mountpoint * Fix log messages according to the actual code * Fix some code duplication * Add missing unit tests for failure case Change-Id: Id7b557419d513375816d73901e2ab6f139d765ad
* | Merge "Improve efficiency of storage cleaning in mixed media envs"Zuul2022-03-152-16/+116
|\ \
| * | Improve efficiency of storage cleaning in mixed media envsJacob Anders2022-03-152-16/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://storyboard.openstack.org/#!/story/2008290 added support for NVMe-native storage cleaning, greatly improving storage clean times on NVMe-based nodes as well as reducing device wear. This is a follow up change which aims to make further improvements to cleaning efficiency in mixed NVMe-HDD environments. This is achieved by combining NVMe-native cleaning methods on NVMe devices with traditional metadata clean on non-NVMe devices. Story: 2009264 Task: 43498 Change-Id: I445d8f4aaa6cd191d2e540032aed3148fdbff341
* | | Merge "Create fstab entry with appropriate label"Zuul2022-03-115-10/+125
|\ \ \
| * | | Create fstab entry with appropriate labelJulia Kreger2022-03-105-10/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on the how the stars align with partition images being written to a remote system, we *may* end up with *either* a Partition UUID value, or a Partition's UUID value. Which are distinctly different. This is becasue the value, when collected as a result of writing an image to disk *falls* back and passes the value to enable partition discovery and matching. Later on, when we realized we ought to create an fstab entry, we blindly re-used the value thinking it was, indeed, always a Partition's UUID and not the Partition UUID. Obviously, the label type is quite explicit, either UUID or PARTUUID respectively, when initial ramdisk utilities such as dracut are searching and mounting filesystems. Adds capability to identify the correct label to utilize based upon the current state of the block devices on disk. Granted, we are likely only exposed to this because of IO race conditions under high concurrecy load operations. Normally this would only be seen on test VMs, but systems being backed by a Storage Area Network *can* exibit the same IO race conditions as virtual machines. Change-Id: I953c936cbf8fad889108cbf4e50b1a15f511b38c Resolves: rhbz#2058717 Story: #2009881 Task: 44623
* | | | Merge "Run partx in verbose mode to simplify debugging"Zuul2022-03-084-55/+55
|\ \ \ \
| * | | | Run partx in verbose mode to simplify debuggingDmitry Tantsur2022-02-144-55/+55
| | |_|/ | |/| | | | | | | | | | | | | | | | | | Otherwise the actual failure cause is not recorded. Change-Id: If66ee97016ddf0e5c3f40ad9400ff3bc6fdebedc
* | | | Merge "Add `mount` and `parted -l` to the collected commands"Zuul2022-03-082-4/+10
|\ \ \ \
| * | | | Add `mount` and `parted -l` to the collected commandsDmitry Tantsur2022-02-142-4/+10
| |/ / / | | | | | | | | | | | | Change-Id: I1c759552220291890704d0002a62ea3f51701691
* | | | Merge "Rescan device after filesystem creation"Zuul2022-03-072-4/+16
|\ \ \ \ | |_|_|/ |/| | |
| * | | Rescan device after filesystem creationVanou Ishii2022-02-112-4/+16
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In work_on_disk function, IPA runs mkfs commands without following device rescan operation. This leads to incorrect content of uuids_to_return to be returned. These mkfs commands modify partition label but IPA fails to catch such changes because of no following device rescan operation. This commit adds call of device rescan function before uuids_to_return construction. Change-Id: I4e8b30deb5e2247f51ce8f10bd3271f64a264089
* | | Use utf-16-le if BOM not presentRiccardo Pittau2022-02-221-2/+8
| |/ |/| | | | | | | | | | | In case no BOM is present in the CSV file the utf-16 codec won't work. We fail over to utf-16-le as Little Endian is commonly used. Change-Id: I3e25ce4997f5dd3df87caba753daced65838f85a
* | Move prepare_boot_partitions_for_softraid to raid_utilsArne Wiebalck2022-02-146-332/+343
|/ | | | | | | | | | | prepare_boot_partitions_for_softraid() is used in BIOS and UEFI modes to prepare the partitions for the bootloader. Move it from the image extensions to raid_utils to reflect this and avoid the import of an extension to efi_utils. Follow-up to 62c5674a600baeeef0af3b12baeab486870eb103. Change-Id: I9f5974fbbfea5e8cdfbb7e49bea375e5cbfdd145
* Use canonical device name for RAID device for ESPDmitry Tantsur2022-02-014-17/+71
| | | | | | | | | | It seems like tinyIPA silently replaces /dev/md/esp with /dev/md127. Find the next free /dev/md device and use it instead. Also rescan the resulting device before copying files. Change-Id: Ie04f530be434c4b1561e75f387b9da679e4607e0 Depends-On: https://review.opendev.org/c/openstack/ironic/+/827129/
* SoftwareRAID: Use efibootmgr (and drop grub2-install)Arne Wiebalck2022-01-266-45/+165
| | | | | | | | | | | | | | | Move the software RAID code path from grub2-install to efibootmgr: - remove the UEFI efibootmgr exception for software RAID - create and populate the ESPs on the holder disks - update the NVRAM with all ESPs (the component devices of the ESP mirror, use unique labels to avoid unintentional deduplication of entries in the NVRAM) Story: #2009794 Change-Id: I7ed34e595215194a589c2f1cd0b39ff0336da8f1
* Merge "Burn-in: Dynamic network pairing"Zuul2022-01-202-16/+269
|\
| * Burn-in: Dynamic network pairingArne Wiebalck2022-01-102-16/+269
| | | | | | | | | | | | | | | | | | | | | | | | | | Pair nodes dynamically via a distributed coordination backend for network burn-in. The algorithm uses a group to pair nodes: after acquiring a lock, a first node joins the group, releases the lock, waits for a second node, then they both leave, and release the lock for the next pair. Story: #2007523 Task: #42796 Change-Id: I572093b144bc90a49cd76929c7e8685ed45d9f6e
* | [trivial] Fix typo in __init__.pyArne Wiebalck2021-12-161-1/+1
|/ | | | Change-Id: I67810abbfb975c0d0ad0faf9807318c462580528
* Merge "Burn-in: Add options for named log files"8.3.0Zuul2021-12-092-21/+110
|\
| * Burn-in: Add options for named log filesArne Wiebalck2021-12-082-21/+110
| | | | | | | | | | | | | | | | | | | | | | | | In order to ease logging of the various burn-in steps, this patch proposes options to define the outpout files for all burn-in steps: {'agent_burnin_cpu', 'agent_burnin_vm', 'agent_burnin_fio_network', 'agent_burnin_fio_disk'}_outputfile via a node's driver-info. Story: #2007523 Task: #44102 Change-Id: I327cae5949d38e738d3c535487b3795d00ad8f1e
* | Merge "Instruct qemu-img to write image zeros to disk."Zuul2021-12-092-3/+5
|\ \
| * | Instruct qemu-img to write image zeros to disk.Derek Higgins2021-12-082-3/+5
| |/ | | | | | | | | | | | | | | | | | | Doing this will cause it not to zero out the entire block device which can be very costly on a slow HDD. Story: 2009227 Task: 43315 Change-Id: I62ba2afc037d9844387e6b0984fe5008779d95d2
* | Merge "Burn-in: Add SMART self test to disk burn-in"Zuul2021-12-092-0/+161
|\ \ | |/ |/|
| * Burn-in: Add SMART self test to disk burn-inArne Wiebalck2021-12-062-0/+161
| | | | | | | | | | | | | | | | | | | | | | Add the option to run a SMART self test right after the disk burn-in. The disk burn-in step will fail if the SMART test on any of the disk fails. Story: #2007523 Task: #43383 Change-Id: I1312d5b71bedd044581a136af0b4c43769d21877
* | Get rid of lambda in RealFilePartitioningTestCaseIury Gregory Melo Ferreira2021-11-251-10/+14
|/ | | | | | | This commit changes the lambda usage in the RealFilePartitioningTestCase to autospec to avoid problems with unexpected args. Change-Id: I21356a7783f105dde9ff0d3777e2a06f3f28a786
* Merge "Trivial: split away efibootmgr helpers"Zuul2021-11-231-13/+44
|\
| * Trivial: split away efibootmgr helpersDmitry Tantsur2021-11-191-13/+44
| | | | | | | | | | | | These are very useful for downstream deploy steps, make them public. Change-Id: I26106a07049f751d3e3cc646431e2176001f4645
* | Merge "Call execute from ironic-lib in hardware.py"Zuul2021-11-222-189/+187
|\ \ | |/ |/|
| * Call execute from ironic-lib in hardware.pyRiccardo Pittau2021-11-182-189/+187
| | | | | | | | | | | | | | | | | | Replace the execute wrapper from utils with execute from ironic-lib in hardware.py Adjust unit tests as needed. Change-Id: I63a3b0407b2ca2246bd0e6624bfa0f748c0d73f7
* | Fix compatibility with disk_utils.find_efi_partitionDmitry Tantsur2021-11-194-12/+15
| | | | | | | | | | | | | | | | | | | | This function returns the complete block device record, not just number. Fixes regression in 89bc73aa0105850c6ae44428642e31802bba3b20. Also fix the incorrect job in the gate queue, which prevented us from catching this issue on merging. Change-Id: I4cbc359ceabfc193ce18fed14a1952359460e7d9
* | Use two more functions from disk_utilsDmitry Tantsur2021-11-186-140/+18
|/ | | | Change-Id: If01c9cd7f95b4495509369786360741b731161db
* Move manage_uefi from the image extension to a public locationDmitry Tantsur2021-11-166-766/+803
| | | | | | | | | | This call is very useful for custom deploy implementations, such as one we maintain for OpenShift. Splitting it out also makes image.py slightly more manageable. The get_partition call is moved to partition_utils. Change-Id: I60a6a2823d3eb27a4ae78e913e3655dae7b54ffe
* Merge "Simplify error messages when running clean/deploy step"Zuul2021-11-134-6/+66
|\
| * Simplify error messages when running clean/deploy stepDmitry Tantsur2021-11-094-6/+66
| | | | | | | | | | | | | | | | | | | | | | The caller knows what step it invokes, there is no point in repeating it in the error message. There is also no need to wrap the exception if it's a RESTError or an ironic-lib exception already since they are normally detailed enough. Only leave a detailed message when an unexpected exception happens. Change-Id: I1d8ca1e7ed1462159e4ae5f0bcf58686f6a2681c
* | Move rescan device function to general utilsRiccardo Pittau2021-11-104-145/+208
| | | | | | | | | | | | | | We use basically the same function in two modules in the same way, let's put that in a common place. Change-Id: I4016e43f2cb102d4327bafcc8a2f90112a6f944a
* | Re-read the partition table with partx -a, part 2Riccardo Pittau2021-11-092-43/+43
|/ | | | | | | | | | | | Use add instead of update to re-read the partition table with partx. See [1] for more details. Co-authored-by: Arne Wiebalck <arne.wiebalck@cern.ch> [1] https: //opendev.org/openstack/ironic-python-agent/commit/dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0 Change-Id: I2336e22dadc790cfbde87904612fcaa3b8c501db
* Re-read the partition table with partx -aArne Wiebalck2021-11-062-17/+17
| | | | | | | | | | | Re-read the partition table with 'partx -a', rather than 'partx -u'. This should fix an timing issue where the bootloader installation fails to mount the EFI partition from a whole disk image since it is not yet aware of the new partitions (observed with both, the iscsi and the direct deploy interface). Change-Id: If5da3075e813ae01df3decf8f0647aba111b0515
* Merge "Fix UEFI record regex"Zuul2021-11-052-6/+68
|\
| * Fix UEFI record regexJulia Kreger2021-11-042-6/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | I accidently put colons on the test data and remembered taking the colon character out of the regex I was working on, but apparently left it in, and accounted for the active entry indicator flag which appears to have inconsistent support across vendors. The regex has been fixed, and a test added from a Lenovo SR650 which has some additional string entry data in the UEFI output which may separate entries. Change-Id: I1f67b0fb1f645fa82e98bd7c7bba3ffc7755cc74
* | Merge "Always include the oslo_log log file in ramdisk logs"Zuul2021-11-044-3/+67
|\ \ | |/ |/|
| * Always include the oslo_log log file in ramdisk logsDmitry Tantsur2021-10-284-3/+67
| | | | | | | | | | | | | | Even if journald is present, there is no guarantee that IPA logs there (this is the case in container-based ramdisks). Change-Id: Iceeab0010827728711e19e5b031ccac55fe1efde
* | Merge "Stop requiring mocking of utils.execute if ironic-lib execute is mocked"Zuul2021-11-032-17/+1
|\ \
View Lorry Controller Status