delta/openstack/python-cinderclient.git/cinderclient/apiclient/base.py, branch stein-eol

Merge "Fix encoding of query parameters"

2018-10-03T17:54:19+00:00

Fix encoding of query parameters

2018-09-14T00:51:17+00:00

IETF RFC 3986 classifies "~" as a reserved character [1],
however until python3.7 [2], python's url parsing
used to encode this character.

urllib has seen a lot of churn in various python
releases, and hence we were using a six wrapper
to shield ourselves, however, this backwards-incompatible
change in encoding norms forces us to deal with
the problem at our end.

Cinder's API accepts "~" in both, its encoded
or un-encoded forms. So, let's stop encoding it
within cinderclient, regardless of the version
of python running it.

Also fix an inconsitency around the use of the
generic helper method in utils added in
I3a3ae90cc6011d1aa0cc39db4329d9bc08801904
(cinderclient/utils.py - build_query_param)
to allow for False as a value in the query.

[1] https://tools.ietf.org/html/rfc3986.html
[2] https://docs.python.org/3/library/urllib.parse.html#url-quoting

Change-Id: I89809694ac3e4081ce83fd4f788f9355d6772f59
Closes-Bug: #1784728

refactor the getid method base.py

2018-08-08T02:55:44+00:00

Refer to a merged commit.
https://review.openstack.org/#/c/588983/

Refactor the getid method both in cinderclient/base.py
and in cinderclient/apiclient/base.py

TrivialFix

Change-Id: I4d1fb81f6876ab072ded3f14004ad064dcc949d3

Fix adding non-ascii attrs to Resource objects error

2017-01-20T20:12:29+00:00

Due to these lines of code [0] we don't have an opportunity
to add attributes with non-ascii symbols to Resource objects,
but information about it will be in _info dict.

Example of side effect - quota_show command.
Because we don't have such an attr, here [1] it will be added
None value instead of real value [2].

This patch fixes this problem.

[0] - https://github.com/openstack/python-cinderclient/blob/f8c93ed03b388612ca28b8055debf915ce631cec/cinderclient/apiclient/base.py#L498-L499
[1] - https://github.com/openstack/python-cinderclient/blob/f8c93ed03b388612ca28b8055debf915ce631cec/cinderclient/shell_utils.py#L179
[2] - http://paste.openstack.org/show/593358/

Change-Id: I0493845dafc5dad836e899b9c22d563023c1dab0
Closes-Bug: #1652605

Merge "Minor refactoring for nested try-block"

2016-12-23T18:59:17+00:00

Replace six.iteritems(iter) with iter.items()

2016-12-01T12:24:29+00:00

As mentioned in [1], we should avoid using six.iteritems(iter) to
achieve iterators. We can use iter.items() instead, as it will
return iterators in PY3 as well.

[1] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: Ic41abf2ca6ec3ecb651b980091b52d0a185c9089

Minor refactoring for nested try-block

2016-11-23T12:20:34+00:00

A minor refactoring for unnecessary try-block nesting.

TrivialFix

Change-Id: I8bfb2ff10f802594769a53c9c90a47ae21af1f22

Fix typo in set unicode metadata key

2016-11-16T11:03:36+00:00

Fixes typo in commit 0fd11f30f4a06f7b8cb701fa476aae4f193ac963

Change-Id: I50c59b92f6f65f7b6aa23fd530f6c4b105ad6b1d
Closes-Bug: #1622631

Move old oslo-incubator code out of openstack/common

2016-11-03T12:59:31+00:00

As part of the first community-wide goal, teams were asked to
remove the openstack/common package of their projects if one
existed. This was a byproduct of the old oslo-incubator form
of syncing common functionality.

The package, apiclient, was moved to a top level location and
cliutils was moved to the common module. There are no oslo
specific libraries, the recommended solution is to move it in
tree and maintain it there.

Change-Id: Iee52004bd33c19d63133577ff466164b85fd6ca6