delta/openstack/python-cinderclient.git/cinderclient/apiclient, branch stein-eol

Merge "Fix encoding of query parameters"

2018-10-03T17:54:19+00:00

Fix encoding of query parameters

2018-09-14T00:51:17+00:00

IETF RFC 3986 classifies "~" as a reserved character [1],
however until python3.7 [2], python's url parsing
used to encode this character.

urllib has seen a lot of churn in various python
releases, and hence we were using a six wrapper
to shield ourselves, however, this backwards-incompatible
change in encoding norms forces us to deal with
the problem at our end.

Cinder's API accepts "~" in both, its encoded
or un-encoded forms. So, let's stop encoding it
within cinderclient, regardless of the version
of python running it.

Also fix an inconsitency around the use of the
generic helper method in utils added in
I3a3ae90cc6011d1aa0cc39db4329d9bc08801904
(cinderclient/utils.py - build_query_param)
to allow for False as a value in the query.

[1] https://tools.ietf.org/html/rfc3986.html
[2] https://docs.python.org/3/library/urllib.parse.html#url-quoting

Change-Id: I89809694ac3e4081ce83fd4f788f9355d6772f59
Closes-Bug: #1784728

refactor the getid method base.py

2018-08-08T02:55:44+00:00

Refer to a merged commit.
https://review.openstack.org/#/c/588983/

Refactor the getid method both in cinderclient/base.py
and in cinderclient/apiclient/base.py

TrivialFix

Change-Id: I4d1fb81f6876ab072ded3f14004ad064dcc949d3

Remove unused cinderclient/apiclient/client.py module

2018-02-20T15:16:16+00:00

This old module was a carry over from the oslo incubator days
and is no longer used.

Change-Id: I44982d2581e90b781c78f3d2421cd1dcd8e590fd
Related-Bug: #1685678
Related-Bug: #1640269

Remove unused and duplicated fake_client module

2017-03-10T15:27:49+00:00

Change-Id: I3d3f335832b8cc44681235c79855a0cdd579894b

Handle log message interpolation by the logger

2017-02-07T15:22:27+00:00

According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Change-Id: Ib5f86d1f0846e292457813c893b73c6999e554a5
Closes-Bug: #1596829

Fix adding non-ascii attrs to Resource objects error

2017-01-20T20:12:29+00:00

Due to these lines of code [0] we don't have an opportunity
to add attributes with non-ascii symbols to Resource objects,
but information about it will be in _info dict.

Example of side effect - quota_show command.
Because we don't have such an attr, here [1] it will be added
None value instead of real value [2].

This patch fixes this problem.

[0] - https://github.com/openstack/python-cinderclient/blob/f8c93ed03b388612ca28b8055debf915ce631cec/cinderclient/apiclient/base.py#L498-L499
[1] - https://github.com/openstack/python-cinderclient/blob/f8c93ed03b388612ca28b8055debf915ce631cec/cinderclient/shell_utils.py#L179
[2] - http://paste.openstack.org/show/593358/

Change-Id: I0493845dafc5dad836e899b9c22d563023c1dab0
Closes-Bug: #1652605

Merge "Minor refactoring for nested try-block"

2016-12-23T18:59:17+00:00

Replace six.iteritems(iter) with iter.items()

2016-12-01T12:24:29+00:00

As mentioned in [1], we should avoid using six.iteritems(iter) to
achieve iterators. We can use iter.items() instead, as it will
return iterators in PY3 as well.

[1] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: Ic41abf2ca6ec3ecb651b980091b52d0a185c9089

Minor refactoring for nested try-block

2016-11-23T12:20:34+00:00

A minor refactoring for unnecessary try-block nesting.

TrivialFix

Change-Id: I8bfb2ff10f802594769a53c9c90a47ae21af1f22