<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-cinderclient.git/cinderclient/tests/test_utils.py, branch stable/kilo</title>
<subtitle>opendev.org: openstack/python-cinderclient.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/'/>
<entry>
<title>Fix order of arguments in assertEqual</title>
<updated>2014-08-18T04:41:21+00:00</updated>
<author>
<name>KIYOHIRO ADACHI</name>
<email>adachi@mxs.nes.nec.co.jp</email>
</author>
<published>2014-02-26T06:59:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=f3ec0814971112068e933e343ef7ab8986f438c3'/>
<id>f3ec0814971112068e933e343ef7ab8986f438c3</id>
<content type='text'>
Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is...

    def assertEqual(self, expected, observed, message=''):
        """Assert that 'expected' is equal to 'observed'.

        :param expected: The expected value.
        :param observed: The observed value.
        :param message: An optional message to include in the error.
        """

The string length of the sum of the results of repr(expected) and
repr(observed) is greater than 70, then, MismatchError message is
changed, as below.

  Ex.:
        raise mismatch_error
    MismatchError: !=:
    reference = '_123456789_123456789_bar'
    actual    = '_123456789_123456789_123456789_123456789_123456789'

Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
Closes-Bug: #1259292
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is...

    def assertEqual(self, expected, observed, message=''):
        """Assert that 'expected' is equal to 'observed'.

        :param expected: The expected value.
        :param observed: The observed value.
        :param message: An optional message to include in the error.
        """

The string length of the sum of the results of repr(expected) and
repr(observed) is greater than 70, then, MismatchError message is
changed, as below.

  Ex.:
        raise mismatch_error
    MismatchError: !=:
    reference = '_123456789_123456789_bar'
    actual    = '_123456789_123456789_123456789_123456789_123456789'

Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
Closes-Bug: #1259292
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable del of other tenants resources by name</title>
<updated>2013-10-29T16:12:22+00:00</updated>
<author>
<name>Jay S. Bryant</name>
<email>jsbryant@us.ibm.com</email>
</author>
<published>2013-10-25T16:43:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=8a6a291e033e0d191ac8702f05fa3e83206d61f0'/>
<id>8a6a291e033e0d191ac8702f05fa3e83206d61f0</id>
<content type='text'>
Currently, due to the way that resources are being retrieved by the
findall() function, an administrator can do a list, snapshot-list, etc.
with the --all_tenants option and see other tenants' resources.  If the
admin then tries to delete the another tenants' resource by name, it fails
with a 'No &lt;resource&gt; with a name or ID of &lt;name&gt; exists.' error.

The solution to this is to change the call to the list() function in
findall() to set the all_tenants search option to 1.  This causes the
admin to get a list of all the resources that they have access to back
when the search is done instead of just a list of their resources.  The
delete by name is then possible.  The server takes care of ensuring that
only resources that the user has access to are returned.

This will enable delete by name for all resources that use the find_resource
function.

Closes-bug: 1241682
Change-Id: I4e9957b66c11b7e1081f066d189cedc5a3cb2a6c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently, due to the way that resources are being retrieved by the
findall() function, an administrator can do a list, snapshot-list, etc.
with the --all_tenants option and see other tenants' resources.  If the
admin then tries to delete the another tenants' resource by name, it fails
with a 'No &lt;resource&gt; with a name or ID of &lt;name&gt; exists.' error.

The solution to this is to change the call to the list() function in
findall() to set the all_tenants search option to 1.  This causes the
admin to get a list of all the resources that they have access to back
when the search is done instead of just a list of their resources.  The
delete by name is then possible.  The server takes care of ensuring that
only resources that the user has access to are returned.

This will enable delete by name for all resources that use the find_resource
function.

Closes-bug: 1241682
Change-Id: I4e9957b66c11b7e1081f066d189cedc5a3cb2a6c
</pre>
</div>
</content>
</entry>
<entry>
<title>Sync with global requirements</title>
<updated>2013-08-06T17:45:24+00:00</updated>
<author>
<name>Monty Taylor</name>
<email>mordred@inaugust.com</email>
</author>
<published>2013-08-06T16:36:45+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=61006510007f7b23a25bf0bfcd8ad7d740def9e1'/>
<id>61006510007f7b23a25bf0bfcd8ad7d740def9e1</id>
<content type='text'>
Change-Id: Iccc824fef7dc7ae5675d6528a1ea33566e5f7eef
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Iccc824fef7dc7ae5675d6528a1ea33566e5f7eef
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Use exceptions from oslo"</title>
<updated>2013-07-15T16:30:05+00:00</updated>
<author>
<name>John Griffith</name>
<email>john.griffith@solidfire.com</email>
</author>
<published>2013-07-15T16:25:40+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=3d30126e93b66488b5c680578f6078201cdedc15'/>
<id>3d30126e93b66488b5c680578f6078201cdedc15</id>
<content type='text'>
This reverts commit a7cce08eab5e2e42275b84bd56127bd09b00f5bf

Change-Id: I6c0047adbc33d0d6b5890f11853974578c36c78c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit a7cce08eab5e2e42275b84bd56127bd09b00f5bf

Change-Id: I6c0047adbc33d0d6b5890f11853974578c36c78c
</pre>
</div>
</content>
</entry>
<entry>
<title>Use exceptions from oslo</title>
<updated>2013-07-01T08:55:31+00:00</updated>
<author>
<name>Alessio Ababilov</name>
<email>ilovegnulinux@gmail.com</email>
</author>
<published>2013-05-19T15:12:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=a7cce08eab5e2e42275b84bd56127bd09b00f5bf'/>
<id>a7cce08eab5e2e42275b84bd56127bd09b00f5bf</id>
<content type='text'>
These exceptions can be used in novaclient, keystoneclient,
glanceclient, and other client projects.

Partially implements: blueprint common-client-library

Change-Id: I43918316622b1c1d722872fe30199db6a3a7bb76
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These exceptions can be used in novaclient, keystoneclient,
glanceclient, and other client projects.

Partially implements: blueprint common-client-library

Change-Id: I43918316622b1c1d722872fe30199db6a3a7bb76
</pre>
</div>
</content>
</entry>
<entry>
<title>python3: fix imports compatibility</title>
<updated>2013-06-12T13:32:19+00:00</updated>
<author>
<name>Chuck Short</name>
<email>chuck.short@canonical.com</email>
</author>
<published>2013-06-12T13:28:17+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=b4ea550ba7cd7d322739fcfae8b8af7ae191c49b'/>
<id>b4ea550ba7cd7d322739fcfae8b8af7ae191c49b</id>
<content type='text'>
Python3 reorganized the standard library and moved several functions
to different modules. Six provides a consistent interface
to them through the fake six.moves module.

However, the urlparse, urllib2, etc modules have been combined
into one module which Six does not support so do it the old
fashioned way.

Change-Id: Ieb7cc7ee2a4a97807873cfe2fc3fa0a5cf3c3980
Signed-off-by: Chuck Short &lt;chuck.short@canonical.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Python3 reorganized the standard library and moved several functions
to different modules. Six provides a consistent interface
to them through the fake six.moves module.

However, the urlparse, urllib2, etc modules have been combined
into one module which Six does not support so do it the old
fashioned way.

Change-Id: Ieb7cc7ee2a4a97807873cfe2fc3fa0a5cf3c3980
Signed-off-by: Chuck Short &lt;chuck.short@canonical.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Start Gating on Pyflakes and Hacking</title>
<updated>2013-06-09T11:29:23+00:00</updated>
<author>
<name>Dirk Mueller</name>
<email>dirk@dmllr.de</email>
</author>
<published>2013-06-09T09:18:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=7359c976d1692c63118fd8b67ff215c9498725e7'/>
<id>7359c976d1692c63118fd8b67ff215c9498725e7</id>
<content type='text'>
Instead of globally ignoring Pyflakes and Hacking
warnings, only blacklist those that occur frequently
and fix the others. Start gating on those checks.

Change-Id: Ice032c16d445ef08ef018bcdc5c221ab3c323755
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of globally ignoring Pyflakes and Hacking
warnings, only blacklist those that occur frequently
and fix the others. Start gating on those checks.

Change-Id: Ice032c16d445ef08ef018bcdc5c221ab3c323755
</pre>
</div>
</content>
</entry>
<entry>
<title>Move tests into cinderclient package.</title>
<updated>2013-05-20T18:32:32+00:00</updated>
<author>
<name>Monty Taylor</name>
<email>mordred@inaugust.com</email>
</author>
<published>2013-05-18T16:22:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=bf1ce848e697418bf7cd4a5b955930e0cf41b44a'/>
<id>bf1ce848e697418bf7cd4a5b955930e0cf41b44a</id>
<content type='text'>
tests/__init__.py implies a package in the global namespace called
tests. That's not what these are - they're tests in the cinderclient
namespace.

Change-Id: I29c95bcd8747c3f5f21d5d900879c9b6b1c9a963
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
tests/__init__.py implies a package in the global namespace called
tests. That's not what these are - they're tests in the cinderclient
namespace.

Change-Id: I29c95bcd8747c3f5f21d5d900879c9b6b1c9a963
</pre>
</div>
</content>
</entry>
</feed>
