delta/openstack/python-cinderclient.git/cinderclient/tests/unit/test_shell.py, branch 4.0.3

Allow --help for specific commands

2018-04-10T19:37:22+00:00

This makes calls such as:
     $ cinder list --help

work as expected, equivalent to:
     $ cinder help list

rather than just printing the full help message.

Change-Id: I038eeeea554f0bb5dd170f503eaec570441520b3

Migrate to keystoneauth identity cli opts.

2018-01-16T12:49:14+00:00

Use keystoneauth1 to parse keystone authentication arguments. Previously
these arguments are parsed in the different service clients seperately.
Use keystoneauth1 instead will make this consistent across projects and
less error-prone.

This change is inspired by NovaClient.

Co-Authored-By: Morgan Fainberg 
Co-Authored-By: David Hu 
Co-Authored-By: Monty Taylor 

Closes-Bug: #1734945

Change-Id: I3c5141eeddd3747ff542e95b04e4848470ad9508
Signed-off-by: Zhao Chao

Fix OS_AUTH_TYPE env var usage

2017-08-04T16:10:50+00:00

Right now only deprecated OS_AUTH_SYSTEM environmental variable works to
set the authentication to noauth, the reason is that we have multiple
arguments writing on the same destination.

This patch fixes this by making both arguments have the same default
value, which is to use environmental variable OS_AUTH_TYPE if it has a
value or deprecated OS_AUTH_SYSTEM if not.

Closes-Bug: #1708687
Change-Id: I478fb0e628d4bebd4a1dc78c2559202916aa051f

Do not require network for test_noauth_plugin()

2017-06-01T14:45:45+00:00

While running the unittests, test_noauth_plugin() needs network access
and fails in build environments where no network is available:

keystoneauth1.exceptions.connection.ConnectFailure: Unable to establish \
  connection to http://example.com/v2/admin/volumes/detail: HTTPConnectionPool \
  (host='example.com', port=80): Max retries exceeded with url: /v2/admin/ \
  volumes/detail (Caused by NewConnectionError(': Failed to establish a \
  new connection: [Errno -3] Temporary failure in name resolution',))

Prevent the need of network access to be able to run the unittest in such build
envs.

Closes-Bug: #1695009
Change-Id: I123919f29de7cb72a780b5f134a5bfaa404f5b53

Fix noauth support

2017-03-24T11:24:50+00:00

This patch includes several improvements:
1. Use keystoneauth1 plugin mechanism for auth plugins.
2. Implements CinderNoAuthPlugin.
3. Deletes non-working cinderclient.auth_plugin module.
4. Deprecates --bypass-url in flavor of --os-endpoint to be consistent
with keystoneauth1 plugins.
5. Deprecates in --os-auth-system in falvor of --os-auth-type to be
consistent with keystoneauth1 plugins.

Both bypass_url and os_auth_system params are not changed for client
objects to not break backward compatibility for Python API.

How to use noauth with cinderclient CLI:
OS_USER_ID=userid OS_PROJECT_ID=projectis cinder --os-auth-type noauth
--os-endpoint=http://localhost:8776/v2 list

Change-Id: I3be59a5a39235acbc3334e0a0b797081507a5c88
Closes-Bug: #1657156

Make V3 the default and fixup version reporting

2017-03-10T17:58:50+00:00

This adds in a version-list command that reports the
min/max versions of the Cinder API supported by this
version of the client, and also queries the Cinder API
V3 server to obtain min/max micro-versions and report
those as well.

In addition, we bump the default version of the client to
3.0, of course if you specify V2 in your rc file or on the
cmd line that works fine too.

I did run into one problem where I broke:
  cinder.tests.unit.test_shell:test_cinder_service_name

Seems to be some hidden trickery with a fake, fixture or
mock that I can't figure out.  For now I added a skip to
that test, but maybe somebody can point out the problem
during review.

Change-Id: I44e667c511d89de28af758a3c9ea1f812e682f18

Fix test_version_discovery test

2016-11-22T12:48:41+00:00

Something changed in requests/urllib3 library and now it sends
requests with url in a lower-case. It affects test_version_discovery
test because we use url in camel-case.

This patch changes test url to lower-case to be compatible with old
and new behaviours.

Change-Id: I4ae9715b124adb0a2e0115c9b00ab16576665f72
Closes-Bug: #1643874

Replace 'MagicMock' with 'Mock'

2016-09-30T09:28:48+00:00

In magicmock,there just have a mock_add_spec function,in this code,there have
not called this method so i think it can be removed and call mock directly.

Change-Id: Ic3b218eecb5738769dd2c18b6029dc70210d3989

Add "start_version" and "end_version" support to argparse

2016-08-16T16:16:13+00:00

Now, "cinder help subcommand" can not show whether an argument
is supported for a specific microversion.
With this change, developers only need to add a start_version or
end_version in the utils.arg wrap, cinderclient will support
the microversion for that arguement.

    @utils.arg(
    '--foo',
    start_version='3.1')
    @utils.arg(
    '--bar',
    start_version='3.2',
    end_version='3.5')
    def do_some_action():
        ......

In previous example, an exception will be raised for such command:
   $ cinder --os-volume-api-version 3.6 --bar some-ation

And only "--foo" will show up for such help command:
   $ cinder --os-volume-api-version 3.1 help some-ation

Change-Id: I74137486992846bbf9fdff53c009851db2356eef
Partial-Bug: #1600567
Co-Authored-By: Nate Potter

Use self.ks_logger instead of ks_logger

2016-08-01T05:41:47+00:00

Currently with '--debug' option any cinder command only logs the
request from keystoneauth and not the main cinder service request.

Added keystoneauth logger to self.ks_logger so that logs can be
logged as expected.

Closes-Bug: #1606814

Change-Id: I7193aa6f43cb3186c49fc409b6e1ce7a36f596f9