delta/openstack/python-cinderclient.git/cinderclient/tests/unit/v1, branch queens-eol

Enable H306

2017-08-01T20:23:49+00:00

Enforce ordering of imports with H306.

For tests, this is mostly done by grouping test
imports after other cinderclient imports.

Change-Id: Ie40fda014d1aedb057e5b4ea1f27f999c84e6373

Fix pep8 errors

2017-03-15T12:42:49+00:00

There are some PEP8 errors that are not caught by our gate because of
the pep8 package version installed by hacking.

This patch fixes E402, W503, and F999 erors from our codebase.

Change-Id: I0b86730b1493f161645a87c3daa91ec3d774d3b1

Python3 common patterns

2017-01-10T08:55:30+00:00

Modify some codes in order to lead them meet the python3 common pattern.
Look through the following patterns of Cinder,
      map() and filter() if a list is needed on Python 3:
          Replace map(func, data) with [func(item) for item in data]
          Replace filter(lambda obj: test(obj), data) with
             [obj for obj in data if test(obj)]
      Replace exceptions.OSError with OSError and
         remove "import exceptions"
      Replace iterator.next() with next(iterator)
      Replace basestring with six.string_types
      Replace unicode with six.text_type
      Replace (str, unicode) with six.string_types
      Replace "for key in dict.iterkeys()" with "for key in dict"
      Replace dict.iteritems() with dict.items()
      Replace dict.itervalues() with dict.values()
I found that only "filter(lambda obj: test(obj), data)" and
"map(func, data)"need to modify.
The other items are not be founded in Cinder.

Reference:https://wiki.openstack.org/wiki/Python3#Common_patterns

Change-Id: If33ec39eb176c14086132d3099c6ec577f956ded

Modify assertTrue

2016-09-11T06:01:23+00:00

For example: assertTrue(v1

Fix batch deleting issue in volume_type.unset_keys()

2016-07-06T07:15:35+00:00

cinderclient volume_type.unset_keys() only delete the first key even if
multiple keys are applied. The response of manager._delete() is tuple object,
it is not "None" if the deleting success, so the batch operation would
be broken when the first key is deleted successfully. The patch fix this
issue.

Change-Id: I60378a32cdc52aacdf869d69b246dec7eb6cdb77
Closes-Bug: #1596511

Fix Service.repr to remove the undefined attribute

2016-06-25T15:45:38+00:00

The self.name is undefined in the Service class.
And also there is no need any unique information to
identify this object, so we just remove it directly.

Change-Id: I3ce8663f830357855f2155e080393ea97f8f80ba
Partial-Bug: #1585024

Merge "Fix argument order for assertEqual to (expected, observed)"

2016-06-14T15:39:48+00:00

Fix argument order for assertEqual to (expected, observed)

2016-06-14T08:27:32+00:00

assertEqual expects that the arguments provided to it should be
(expected, observed). If a particluar order is kept as a convention,
then it helps to provide a cleaner message to the developer if Unit
Tests fail. The following patch fixes this issue.

TrivialFix

Change-Id: I817a654733e0f3886ca85778a49aa579592f60ff
Closes-Bug: #1259292

Make repr print encryption_id for VolumeEncryptionType class

2016-05-27T11:24:52+00:00

The self.name attribute is undefined in the VolumeEncryptionType
class. Instead we should print the self.encryption_id attribute
in the __repr__().

Change-Id: Ic11b45069145bbae078c8175928c5dd869bd8cb8
Partial-Bug: #1585024

Support api-microversions

2016-04-19T17:19:45+00:00

Changes to cinderclient to use microversions.

Implements: blueprint api-microversion-support-for-cinderclient
api-microversion-support-for-cinderclient

Change-Id: I840a1162b88e8ff36fa3fc4e1d6b9317104df3e0