<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-cinderclient.git/cinderclient/tests/v1/test_services.py, branch kilo-eol</title>
<subtitle>opendev.org: openstack/python-cinderclient.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/'/>
<entry>
<title>Fix order of arguments in assertEqual</title>
<updated>2014-08-18T04:41:21+00:00</updated>
<author>
<name>KIYOHIRO ADACHI</name>
<email>adachi@mxs.nes.nec.co.jp</email>
</author>
<published>2014-02-26T06:59:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=f3ec0814971112068e933e343ef7ab8986f438c3'/>
<id>f3ec0814971112068e933e343ef7ab8986f438c3</id>
<content type='text'>
Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is...

    def assertEqual(self, expected, observed, message=''):
        """Assert that 'expected' is equal to 'observed'.

        :param expected: The expected value.
        :param observed: The observed value.
        :param message: An optional message to include in the error.
        """

The string length of the sum of the results of repr(expected) and
repr(observed) is greater than 70, then, MismatchError message is
changed, as below.

  Ex.:
        raise mismatch_error
    MismatchError: !=:
    reference = '_123456789_123456789_bar'
    actual    = '_123456789_123456789_123456789_123456789_123456789'

Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
Closes-Bug: #1259292
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is...

    def assertEqual(self, expected, observed, message=''):
        """Assert that 'expected' is equal to 'observed'.

        :param expected: The expected value.
        :param observed: The observed value.
        :param message: An optional message to include in the error.
        """

The string length of the sum of the results of repr(expected) and
repr(observed) is greater than 70, then, MismatchError message is
changed, as below.

  Ex.:
        raise mismatch_error
    MismatchError: !=:
    reference = '_123456789_123456789_bar'
    actual    = '_123456789_123456789_123456789_123456789_123456789'

Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
Closes-Bug: #1259292
</pre>
</div>
</content>
</entry>
<entry>
<title>Use suitable assert</title>
<updated>2014-07-08T16:07:48+00:00</updated>
<author>
<name>liuqing</name>
<email>jing.liuqing@99cloud.net</email>
</author>
<published>2014-07-08T16:07:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=32373cc5fb3218dbb1419186f195e5c55f780284'/>
<id>32373cc5fb3218dbb1419186f195e5c55f780284</id>
<content type='text'>
Replace assertTrue(a in b) with assertIn(a, b)
Replace assertTrue(a in [b, c]) with assertIn(a, [b, c])
Replace assertTrue(a is None) with assertIsNone(a)
Replace assertTrue(a == b) with assertEqual(a, b)
Replace assertFalse(a == b) with assertNotEqual(a, b)

Change-Id: I10c3abce14953b97568a5ce9d45f63af22d71ac3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace assertTrue(a in b) with assertIn(a, b)
Replace assertTrue(a in [b, c]) with assertIn(a, [b, c])
Replace assertTrue(a is None) with assertIsNone(a)
Replace assertTrue(a == b) with assertEqual(a, b)
Replace assertFalse(a == b) with assertNotEqual(a, b)

Change-Id: I10c3abce14953b97568a5ce9d45f63af22d71ac3
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "CLI for disable service reason"</title>
<updated>2014-04-04T07:16:50+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2014-04-04T07:16:50+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=fc2c916ce47afbe01bc3ec4222525bf17a8840ae'/>
<id>fc2c916ce47afbe01bc3ec4222525bf17a8840ae</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CLI for disable service reason</title>
<updated>2014-03-16T01:34:09+00:00</updated>
<author>
<name>Jay Lau</name>
<email>liugya@cn.ibm.com</email>
</author>
<published>2014-03-16T01:32:52+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=8a59f2ca572ff9aebe4f62e2d750f6a6c551598a'/>
<id>8a59f2ca572ff9aebe4f62e2d750f6a6c551598a</id>
<content type='text'>
Adds cli option to allow users to give reason
for service-disable. Also adds disabled reason
as a column in service list, so any disabled service
can be seen with reason.

A recent cinder change that allows disable-log-reason
allows users to provide reason for disabling service.
This just adds the cli option for the method.

Implements bp record-reason-for-disabling-service

Change-Id: I90f4566764790eeb0c047c4a0fd0108050ab6ad9
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds cli option to allow users to give reason
for service-disable. Also adds disabled reason
as a column in service list, so any disabled service
can be seen with reason.

A recent cinder change that allows disable-log-reason
allows users to provide reason for disabling service.
This just adds the cli option for the method.

Implements bp record-reason-for-disabling-service

Change-Id: I90f4566764790eeb0c047c4a0fd0108050ab6ad9
</pre>
</div>
</content>
</entry>
<entry>
<title>replace assertTrue(isinstance) to assertIsInstance</title>
<updated>2014-03-05T10:43:46+00:00</updated>
<author>
<name>ls1175</name>
<email>liusheng@huawei.com</email>
</author>
<published>2014-01-18T07:16:24+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=0ff5d1cdc615a17c3faf4e728f0bce2f5baf5209'/>
<id>0ff5d1cdc615a17c3faf4e728f0bce2f5baf5209</id>
<content type='text'>
some of tests use different method of assertTrue(isinstance(A, B))
or assertEqual(type(A), B). The correct way is to use
assertIsInstance(A, B) provided by testtools

Change-Id: Ic3eb7b27dc96b0ec7d786c092fc3a6a513af64f7
Closes-bug: #1268480
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
some of tests use different method of assertTrue(isinstance(A, B))
or assertEqual(type(A), B). The correct way is to use
assertIsInstance(A, B) provided by testtools

Change-Id: Ic3eb7b27dc96b0ec7d786c092fc3a6a513af64f7
Closes-bug: #1268480
</pre>
</div>
</content>
</entry>
<entry>
<title>disable/enable a service has no output</title>
<updated>2014-01-21T14:57:23+00:00</updated>
<author>
<name>Jay Lau</name>
<email>liugya@cn.ibm.com</email>
</author>
<published>2014-01-21T14:55:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=c2ef5eaf494401cb2e6a77c516d77fbe06bc6f08'/>
<id>c2ef5eaf494401cb2e6a77c516d77fbe06bc6f08</id>
<content type='text'>
When disable/enable a cinder service, there is no output, this
caused end user does not know if the service was disabled/enabled
successfully.

It is better add some output for the command just like nova to tell
end user the service status.

Change-Id: I9d440ab7437c268b17627e255f152db0b3bf4f53
Closes-Bug: #1261120
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When disable/enable a cinder service, there is no output, this
caused end user does not know if the service was disabled/enabled
successfully.

It is better add some output for the command just like nova to tell
end user the service status.

Change-Id: I9d440ab7437c268b17627e255f152db0b3bf4f53
Closes-Bug: #1261120
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace OpenStack LLC with OpenStack Foundation</title>
<updated>2013-09-28T15:13:54+00:00</updated>
<author>
<name>ZhiQiang Fan</name>
<email>aji.zqfan@gmail.com</email>
</author>
<published>2013-09-19T19:31:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=5ad95e9fd236a1f27cbcf1105494d6680a7d8ffe'/>
<id>5ad95e9fd236a1f27cbcf1105494d6680a7d8ffe</id>
<content type='text'>
NOTE:
* openstack/common/* should be synced from oslo, so i leave them
untouched.
* add (c) symbol for related lines, leave others untouched.

Change-Id: I46a87c7f248d3468b1fdf5661411962faf2fb875
Fixes-Bug: #1214176
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
NOTE:
* openstack/common/* should be synced from oslo, so i leave them
untouched.
* add (c) symbol for related lines, leave others untouched.

Change-Id: I46a87c7f248d3468b1fdf5661411962faf2fb875
Fixes-Bug: #1214176
</pre>
</div>
</content>
</entry>
<entry>
<title>Add os-services extension support</title>
<updated>2013-07-14T15:18:22+00:00</updated>
<author>
<name>Qiu Yu</name>
<email>unicell@gmail.com</email>
</author>
<published>2013-07-14T15:18:22+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-cinderclient.git/commit/?id=627b616227badd893ff2d8d7addf162d605b2299'/>
<id>627b616227badd893ff2d8d7addf162d605b2299</id>
<content type='text'>
Implement client bindings for Cinder os-services API extension, so
client would be able to list services, enable or disable particular
services.

Usage:
cinder service-list [--host &lt;hostname&gt;] [--binary &lt;binary&gt;]
cinder service-enable &lt;hostname&gt; &lt;binary&gt;
cinder service-disable &lt;hostname&gt; &lt;binary&gt;

This change is depended on following change at Cinder side
I7f3fa889294ca6caebdf46b8689345bcac1cdf54

Implements blueprint os-services-extension

Change-Id: I4a53fd545ed3b446441302d00a429168a996a34a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implement client bindings for Cinder os-services API extension, so
client would be able to list services, enable or disable particular
services.

Usage:
cinder service-list [--host &lt;hostname&gt;] [--binary &lt;binary&gt;]
cinder service-enable &lt;hostname&gt; &lt;binary&gt;
cinder service-disable &lt;hostname&gt; &lt;binary&gt;

This change is depended on following change at Cinder side
I7f3fa889294ca6caebdf46b8689345bcac1cdf54

Implements blueprint os-services-extension

Change-Id: I4a53fd545ed3b446441302d00a429168a996a34a
</pre>
</div>
</content>
</entry>
</feed>
