delta/openstack/python-cinderclient.git/cinderclient/tests/v2/test_limits.py, branch kilo-eol opendev.org: openstack/python-cinderclient.git Fix order of arguments in assertEqual 2014-08-18T04:41:21+00:00 KIYOHIRO ADACHI adachi@mxs.nes.nec.co.jp 2014-02-26T06:59:14+00:00 f3ec0814971112068e933e343ef7ab8986f438c3 Some tests used incorrect order assertEqual(observed, expected). The correct order expected by testtools is... def assertEqual(self, expected, observed, message=''): """Assert that 'expected' is equal to 'observed'. :param expected: The expected value. :param observed: The observed value. :param message: An optional message to include in the error. """ The string length of the sum of the results of repr(expected) and repr(observed) is greater than 70, then, MismatchError message is changed, as below. Ex.: raise mismatch_error MismatchError: !=: reference = '_123456789_123456789_bar' actual = '_123456789_123456789_123456789_123456789_123456789' Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924 Closes-Bug: #1259292 
Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is...

    def assertEqual(self, expected, observed, message=''):
        """Assert that 'expected' is equal to 'observed'.

        :param expected: The expected value.
        :param observed: The observed value.
        :param message: An optional message to include in the error.
        """

The string length of the sum of the results of repr(expected) and
repr(observed) is greater than 70, then, MismatchError message is
changed, as below.

  Ex.:
        raise mismatch_error
    MismatchError: !=:
    reference = '_123456789_123456789_bar'
    actual    = '_123456789_123456789_123456789_123456789_123456789'

Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
Closes-Bug: #1259292
Use suitable assert 2014-07-08T16:07:48+00:00 liuqing jing.liuqing@99cloud.net 2014-07-08T16:07:48+00:00 32373cc5fb3218dbb1419186f195e5c55f780284 Replace assertTrue(a in b) with assertIn(a, b) Replace assertTrue(a in [b, c]) with assertIn(a, [b, c]) Replace assertTrue(a is None) with assertIsNone(a) Replace assertTrue(a == b) with assertEqual(a, b) Replace assertFalse(a == b) with assertNotEqual(a, b) Change-Id: I10c3abce14953b97568a5ce9d45f63af22d71ac3 
Replace assertTrue(a in b) with assertIn(a, b)
Replace assertTrue(a in [b, c]) with assertIn(a, [b, c])
Replace assertTrue(a is None) with assertIsNone(a)
Replace assertTrue(a == b) with assertEqual(a, b)
Replace assertFalse(a == b) with assertNotEqual(a, b)

Change-Id: I10c3abce14953b97568a5ce9d45f63af22d71ac3
Unit tests for limits.py in cinderclient/v1 and v2 2014-01-13T12:17:16+00:00 Igor A. Lukyanenkov ilukyanenkov@griddynamics.com 2013-12-03T13:50:19+00:00 efc080dfcaae6ce0381e3e1a94f9efca350eac8a Change-Id: I962161ac657d9ec676f3b03ab17138ed1911ec35 
Change-Id: I962161ac657d9ec676f3b03ab17138ed1911ec35
Fix RateLimit.__repr__ - self.method is undefined 2013-12-31T14:00:24+00:00 Igor A. Lukyanenkov ilukyanenkov@griddynamics.com 2013-12-03T11:47:58+00:00 1fc1b4bea1f813ec54fc448aad3794ca78507a11 Using self.verb instead of self.method, unit tests added to cover this fix. Closes-bug: #1258489 Change-Id: I4a84179ff96c50b230afcaea7a19fb54613577fb 
Using self.verb instead of self.method, unit tests added to cover this fix.

Closes-bug: #1258489

Change-Id: I4a84179ff96c50b230afcaea7a19fb54613577fb