'server_id' is not Attachment attribute, should be
set by 'instance' attribute.

v3/attachments respond body:

{"attachments":
   [{"status": "attached",
     "instance": INSTANCE_UUID,
     "id": ATTACHMENT_UUID,
     "volume_id": VOLUME_UUID,
    },
    ...
    ]
}

Closes-Bug: #1860393
Change-Id: Ica5d278cb7455befe1db4be0ab65114fd606ea0a
(cherry picked from commit 03f228c11e0d88dcc396b30b7544b5cfde894750)

Mock out writing of bash-completion cache files
during unit tests.

Related-Bug: #1817782

Change-Id: I944862c30fb4684dd034eba6953e9302d2d22439
(cherry picked from commit a39805c6f45baf94c0d14da3ae775ee204a267ee)

Upload-to-image would error after launching
the operation if the volume type is None.

Closes-Bug: #1821818
Change-Id: I015e0ddfa98d62f25334e2df5effaee72a3988ab
(cherry picked from commit 274fa111696783e846561d12f670967ed01ebcbc)

Commit fefe331f218d73ba6d1d7acf81b5eb02609c953e incorrectly set the
default API version to the max the client knew about in order to get the
full help output, including all microversioned commands.

The original intent was to have help print out information for all
versions, but still require the user to specify a version if they wanted
to use any microversioned version of an API. The code accidentally made
it so all commands would request the max version the client knew about.
This meant an unspecified request would get the newer functionality
rather than the default v3 functionality, and also meant the client
could request a microversion higher than what the server knew about,
resulting in an unexpected error being returned.

To keep the originally intended functionality, but keep all help output,
this only uses the max API version for the help command unless the user
specifies otherwise.

Closes-bug: #1813967

Change-Id: I20f6c5471ffefe5524a4d48c967e2e8db53233f1
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
(cherry picked from commit bccbd510a77843824b8187e15c4d8df9c2dfa55e)

The all_tenants filter is passed to API when it's value is 0
(when not specified) which shouldn't be the case.
This patch only allows adding of all_tenants when specified
manually by user.

Change-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0
Closes-Bug: #1808621
Closes-Bug: #1808622
(cherry picked from commit 532aef0c738edc937dbfa1b54efd8d7773af2204)

This replaces the deprecated (in python 3.2) unittest.TestCase method
assertRaisesRegexp() with assertRaisesRegex().

Change-Id: I85025ad141f8436913ba192716435ce63e1e2d05
(cherry picked from commit 3362a65085b562632ce15c25ad29f0fda2a67784)