delta/openstack/python-keystoneclient.git/keystoneclient/common/cms.py, branch stable/pike opendev.org: openstack/python-keystoneclient.git Make tests pass in 2020 2020-01-14T01:27:27+00:00 Bernhard M. Wiedemann bwiedemann@suse.de 2019-02-28T13:06:22+00:00 bcc00a10a6a5e42f261ad88feaec8019d68f25f8 Without this patch, build failed after 2019-12-31 with Traceback (most recent call last): File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY) File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs self.assertEqual(json, val) NOTE: in addition to the orginal backport, this patch adds the following changes. The changes has to be combined into a single patch in order to avoid circular dependencies. 1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256' is the default hash algorithm, not a sensitive password. Marking it as false positive so bandit can stop chirping. 2. combined with cherry pick from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without combining them, neither backport will pass all the gates since pep8 has switched over to use python3 now. 3. combined with cherry pick from commit b29f478f28c4989156cfe87392cbd308e3f55c1e to avoid circular dependency. Without combining them, neither backport will pass all the gates since bandit will have a false positive on the hash algorithm. Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77 (cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b) (cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054) (cherry picked from commit b29f478f28c4989156cfe87392cbd308e3f55c1e) (cherry picked from commit 9da2e0bdd83d481091814a8c6f40ab3ff39ffa9c) 
Without this patch, build failed after 2019-12-31 with
Traceback (most recent call last):
  File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped
    self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY)
  File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs
    self.assertEqual(json, val)

NOTE: in addition to the orginal backport, this patch adds the following
changes. The changes has to be combined into a single patch in order to
avoid circular dependencies.

1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256'
is the default hash algorithm, not a sensitive password. Marking it as false
positive so bandit can stop chirping.

2. combined with cherry pick from commit
f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without
combining them, neither backport will pass all the gates since pep8 has
switched over to use python3 now.

3. combined with cherry pick from commit
b29f478f28c4989156cfe87392cbd308e3f55c1e to avoid circular dependency. Without
combining them, neither backport will pass all the gates since bandit will
have a false positive on the hash algorithm.

Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77
(cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b)
(cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054)
(cherry picked from commit b29f478f28c4989156cfe87392cbd308e3f55c1e)
(cherry picked from commit 9da2e0bdd83d481091814a8c6f40ab3ff39ffa9c)
Remove log translations in python-keystoneclient 2017-03-21T06:38:05+00:00 wingwj wingwj@gmail.com 2017-03-21T04:55:27+00:00 1d5774f4983e915f45787e7afd2d290f65cf428c Log messages are no longer being translated. This removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions. See: http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html Change-Id: Ia77819cbb133903d20e821bff0c45766b11ef07b 
Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

Change-Id: Ia77819cbb133903d20e821bff0c45766b11ef07b
Fix Failing tests with openssl >= 1.1.0 2016-12-04T05:03:57+00:00 Ondřej Kobližek koblizeko@gmail.com 2016-12-02T15:26:05+00:00 7917e03652dbd100aa38808157d64f7607ecc0a6 keystoneclient.tests.unit.test_cms.CMSTest.test_cms_verify keystoneclient.tests.unit.test_cms.CMSTest.test_cms_verify_token_no_files failing with: Command 'openssl' returned non-zero exit status 1 I think its OpenSSL >= 1.1 bug, which returns wrong exit code (1 instead of 2) if input file not exists. Change-Id: I776596487f305c759b88c0d4c604571c33c6ef70 Closes-Bug: #1646858 
keystoneclient.tests.unit.test_cms.CMSTest.test_cms_verify
keystoneclient.tests.unit.test_cms.CMSTest.test_cms_verify_token_no_files

failing with: Command 'openssl' returned non-zero exit status 1

I think its OpenSSL >= 1.1 bug, which returns wrong exit code (1 instead of
2) if input file not exists.

Change-Id: I776596487f305c759b88c0d4c604571c33c6ef70
Closes-Bug: #1646858
Fixing D202 and D203 PEP257 violation. 2016-05-04T19:45:30+00:00 Navid Pustchi npustchi@gmail.com 2016-05-03T18:54:12+00:00 bca112c8ba5636becd6951fbfb8cb8f2474279fe Currently tox ignores D202 and D203. D202: No blank lines allowed after function docstring. D203: 1 blank required before class docstring. This change removes D202 and D203 ignores in tox and fix violations. Change-Id: I97ef88c9cfd56774e47f789cbbcf8ccfe85d7737 
Currently tox ignores D202 and D203.
D202: No blank lines allowed after function docstring.
D203: 1 blank required before class docstring.
This change removes D202 and D203 ignores in tox and fix violations.

Change-Id: I97ef88c9cfd56774e47f789cbbcf8ccfe85d7737
Fix D400 PEP257 violation. 2016-04-23T17:47:25+00:00 Navid Pustchi npustchi@gmail.com 2016-04-23T06:48:46+00:00 20e23f3e0dfb8853d39eedacd19f8c4f8a434fca Currently tox ignores D400. D400: First line should end with a period. This change removes it and make keystoneclient docstrings compliant with it. Change-Id: I29ecb4c58bb03c0b9a3be0b7a74d18fb06a350f2 
Currently tox ignores D400.
D400: First line should end with a period.
This change removes it and make keystoneclient docstrings compliant with it.

Change-Id: I29ecb4c58bb03c0b9a3be0b7a74d18fb06a350f2
Fix D401 PEP257 violation. 2016-04-23T06:25:20+00:00 Navid Pustchi npustchi@gmail.com 2016-04-23T03:19:58+00:00 946e928b5285a4994c4ef365b43295bdd90c9961 Currently tox ignores D401. 401: First line should be in imperative mood. This change removes it and make keystoneclient docstrings compliant with it. Change-Id: If34ff12d18390b357342cf29f2d116dd3c86a44d 
Currently tox ignores D401.
401: First line should be in imperative mood.
This change removes it and make keystoneclient docstrings compliant with it.

Change-Id: If34ff12d18390b357342cf29f2d116dd3c86a44d
Removing bandit.yaml in favor of defaults 2016-04-19T15:35:00+00:00 Christopher J Schaefer cjschaef@us.ibm.com 2016-03-11T21:55:06+00:00 dbf4f3164655ec69a830ed87db0769f01ac1f720 Removing old configuration options for build-in defaults of latest bandit functionality. Also, marking flagged items with _# nosec_ with a descriptive comment on why the code is acceptable as is. Co-Authored-By: Christopher J Schaefer <cjschaef@us.ibm.com> Co-Authored-By: Tom Cocozzello <tjcocozz@us.ibm.com> Change-Id: I138ebd46a8be195177361a9c3306bb70423b639d 
Removing old configuration options for build-in defaults of latest
bandit functionality. Also, marking flagged items with _# nosec_
with a descriptive comment on why the code is acceptable as is.

Co-Authored-By: Christopher J Schaefer <cjschaef@us.ibm.com>
Co-Authored-By: Tom Cocozzello <tjcocozz@us.ibm.com>

Change-Id: I138ebd46a8be195177361a9c3306bb70423b639d
Address hacking check H405 2016-01-13T21:03:51+00:00 lin-hua-cheng os.lcheng@gmail.com 2016-01-13T21:03:51+00:00 77ed0d4d0c3413b15aa348613b8b40373bd5765b Previously, there were a string of commits to keystone that addresed ignored hacking checks. This commit does the same for H405 in keystoneclient. This also modifies our tox.ini so that we no longer ignore H405 violations. Change-Id: I2af152e5425a0e9c82314039fdbb90d661c22680 Closes-Bug: 1482773 
Previously, there were a string of commits to keystone that addresed ignored
hacking checks. This commit does the same for H405 in keystoneclient. This
also modifies our tox.ini so that we no longer ignore H405 violations.

Change-Id: I2af152e5425a0e9c82314039fdbb90d661c22680
Closes-Bug: 1482773
Replace textwrap with fast standard code 2015-12-16T09:47:39+00:00 Bernhard M. Wiedemann bwiedemann@suse.de 2015-12-02T11:47:33+00:00 fde0bf77d6a89ee84e62461bc0d4c2cdfd809c48 This improves on commit 4350c176048b8d159d08b82b915e9544ac9dee6f We found a major performance regression in keystoneclient when using PKI tokens, related to http://bugs.python.org/issue25870 It can be tested with time python -c "import textwrap; textwrap.wrap('x'*9000, 64)" which has a complexity of O(n*n) because it uses certain regexps in python versions before 3.5. Closes-Bug: #1526686 Related-Bug: #1404402 Change-Id: Ibc81907c4d9db2c09fff41ccf21345fbdb19202d 
This improves on commit 4350c176048b8d159d08b82b915e9544ac9dee6f

We found a major performance regression in keystoneclient
when using PKI tokens, related to http://bugs.python.org/issue25870

It can be tested with
time python -c "import textwrap; textwrap.wrap('x'*9000, 64)"

which has a complexity of O(n*n)
because it uses certain regexps in python versions before 3.5.

Closes-Bug: #1526686
Related-Bug: #1404402

Change-Id: Ibc81907c4d9db2c09fff41ccf21345fbdb19202d
Removes py26 support 2015-11-25T00:23:17+00:00 David Stanek dstanek@dstanek.com 2015-11-25T00:23:17+00:00 f4e6f12a714080a1e0391d4891d3bcf0eecfbaaf We are removing Python 2.6 support from the Keystone libraries. Change-Id: I1c7a79edd41a73946c9d77bfb8cd2075e2500760 Closes-Bug: 1519449 
We are removing Python 2.6 support from the Keystone libraries.

Change-Id: I1c7a79edd41a73946c9d77bfb8cd2075e2500760
Closes-Bug: 1519449