delta/openstack/python-keystoneclient.git/keystoneclient/session.py, branch stein-em

Adds bandit nosec flag to hashlib.sha1

2017-08-31T20:34:13+00:00

A bandit patch to block sha1 hash is failing CI [1], due to a false
positive on hashlib.sha1 (which actually uses HMAC-SHA1 in keystone
that is considered more secure then standard SHA1)

This change marks a # nosec comment against the line which is
triggering the false positive in Bandit.

[1] https://review.openstack.org/#/c/437563/6

Change-Id: Ib9618119c77f41fba0e612e37c7511676bed47e8

Remove use of positional decorator

2017-08-07T20:14:55+00:00

The positional decorator results in poorly maintainable code in
a misguided effort to emulate python3's key-word-arg only notation
and functionality. This patch removes keystoneclient's dependance
on the positional decorator.

Change-Id: I9e691cc8b0c04992f4a8dabd67e1b413d3220d23

Merge "Replace six.iteritems() with .items()"

2017-06-13T16:45:01+00:00

Merge "Remove log translations in python-keystoneclient"

2017-05-16T04:11:03+00:00

Replace six.iteritems() with .items()

2017-04-03T12:50:52+00:00

1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a

Remove log translations in python-keystoneclient

2017-03-21T06:38:05+00:00

Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

Change-Id: Ia77819cbb133903d20e821bff0c45766b11ef07b

Fix response body being omitted in debug mode incorrectly

2017-01-17T13:05:52+00:00

In debug mode, when a response's header Content-Type is set
to "application/json" with a parameter, i.e.,
"application/json; charset=UTF-8".  This patch set ignores
the additional parameter and only match the mimetype.

Change-Id: Ie8fcb1061e0e49b039436947524cfdc704c83846
Closes-Bug: #1656981

Only log application/json in session to start

2017-01-11T03:35:14+00:00

When whitelisting content types to debug print from session we chose
application/json and application/text. application/text is not a real
mime type, text is typically text/plain.

Rather than guess at mime types only print application/json to start
with, but make it easy for additional types to be added later.

Adapted from keystoneauth: Ica5fee076cdab8b1d5167161d28af7313fad9477
Related-Bug: 1616105

Change-Id: Ieaa8fb3ea8d25e09b89498f23b70b18c0f6153f1

X-Serivce-Token should be hashed in the log

2017-01-09T16:31:35+00:00

Currently, logs display the hash values of X-Auth-Token,
Authorization, and X-Subject-Token, but not the value of
the X-Service-Token.  This patch set adds the X-Service-Token
to the list of header fields to be hashed for logging purposes.

Change-Id: Iaa3a27f4b6c3baf964fa0c71328ffe9df43b2c0a
Closes-Bug: #1654847

Merge "Do not log binary data during request"

2017-01-08T04:45:57+00:00