delta/openstack/python-keystoneclient.git/keystoneclient/tests/unit/auth, branch stable/queens opendev.org: openstack/python-keystoneclient.git Make tests pass in 2020 2020-01-09T22:46:48+00:00 Bernhard M. Wiedemann bwiedemann@suse.de 2019-02-28T13:06:22+00:00 9da2e0bdd83d481091814a8c6f40ab3ff39ffa9c Without this patch, build failed after 2019-12-31 with Traceback (most recent call last): File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY) File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs self.assertEqual(json, val) NOTE: in addition to the orginal backport, this patch adds the following changes. The changes has to be combined into a single patch in order to avoid circular dependencies. 1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256' is the default hash algorithm, not a sensitive password. Marking it as false positive so bandit can stop chirping. 2. combined with cherry pick from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without combining them, neither backport will pass all the gates since pep8 has switched over to use python3 now. Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77 (cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b) (cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054) 
Without this patch, build failed after 2019-12-31 with
Traceback (most recent call last):
  File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped
    self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY)
  File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs
    self.assertEqual(json, val)

NOTE: in addition to the orginal backport, this patch adds the following
changes. The changes has to be combined into a single patch in order to
avoid circular dependencies.

1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256'
is the default hash algorithm, not a sensitive password. Marking it as false
positive so bandit can stop chirping.

2. combined with cherry pick from commit
f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without
combining them, neither backport will pass all the gates since pep8 has
switched over to use python3 now.

Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77
(cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b)
(cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054)
Replace six.iteritems() with .items() 2017-04-03T12:50:52+00:00 M V P Nitesh m.nitesh@nectechnologies.in 2017-04-03T12:50:15+00:00 46b9e429a2cbfcd1d898616c177538a9283997d3 1.As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2.In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a 
1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a
Use AUTH_INTERFACE object from keystoneauth 2016-08-24T08:52:36+00:00 Jamie Lennox jamielennox@gmail.com 2016-08-24T07:37:07+00:00 f557170404ec2b7f5c562e55ad212b6e444655c8 As keystoneclient and other services rely more on keystoneauth we should assume that keystoneauth is our base auth library, not keystoneclient and start to default to the objects provided from there. This will make it easier to remove these objects when the time comes. Use the AUTH_INTERFACE special object from keystoneauth in most places. This uses it everywhere that is actually session independant. For example it is not changed within the keystoneclient auth plugins themselves as they are directly compatible with keystoneauth. Change-Id: Ibc1224fca98c852106feb78c624b0b2f22b3a19d 
As keystoneclient and other services rely more on keystoneauth we should
assume that keystoneauth is our base auth library, not keystoneclient
and start to default to the objects provided from there. This will make
it easier to remove these objects when the time comes.

Use the AUTH_INTERFACE special object from keystoneauth in most places.
This uses it everywhere that is actually session independant. For
example it is not changed within the keystoneclient auth plugins
themselves as they are directly compatible with keystoneauth.

Change-Id: Ibc1224fca98c852106feb78c624b0b2f22b3a19d
Use fixtures from keystoneauth 2016-08-24T08:52:27+00:00 Jamie Lennox jamielennox@gmail.com 2016-08-24T07:18:13+00:00 4b8158f9b499646aa80dadf8594a9efa4ef57b14 As keystoneclient and other services rely more on keystoneauth we should assume that keystoneauth is our base auth library, not keystoneclient and start to default to the objects provided from there. This will make it easier to remove these objects when the time comes. The easiest thing to move is the keystoneclient fixtures in favor of the keystoneauth fixtures. Change-Id: I5a784795536cec6c7ca5eead3f13b1e7a6e45346 
As keystoneclient and other services rely more on keystoneauth we should
assume that keystoneauth is our base auth library, not keystoneclient
and start to default to the objects provided from there. This will make
it easier to remove these objects when the time comes.

The easiest thing to move is the keystoneclient fixtures in favor of the
keystoneauth fixtures.

Change-Id: I5a784795536cec6c7ca5eead3f13b1e7a6e45346
Fixing D105 PEP257 2016-05-04T19:47:14+00:00 Navid Pustchi npustchi@gmail.com 2016-05-04T19:14:01+00:00 01500be7fb8d4fdf6d072a1eacf4df87abe86c8c Currently tox ignores D105. D105: Missing docstring in magic method. This change removes it and make keystoneclient docstring compliant with it. Change-Id: I34dfc164891880425f542f8f8aa3426ec8640c96 
Currently tox ignores D105.
D105: Missing docstring in magic method.
This change removes it and make keystoneclient docstring compliant with it.

Change-Id: I34dfc164891880425f542f8f8aa3426ec8640c96
Deprecate auth plugins from keystoneclient 2016-02-03T01:08:07+00:00 Jamie Lennox jamielennox@gmail.com 2015-12-16T07:14:33+00:00 03e209fd6fd8519aedfdd1bf3d36e5adaf14c7ce Deprecate auth plugins in favour of those from keystoneauth. Change-Id: I8963ded9b68569717d7a6e30623ee78301b59a4a Implements: bp deprecate-to-ksa 
Deprecate auth plugins in favour of those from keystoneauth.

Change-Id: I8963ded9b68569717d7a6e30623ee78301b59a4a
Implements: bp deprecate-to-ksa
Deprecate Session 2016-02-03T01:06:07+00:00 Jamie Lennox jamielennox@gmail.com 2015-12-16T06:41:18+00:00 c1c2043da966ad8fb61f93739b11da609ee52d43 Deprecate the keystoneclient Session object in favour of keystoneauth's Session. Change-Id: I26e000d626a466f63d10d2a961adc698f8de0636 Implements: bp deprecate-to-ksa 
Deprecate the keystoneclient Session object in favour of keystoneauth's
Session.

Change-Id: I26e000d626a466f63d10d2a961adc698f8de0636
Implements: bp deprecate-to-ksa
Replace TestResponse with requests_mock 2016-01-24T22:56:34+00:00 Jamie Lennox jamielennox@gmail.com 2015-12-17T00:41:36+00:00 59ba76535cb3c2f945a9440ae6efc50470cc08e1 The TestResponse object doesn't do the right thing with regards to content vs text. Just reuse the one from requests_mock rather that try and fix it. Change-Id: Ia8bcae126babb0e616329928c57f875a50a957d6 
The TestResponse object doesn't do the right thing with regards to
content vs text. Just reuse the one from requests_mock rather that try
and fix it.

Change-Id: Ia8bcae126babb0e616329928c57f875a50a957d6
Swap the order of username deprecation 2015-11-19T15:48:28+00:00 Monty Taylor mordred@inaugust.com 2015-11-19T15:22:31+00:00 13bb2f74b0d65c1fef30f77d710d56e51e5f7841 The attempt at a move to user-name is an exercise in churn, and is filling everyone's logs with admonitions to change the name of their variables - which does not work if they do. Swap this, effectively reverting the attempt at a move. user-name will continue to work on the off chance anyone started consuming that path, which is unlikely because none of the consuming programs expose that as an actual option. Closes-Bug: 1498247 Change-Id: I62d991fda1df63c9cbabfde2f6836bc031f5147c 
The attempt at a move to user-name is an exercise in churn, and is
filling everyone's logs with admonitions to change the name of their
variables - which does not work if they do. Swap this, effectively
reverting the attempt at a move. user-name will continue to work on
the off chance anyone started consuming that path, which is unlikely
because none of the consuming programs expose that as an actual option.

Closes-Bug: 1498247

Change-Id: I62d991fda1df63c9cbabfde2f6836bc031f5147c
Pull the endpoint from the Session 2015-11-09T00:10:58+00:00 Monty Taylor mordred@inaugust.com 2015-11-06T14:09:08+00:00 d9031c252848d89270a543b67109a46f9c505c86 If the user passes a Session in, we can pull the endpoint to use for discovery from the Session itself, rather than erroring. Closes-Bug: #1513839 Co-Authored-By: Dolph Mathews <dolph.mathews@gmail.com> Change-Id: I82a41c67f80d2494f04739d82b112b7ff1dc4682 
If the user passes a Session in, we can pull the endpoint to use for
discovery from the Session itself, rather than erroring.

Closes-Bug: #1513839
Co-Authored-By: Dolph Mathews <dolph.mathews@gmail.com>
Change-Id: I82a41c67f80d2494f04739d82b112b7ff1dc4682