delta/openstack/python-keystoneclient.git/keystoneclient/tests/unit/client_fixtures.py, branch pike-eol

Make tests pass in 2020

2020-01-14T01:27:27+00:00

Without this patch, build failed after 2019-12-31 with
Traceback (most recent call last):
File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped
self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY)
File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs
self.assertEqual(json, val)

NOTE: in addition to the orginal backport, this patch adds the following
changes. The changes has to be combined into a single patch in order to
avoid circular dependencies.

1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256'
is the default hash algorithm, not a sensitive password. Marking it as false
positive so bandit can stop chirping.

2. combined with cherry pick from commit
f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without
combining them, neither backport will pass all the gates since pep8 has
switched over to use python3 now.

3. combined with cherry pick from commit
b29f478f28c4989156cfe87392cbd308e3f55c1e to avoid circular dependency. Without
combining them, neither backport will pass all the gates since bandit will
have a false positive on the hash algorithm.

Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77
(cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b)
(cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054)
(cherry picked from commit b29f478f28c4989156cfe87392cbd308e3f55c1e)
(cherry picked from commit 9da2e0bdd83d481091814a8c6f40ab3ff39ffa9c)

Replace six.iteritems() with .items()

2017-04-03T12:50:52+00:00

1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a

remove hacking checks from keystoneclient

2017-01-06T16:56:18+00:00

the only hacking check in keystoneclient is related to
older versions of oslo libraries, which are no longer
supported by keystoneclient, for example:

$ pip freeze | grep oslo.utils
oslo.utils==3.18.0
$ python
>>> import oslo.utils
Traceback (most recent call last):
  File "", line 1, in 
ImportError: No module named oslo.utils
>>> import oslo_utils
>>>

Let's just remove the hacking check since theres no
way someone could incorrectly import the older
versions.

Closes-Bug: 1652458

Signed-off-by: Adam Williamson 

Change-Id: I14165903b46d2fc26e8c9de591917893f58516db

Use fixtures from keystoneauth

2016-08-24T08:52:27+00:00

As keystoneclient and other services rely more on keystoneauth we should
assume that keystoneauth is our base auth library, not keystoneclient
and start to default to the objects provided from there. This will make
it easier to remove these objects when the time comes.

The easiest thing to move is the keystoneclient fixtures in favor of the
keystoneauth fixtures.

Change-Id: I5a784795536cec6c7ca5eead3f13b1e7a6e45346

Deprecate auth plugins from keystoneclient

2016-02-03T01:08:07+00:00

Deprecate auth plugins in favour of those from keystoneauth.

Change-Id: I8963ded9b68569717d7a6e30623ee78301b59a4a
Implements: bp deprecate-to-ksa

Deprecate Session

2016-02-03T01:06:07+00:00

Deprecate the keystoneclient Session object in favour of keystoneauth's
Session.

Change-Id: I26e000d626a466f63d10d2a961adc698f8de0636
Implements: bp deprecate-to-ksa

Address hacking check H405

2016-01-13T21:03:51+00:00

Previously, there were a string of commits to keystone that addresed ignored
hacking checks. This commit does the same for H405 in keystoneclient. This
also modifies our tox.ini so that we no longer ignore H405 violations.

Change-Id: I2af152e5425a0e9c82314039fdbb90d661c22680
Closes-Bug: 1482773

Make tests run against original client and sessions

2015-12-17T22:23:06+00:00

The managers have a bad habit of reaching back into the client and
making assumptions about the values that are saved there. These
assumptions are not always correct when we use the session object.

Test all the versioned managers against a client that was constructed
with the old method and with a keystoneclient session object and a
keystoneauth1 session object.

Change-Id: I93a26db7ae7e4d887aa815108be71c72b4a1f2bb

Silence most of the deprecation spam

2015-11-09T00:40:30+00:00

Running keystoneclient unittest is really painful, because it's
impossible to see what failed in all of the deprecation output.

Make most of it go away. There is still a chunk that is being elusive.

Change-Id: I006859b016274fc1adf69653ff75b3071d2c9446

Deprecations fixture support calling deprecated function

2015-07-24T13:05:13+00:00

Sometimes a test is expected to call deprecated function, such as
when testing that deprecated function still works. Now the test can
tell the Deprecations fixture that it's calling deprecated function.

Change-Id: Ic7486b74f681989eb5110dfeaf8dae0e5d7ae50e