delta/openstack/python-keystoneclient.git/keystoneclient/tests/unit/test_session.py, branch stable/xena

Use unittest.mock instead of third party mock

2020-04-18T16:58:31+00:00

Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.

Change-Id: I7498ea2353cccca7b23d9ef74015a566ac431f90
Signed-off-by: Sean McGinnis

Fix unit tests broken by requests-mock

2019-09-06T10:08:39+00:00

Now requests-mock records request url in log[1], so it is
invalid to check that the logger output does NOT contain
request url.

Also, fix url passed to request mock as now it requires
complete url is passed

[1] https://github.com/jamielennox/requests-mock/pull/93

Change-Id: I4bab30a6705b7cab6b5a569dd61c442263e39995

Fix python3 test compat

2018-06-10T18:36:50+00:00

Python3 test requirement means that the unicode type does not exist
instead we use six.unicode to get `unicode` in py27 and `str` in
python3.

Change-Id: I2cbf2e63a9d93c232b6928acf002a45b7fbcec8e

Replace six.iteritems() with .items()

2017-04-03T12:50:52+00:00

1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a

Fix response body being omitted in debug mode incorrectly

2017-01-17T13:05:52+00:00

In debug mode, when a response's header Content-Type is set
to "application/json" with a parameter, i.e.,
"application/json; charset=UTF-8".  This patch set ignores
the additional parameter and only match the mimetype.

Change-Id: Ie8fcb1061e0e49b039436947524cfdc704c83846
Closes-Bug: #1656981

Only log application/json in session to start

2017-01-11T03:35:14+00:00

When whitelisting content types to debug print from session we chose
application/json and application/text. application/text is not a real
mime type, text is typically text/plain.

Rather than guess at mime types only print application/json to start
with, but make it easy for additional types to be added later.

Adapted from keystoneauth: Ica5fee076cdab8b1d5167161d28af7313fad9477
Related-Bug: 1616105

Change-Id: Ieaa8fb3ea8d25e09b89498f23b70b18c0f6153f1

X-Serivce-Token should be hashed in the log

2017-01-09T16:31:35+00:00

Currently, logs display the hash values of X-Auth-Token,
Authorization, and X-Subject-Token, but not the value of
the X-Service-Token.  This patch set adds the X-Service-Token
to the list of header fields to be hashed for logging purposes.

Change-Id: Iaa3a27f4b6c3baf964fa0c71328ffe9df43b2c0a
Closes-Bug: #1654847

Merge "Do not log binary data during request"

2017-01-08T04:45:57+00:00

Do not log binary data during request

2017-01-06T23:31:53+00:00

Do not log binary data during debug logging of a session.
Replace the binary data with the string  instead.

sort of a backport of: I5184002f3a21c5e0ee510b21b9a7884c8dccd1e3

Change-Id: I07ddbc3967f297597542f1975004d94c490f6e6b
Related-Bug: 1616105

Prevent MemoryError when logging response bodies

2017-01-05T13:19:25+00:00

Response bodies are loaded into memory prior to
being logged.

Loading huge response bodies may result in a
MemoryError.

This patch proposes that only JSON and TEXT
responses be logged, i.e when the Content-Type
header is application/json or application/text.

Responses that do not include or have a different
Content-Type header will have their body omitted.

This is a sort of backport of the fix for
keystoneauth sessions, see
I93b6fff73368c4f58bdebf8566c4948b50980cee

Co-Authored-By: Samuel de Medeiros Queiroz 

Closes-bug: 1616105

Change-Id: I8f43eee3a0b35041c6cf672e476f8151cf2f8d14