delta/openstack/python-keystoneclient.git/keystoneclient/tests/unit/utils.py, branch pike-eol

Replace six.iteritems() with .items()

2017-04-03T12:50:52+00:00

1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a

Use assertEqual() instead of assertDictEqual()

2016-07-26T09:15:22+00:00

OpenStack now has dropped support for python 2.6 and lower.
So we don't need to define an assertDictEqual() for python
lower than 2.7.

Further, assertEqual() in testtools is able to handle dicts
comparation, just the same as assertDictEqual() in unittest2.
So we do't need to call assertDictEqual() for dicts any more.

Please also refer to: https://review.openstack.org/#/c/347097/

Change-Id: Ieaf211617c38aa0f9a38625b1009c36bd6a16fba

Fixing D202 and D203 PEP257 violation.

2016-05-04T19:45:30+00:00

Currently tox ignores D202 and D203.
D202: No blank lines allowed after function docstring.
D203: 1 blank required before class docstring.
This change removes D202 and D203 ignores in tox and fix violations.

Change-Id: I97ef88c9cfd56774e47f789cbbcf8ccfe85d7737

Fixing D301 PEP257 violation.

2016-05-02T16:31:33+00:00

Currently tox ignores D301.
D301: Use r”“” if any backslashes in adocstring.
This change removes D301 ignore and fix violations.

Change-Id: I9dbe2c9d59e2c2d8585a53840a579a9b9c57a09c

Fix D400 PEP257 violation.

2016-04-23T17:47:25+00:00

Currently tox ignores D400.
D400: First line should end with a period.
This change removes it and make keystoneclient docstrings compliant with it.

Change-Id: I29ecb4c58bb03c0b9a3be0b7a74d18fb06a350f2

Replace TestResponse with requests_mock

2016-01-24T22:56:34+00:00

The TestResponse object doesn't do the right thing with regards to
content vs text. Just reuse the one from requests_mock rather that try
and fix it.

Change-Id: Ia8bcae126babb0e616329928c57f875a50a957d6

Address hacking check H405

2016-01-13T21:03:51+00:00

Previously, there were a string of commits to keystone that addresed ignored
hacking checks. This commit does the same for H405 in keystoneclient. This
also modifies our tox.ini so that we no longer ignore H405 violations.

Change-Id: I2af152e5425a0e9c82314039fdbb90d661c22680
Closes-Bug: 1482773

Make tests run against original client and sessions

2015-12-17T22:23:06+00:00

The managers have a bad habit of reaching back into the client and
making assumptions about the values that are saved there. These
assumptions are not always correct when we use the session object.

Test all the versioned managers against a client that was constructed
with the old method and with a keystoneclient session object and a
keystoneauth1 session object.

Change-Id: I93a26db7ae7e4d887aa815108be71c72b4a1f2bb

Deprecations fixture support calling deprecated function

2015-07-24T13:05:13+00:00

Sometimes a test is expected to call deprecated function, such as
when testing that deprecated function still works. Now the test can
tell the Deprecations fixture that it's calling deprecated function.

Change-Id: Ic7486b74f681989eb5110dfeaf8dae0e5d7ae50e

Merge "Unit tests catch deprecated function usage"

2015-07-23T20:14:03+00:00