<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-keystoneclient.git/keystoneclient/tests/unit/v3, branch pike-eol</title>
<subtitle>opendev.org: openstack/python-keystoneclient.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/'/>
<entry>
<title>Make tests pass in 2020</title>
<updated>2020-01-14T01:27:27+00:00</updated>
<author>
<name>Bernhard M. Wiedemann</name>
<email>bwiedemann@suse.de</email>
</author>
<published>2019-02-28T13:06:22+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=bcc00a10a6a5e42f261ad88feaec8019d68f25f8'/>
<id>bcc00a10a6a5e42f261ad88feaec8019d68f25f8</id>
<content type='text'>
Without this patch, build failed after 2019-12-31 with
Traceback (most recent call last):
  File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped
    self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY)
  File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs
    self.assertEqual(json, val)

NOTE: in addition to the orginal backport, this patch adds the following
changes. The changes has to be combined into a single patch in order to
avoid circular dependencies.

1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256'
is the default hash algorithm, not a sensitive password. Marking it as false
positive so bandit can stop chirping.

2. combined with cherry pick from commit
f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without
combining them, neither backport will pass all the gates since pep8 has
switched over to use python3 now.

3. combined with cherry pick from commit
b29f478f28c4989156cfe87392cbd308e3f55c1e to avoid circular dependency. Without
combining them, neither backport will pass all the gates since bandit will
have a false positive on the hash algorithm.

Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77
(cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b)
(cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054)
(cherry picked from commit b29f478f28c4989156cfe87392cbd308e3f55c1e)
(cherry picked from commit 9da2e0bdd83d481091814a8c6f40ab3ff39ffa9c)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Without this patch, build failed after 2019-12-31 with
Traceback (most recent call last):
  File "keystoneclient/tests/unit/v3/test_auth.py", line 226, in test_authenticate_success_password_unscoped
    self.assertRequestBodyIs(json=self.TEST_REQUEST_BODY)
  File "keystoneclient/tests/unit/utils.py", line 72, in assertRequestBodyIs
    self.assertEqual(json, val)

NOTE: in addition to the orginal backport, this patch adds the following
changes. The changes has to be combined into a single patch in order to
avoid circular dependencies.

1. fixed bandit complains in keystoneclient/common/cms.py. The literal 'sha256'
is the default hash algorithm, not a sensitive password. Marking it as false
positive so bandit can stop chirping.

2. combined with cherry pick from commit
f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b to avoid circular dependency. Without
combining them, neither backport will pass all the gates since pep8 has
switched over to use python3 now.

3. combined with cherry pick from commit
b29f478f28c4989156cfe87392cbd308e3f55c1e to avoid circular dependency. Without
combining them, neither backport will pass all the gates since bandit will
have a false positive on the hash algorithm.

Change-Id: I0e44d9896c5970f0ca07438c372aec826aeb5c77
(cherry picked from commit f2d3fec9b254f9c47e97ddf48e3c5f7614b87f1b)
(cherry picked from commit acc21ff06154e16de16583fe6994207d689ed054)
(cherry picked from commit b29f478f28c4989156cfe87392cbd308e3f55c1e)
(cherry picked from commit 9da2e0bdd83d481091814a8c6f40ab3ff39ffa9c)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Add support for endpoint group filtering"</title>
<updated>2017-06-22T22:02:25+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2017-06-22T22:02:25+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=2a50f56b6145e6d1f29c09482bc8959f0179e892'/>
<id>2a50f56b6145e6d1f29c09482bc8959f0179e892</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for specifying role ids when creating trust</title>
<updated>2017-06-16T15:30:56+00:00</updated>
<author>
<name>Kristi Nikolla</name>
<email>knikolla@bu.edu</email>
</author>
<published>2017-06-16T15:30:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=ef49844248661671063567f98016e88943955ba0'/>
<id>ef49844248661671063567f98016e88943955ba0</id>
<content type='text'>
Change-Id: I38e0ac35946ee6e53128babac3ea759a380572e0
Partial-Bug: 1696111
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I38e0ac35946ee6e53128babac3ea759a380572e0
Partial-Bug: 1696111
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for endpoint group filtering</title>
<updated>2017-04-13T17:19:39+00:00</updated>
<author>
<name>Enrique Garcia Navalon</name>
<email>garcianavalon@gmail.com</email>
</author>
<published>2015-05-13T13:00:10+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=2cc2f1081f3a2762ec469bd4b3cc2ed46fe0b73e'/>
<id>2cc2f1081f3a2762ec469bd4b3cc2ed46fe0b73e</id>
<content type='text'>
The following API calls are made available:

- GET /OS-EP-FILTER/projects/{project_id}/endpoint_groups
- GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}/projects
- PUT /OS-EP-FILTER/endpoint_groups/{endpoint_group}/projects/{project_id}
- HEAD /OS-EP-FILTER/endpoint_groups/{endpoint_group}/projects/{project_id}
- DELETE /OS-EP-FILTER/endpoint_groups/{endpoint_group}/projects/{project_id}

Co-Authored-By: Samuel de Medeiros Queiroz &lt;samueldmq@gmail.com&gt;

Closes-Bug: #1641674

Change-Id: Idf938267479b5b8c50c9aa141c3c2770c2d69839
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The following API calls are made available:

- GET /OS-EP-FILTER/projects/{project_id}/endpoint_groups
- GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}/projects
- PUT /OS-EP-FILTER/endpoint_groups/{endpoint_group}/projects/{project_id}
- HEAD /OS-EP-FILTER/endpoint_groups/{endpoint_group}/projects/{project_id}
- DELETE /OS-EP-FILTER/endpoint_groups/{endpoint_group}/projects/{project_id}

Co-Authored-By: Samuel de Medeiros Queiroz &lt;samueldmq@gmail.com&gt;

Closes-Bug: #1641674

Change-Id: Idf938267479b5b8c50c9aa141c3c2770c2d69839
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace six.iteritems() with .items()</title>
<updated>2017-04-03T12:50:52+00:00</updated>
<author>
<name>M V P Nitesh</name>
<email>m.nitesh@nectechnologies.in</email>
</author>
<published>2017-04-03T12:50:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=46b9e429a2cbfcd1d898616c177538a9283997d3'/>
<id>46b9e429a2cbfcd1d898616c177538a9283997d3</id>
<content type='text'>
1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1.As mentioned in [1], we should avoid using six.iteritems to achieve
iterators. We can use dict.items instead, as it will return iterators
in PY3 as well. And dict.items/keys will more readable.
2.In py2, the performance about list should be negligible, see the
link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Change-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Add support for endpoint group CRUD"</title>
<updated>2017-02-14T16:09:39+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2017-02-14T16:09:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=04ff88189a240acf88d893a3511721c39f8a5f5e'/>
<id>04ff88189a240acf88d893a3511721c39f8a5f5e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for endpoint group CRUD</title>
<updated>2017-02-11T12:38:37+00:00</updated>
<author>
<name>Samuel de Medeiros Queiroz</name>
<email>samueldmq@gmail.com</email>
</author>
<published>2017-01-06T02:37:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=34d99f0c09a253b3f51f3855fa6ce7449ffc235e'/>
<id>34d99f0c09a253b3f51f3855fa6ce7449ffc235e</id>
<content type='text'>
The following API calls are made available:

- POST /OS-EP-FILTER/endpoint_groups
- GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- HEAD /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- PATCH /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- DELETE /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- GET /OS-EP-FILTER/endpoint_groups

Partial-Bug: #1641674

Change-Id: I285eefe82152b178268f671e8800a0ff8c1511e4
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The following API calls are made available:

- POST /OS-EP-FILTER/endpoint_groups
- GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- HEAD /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- PATCH /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- DELETE /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}
- GET /OS-EP-FILTER/endpoint_groups

Partial-Bug: #1641674

Change-Id: I285eefe82152b178268f671e8800a0ff8c1511e4
</pre>
</div>
</content>
</entry>
<entry>
<title>Use https for *.openstack.org references</title>
<updated>2017-02-06T04:46:32+00:00</updated>
<author>
<name>Eric Brown</name>
<email>browne@vmware.com</email>
</author>
<published>2017-02-06T04:45:52+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=689729fa354921152cb1bd7220056a89b627e66e'/>
<id>689729fa354921152cb1bd7220056a89b627e66e</id>
<content type='text'>
The openstack.org pages now support https and our references to
the site should by default be one signed by the organization.

Change-Id: Ia6cdaf7fabd1c355df002aa07b0695610dde9cd1
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The openstack.org pages now support https and our references to
the site should by default be one signed by the organization.

Change-Id: Ia6cdaf7fabd1c355df002aa07b0695610dde9cd1
</pre>
</div>
</content>
</entry>
<entry>
<title>re-work inference rule bindings</title>
<updated>2016-12-19T03:16:31+00:00</updated>
<author>
<name>Steve Martinelli</name>
<email>s.martinelli@gmail.com</email>
</author>
<published>2016-12-18T21:07:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=0b00c0e7b17ad1a156fc2dbaccde97e3d47ba115'/>
<id>0b00c0e7b17ad1a156fc2dbaccde97e3d47ba115</id>
<content type='text'>
- At least one API was not implemented (list_implied_roles)
- the tests were lacking assertions and proper mocked responses
- some of the functionality just didn't work (see bug)
- returning Role objects instead of InferenceRule objects

Related commits:
 - I80a40e88b571fe9b0eca3af8b705ea79f28eb904
 - I66e863fb83f8dfcca2c48116d4377df060f402c3

Closes-Bug: 1647934
Change-Id: I7b449a93d7d4d3eb9ca857f6c1f78f884bad2534
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- At least one API was not implemented (list_implied_roles)
- the tests were lacking assertions and proper mocked responses
- some of the functionality just didn't work (see bug)
- returning Role objects instead of InferenceRule objects

Related commits:
 - I80a40e88b571fe9b0eca3af8b705ea79f28eb904
 - I66e863fb83f8dfcca2c48116d4377df060f402c3

Closes-Bug: 1647934
Change-Id: I7b449a93d7d4d3eb9ca857f6c1f78f884bad2534
</pre>
</div>
</content>
</entry>
<entry>
<title>Use assertIsNone(...) instead of assertEqual(None, ...)</title>
<updated>2016-12-08T09:10:12+00:00</updated>
<author>
<name>chenaidong1</name>
<email>chen.aidong@zte.com.cn</email>
</author>
<published>2016-12-08T06:56:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-keystoneclient.git/commit/?id=a9ebec4fbda82c51bad5eae4bcec3356f7af7f1d'/>
<id>a9ebec4fbda82c51bad5eae4bcec3356f7af7f1d</id>
<content type='text'>
Refer to:http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

[H203] Use assertIs(Not)None to check for None (off by default) Unit
test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...)
and assertIs(None, ...)

Change-Id: I4e60f3f7f3557080669b98cb48627acc40a72606
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Refer to:http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

[H203] Use assertIs(Not)None to check for None (off by default) Unit
test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...)
and assertIs(None, ...)

Change-Id: I4e60f3f7f3557080669b98cb48627acc40a72606
</pre>
</div>
</content>
</entry>
</feed>
