delta/openstack/python-openstackclient.git/openstackclient/compute/v2, branch stable/ussuri

Merge "compute: Add missing options for 'server group list'" into stable/ussuri

2022-07-06T01:43:13+00:00

compute: Add missing options for 'server group list'

2022-07-04T03:27:06+00:00

Add pagination parameters, '--limit' and '--offset'. It's unfortunate
that we can't use '--marker' like elsewhere but that requires
server-side support to be truly effective.

Change-Id: I186adc8cdf28e9c540ad22bca6684d9dd892976a
Signed-off-by: Stephen Finucane 
(cherry picked from commit 5ec4d4c7188f4766d270be32e12b64b709d2b835)

compute: Show flavor in 'server list' with API >= 2.47

2021-12-08T20:34:03+00:00

Fix the issue where the flavor name was empty in server list output.
This requires somewhat invasive unit test changes to reflect the changed
API response from the server, but this has the upside of meaning we
don't need new tests since what we have validates things.
Also drop the flavor ID column as it is removed from the compute API.

Conflicts:
    openstackclient/tests/unit/compute/v2/test_server.py

NOTE(melwitt): The conflict and differences from the cherry picked
change are because change I9c62cf6fe23b2e934dcbf5ebbf706b2705d2e424
(Show words indicating booted from volume for server image) is not in
Ussuri.

Change-Id: Ica3320242a38901c1180b2b29109c9474366fde0
Signed-off-by: Khomesh Thakre 
Story: 2008257
Task: 41113
(cherry picked from commit 8e362402dee07744668bcf7f6774af4fbe9a07e3)
(cherry picked from commit 0873e7580eceab07c3be0824d2ea4163491f8d6e)
(cherry picked from commit 4b7e777c0ce19aa67a9a33cbeb3b4ee2b052383f)
(cherry picked from commit fef473390c7bb6874a38b98053e54cf18547b23c)

compute: Reorder building of columns for 'server list'

2021-12-08T17:02:35+00:00

This has no impact on the end result, but it should make fixing issues
introduced by API microversion 2.69 a little easier.

Conflicts:
    openstackclient/compute/v2/server.py

NOTE(melwitt): The conflict is because change
I9c62cf6fe23b2e934dcbf5ebbf706b2705d2e424 (Show words indicating booted
from volume for server image) is not in Ussuri.

Change-Id: I7d70eac8aa1a6197ed05a49f071e6899ec219c03
Signed-off-by: Stephen Finucane 
(cherry picked from commit 4c3de28e83babb0672950320a20492dc61803b4a)
(cherry picked from commit f4adbcef7b1b18d9454109a020e5e2c6ad78b5f1)
(cherry picked from commit cb621f22d4547c20f5722058be8d99de936a48c6)
(cherry picked from commit 3c280727e7da7661e4a31266b11f5eb0893fdb0f)

Merge "Add API check for server_groups.list" into stable/ussuri

2020-10-14T06:23:25+00:00

Add API check for server_groups.list

2020-10-02T22:38:20+00:00

The policies parameter has been replaced with the
policy parameter since Nova API version 2.64[1]

This commit adds a check to make sure the correct parameter is used.

[1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59

Change-Id: Ia37beb7790884d6d15bec45074f446e64af1a2aa
Story: #2008041
Task: #40703
(cherry picked from commit ed6d8d941104c60f447de852582eb9388b9d2e73)

Add API check for server_groups.create

2020-10-02T22:17:25+00:00

The policies field has been replaced with the
policy field since Nova API version 2.64[1]

This commit adds a check to make sure the correct field is used.

[1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59

Change-Id: I06d3211937d822c26070b7f8ad757c365dcbb1bb
Story: #2007822
Task: #40101
(cherry picked from commit 51a1ea65f4d095b073381200e5268f909bf360de)

Switch image to use SDK

2020-03-23T19:38:32+00:00

This is a work to switch OSC from using glanceclient to OpenStackSDK.

With this change only v2 is using OpenStackSDK. V1 is still using
glanceclient and will be switched in a separate change.

Remove the direct depend on keystoneauth- let that flow through
openstacksdk.

Depends-on: https://review.opendev.org/#/c/698972
Change-Id: I36f292fb70c98f6e558f58be55d533d979c47ca7

Use 'KeyValueAppendAction' from osc-lib

2020-02-03T15:25:40+00:00

Does what it says on the tin. This action was added to osc-lib in change
If73cab759fa09bddf1ff519923c5972c3b2052b1.

Change-Id: I51efaa096bb26e297d99634c5d9cca34c0919074
Signed-off-by: Stephen Finucane

Stop silently ignoring invalid 'server create --hint' options

2020-02-03T15:25:24+00:00

The '--hint' option for 'server create' expects a key-value pair like so:

  openstack server create --hint group=245e1dfe-2d0e-4139-80a9-fce124948896 ...

However, the command doesn't complain if this isn't the case, meaning
typos like the below aren't indicated to the user:

  openstack server create --hint 245e1dfe-2d0e-4139-80a9-fce124948896

Due to how we'd implemented this here, this ultimately results in us
POSTing the following as part of the body to 'os-servers':

  {
    ...
    "OS-SCH-HNT:scheduler_hints": {
      "245e1dfe-2d0e-4139-80a9-fce124948896": null
    }
    ...
  }

Which is unfortunately allowed and ignored by nova due to the use of
'additionalProperties' in the schema [1]

Do what we do for loads of other options and explicitly fail on invalid
values. This involves adding a new argparse action since none of those
defined in osc-lib work for us. This is included here to ease
backporting of the fix but will be moved to osc-lib in a future patch.

[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146

Change-Id: I9e96d2978912c8dfeadae4a782c481a17cd7e348
Signed-off-by: Stephen Finucane 
Story: #2006628
Task: #36840
Related-Bug: #1845322