delta/openstack/python-openstackclient.git/openstackclient/tests/common/test_parseractions.py, branch stable/wallaby

move unit tests to new "unit" test module

2016-09-08T22:19:50+00:00

this will better isolate the unit tests from the functional tests.
unfortunately, the "integration" tests had to be lumped into the
"unit" tests since we need the separation in testr.conf

Change-Id: Ifd12198c1f90e4e3c951c73bfa1884ab300d8ded

Use assertEqual() instead of assertDictEqual()

2016-07-25T07:09:49+00:00

In unittest2, assertDictEqual() is implemented by
using != operator to compare two dicts. So is
assertEqual() in testtools. assertEqual() in
testtools is able to handle dict, list, set and
so on. So we just call assertEqual() to make the
unit tests simpler.

Change-Id: Ice343b2ce468acae39d2ad79f7121503e3627656

osc-lib: parseractions

2016-06-13T15:55:44+00:00

Leave parseractions.py and test_parseractions.py as a sanity check during the
deprecation period.

Change-Id: I1a7469b6d872284e0276502a1a287bc0b87f8f83

Error handling for KeyValueAction class.

2016-06-08T02:15:19+00:00

The set --property command requires that the input match
the "key=value" type, but if the type don't match, the return
value will be None, and the command still can be implemented
successfully, this may confuse the users. I think we should
raise exception if the argument type don't match "key=value".
So I make some changes in KeyValueAction class in this patch.

Change-Id: I14e64922faa7e083bc8b5e7e1cac41ef8117c224
Closes-Bug: #1589935

Use assertItemsEqual() instead of assertListEqual()

2016-03-14T08:22:24+00:00

assertListEqual() is order sensitive. So we need to sort
the lists before we compare them. Use assertItemsEqual()
instead is better.

Change-Id: I9eaa98716c7401f5b099b007438acc916dae619b

Add MultiKeyValueAction to custom parser action

2016-02-26T19:53:32+00:00

Class MultiKeyValueAction will be used to parse arguments like this:

--route destination=xxx,gateway=xxx --route destination=yyy,gateway=yyy

The result is a list like this:

[{destination:xxx, gateway:xxx}, {destination:yyy, gateway:yyy}]

This action also contain validation of the parameters.

Change-Id: Ie3aa8635c6a13fc2e429fe6922acd681dc7244cf

Refactor: Initialize parser in setUp() in TestNonNegativeAction

2015-12-28T12:01:13+00:00

Change-Id: I12846acc4450d31d19897bbdfc6846bde8c8f2ce

Refactor: Initialize parser in setUp() in TestKeyValueAction

2015-12-28T09:28:04+00:00

No need to initialize parser in each test case. Do it in setUp().
Also remove the test_default_values case because it could be tested
in the test_good_values case.

Change-Id: Ia2ed7c9e46bf6baabbd62b9d50511c5e8103e5e2

Replace assertEqual(None, ) with assertIsNone()

2015-12-25T05:14:33+00:00

This patch is going to replace assertEqual(None, *) with
assertIsNone(*) in unit test code to have more clear messages
in case of failure.

Change-Id: I6f85498347e8fc7cad5ea7afb832b9acda7daafc

Fix the bug of "openstack console log show"

2015-11-09T09:22:09+00:00

The behaviors are inconsistent while different
negative line numbers specified.

Change-Id: I2573f3e789f5603c896758971830ffc0b94c5e2b
Closes-Bug: #1512263