<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-openstackclient.git/openstackclient/tests/identity, branch 2.5.0</title>
<subtitle>opendev.org: openstack/python-openstackclient
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/'/>
<entry>
<title>Merge "keystone: fix catalog output when region is unset"</title>
<updated>2016-05-25T18:56:14+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-05-25T18:56:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=0d8dab6288a81b7606c518eac3e0ea21f6d8dac3'/>
<id>0d8dab6288a81b7606c518eac3e0ea21f6d8dac3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>keystone: fix catalog output when region is unset</title>
<updated>2016-05-25T14:13:48+00:00</updated>
<author>
<name>Julien Danjou</name>
<email>julien@danjou.info</email>
</author>
<published>2016-05-24T13:56:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=e44bb009d36bddc0fdfb6e949ddc293de291dcca'/>
<id>e44bb009d36bddc0fdfb6e949ddc293de291dcca</id>
<content type='text'>
If no region is set in Keystone, null is deserialized as None and the
region has None has value, which triggers a type error when building the
output string.

This patch fixes that.

Change-Id: I7637dc2595655cf452f38308f99fe66ac782e16d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If no region is set in Keystone, null is deserialized as None and the
region has None has value, which triggers a type error when building the
output string.

This patch fixes that.

Change-Id: I7637dc2595655cf452f38308f99fe66ac782e16d
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Search by user defined ID for service providers"</title>
<updated>2016-05-25T02:44:56+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-05-25T02:44:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=f97fa2e6d2cae53e82c4e8d156231c81ada0e19d'/>
<id>f97fa2e6d2cae53e82c4e8d156231c81ada0e19d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Search by user defined ID for service providers</title>
<updated>2016-05-24T18:45:58+00:00</updated>
<author>
<name>Steve Martinelli</name>
<email>stevemar@ca.ibm.com</email>
</author>
<published>2016-03-11T09:06:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=58094bff80584ba9afac0073aea545a96a170bff'/>
<id>58094bff80584ba9afac0073aea545a96a170bff</id>
<content type='text'>
IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic705806e4bc7bb24f946a1fce803a0a0a4d788c1
Closes-Bug: 1555830
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic705806e4bc7bb24f946a1fce803a0a0a4d788c1
Closes-Bug: 1555830
</pre>
</div>
</content>
</entry>
<entry>
<title>Search by user defined ID for identity providers</title>
<updated>2016-05-23T19:18:11+00:00</updated>
<author>
<name>Steve Martinelli</name>
<email>stevemar@ca.ibm.com</email>
</author>
<published>2016-03-11T09:13:21+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=21530d026e4d14142bea4ce6736326b78022ff86'/>
<id>21530d026e4d14142bea4ce6736326b78022ff86</id>
<content type='text'>
IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic58df22b3445d3293a8e1c76c5da79badebf6528
Closes-Bug: 1479837
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic58df22b3445d3293a8e1c76c5da79badebf6528
Closes-Bug: 1479837
</pre>
</div>
</content>
</entry>
<entry>
<title>Trivial: Reorder classes in identity v3 in alphabetical order</title>
<updated>2016-03-11T02:02:25+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-03-11T02:02:25+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=2debde35ef934735a280d83ab326add3efece7e1'/>
<id>2debde35ef934735a280d83ab326add3efece7e1</id>
<content type='text'>
Change-Id: Iaf2e336c2415416ec69f6b974743c26509bba561
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Iaf2e336c2415416ec69f6b974743c26509bba561
</pre>
</div>
</content>
</entry>
<entry>
<title>[Identity] Check return value is None in identity v3 unit tests</title>
<updated>2016-03-09T06:17:05+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-03-09T06:17:05+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=237d7feca8c56fccd65acf86736747402634aaf2'/>
<id>237d7feca8c56fccd65acf86736747402634aaf2</id>
<content type='text'>
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I53eeb88316b2c20882fed97149d55cb04bcb2b2e
Closes-Bug: #1550636
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I53eeb88316b2c20882fed97149d55cb04bcb2b2e
Closes-Bug: #1550636
</pre>
</div>
</content>
</entry>
<entry>
<title>[Identity] Check return value is None in identity v3 unit tests</title>
<updated>2016-03-08T07:58:25+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-03-05T08:29:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=762c4c9bdf66995198fa03751b861a859b9d44a1'/>
<id>762c4c9bdf66995198fa03751b861a859b9d44a1</id>
<content type='text'>
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636
</pre>
</div>
</content>
</entry>
<entry>
<title>Test take_action() instead of run() in unit tests</title>
<updated>2016-03-05T09:12:42+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-03-05T09:12:42+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=eb1574281b84e86ee4c4b65d900e1de82c24471e'/>
<id>eb1574281b84e86ee4c4b65d900e1de82c24471e</id>
<content type='text'>
Some of the unit tests test run(), but not take_action().

For example, in openstackclient/tests/volume/v1/test_volume.py, there is:

    def test_volume_set_size_smaller(self):
        ......

        result = self.cmd.run(parsed_args)

        self.assertEqual(0, result)
        ......

run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.

Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some of the unit tests test run(), but not take_action().

For example, in openstackclient/tests/volume/v1/test_volume.py, there is:

    def test_volume_set_size_smaller(self):
        ......

        result = self.cmd.run(parsed_args)

        self.assertEqual(0, result)
        ......

run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.

Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed a bunch of spacing</title>
<updated>2016-02-23T16:38:58+00:00</updated>
<author>
<name>Brandon Palm</name>
<email>bapalm@us.ibm.com</email>
</author>
<published>2016-02-23T16:38:58+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=f49f0fead2933ace4cb85c70bd14d13d0c479e6a'/>
<id>f49f0fead2933ace4cb85c70bd14d13d0c479e6a</id>
<content type='text'>
Nothing too complicated here.  I fixed a bunch of spacing issues
that I saw in OSC.

Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Nothing too complicated here.  I fixed a bunch of spacing issues
that I saw in OSC.

Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
</pre>
</div>
</content>
</entry>
</feed>
