<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-openstackclient.git/openstackclient/tests/unit/image, branch 3.14.2</title>
<subtitle>opendev.org: openstack/python-openstackclient
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/'/>
<entry>
<title>Check that Glance returns image data before processing it</title>
<updated>2018-01-05T18:36:49+00:00</updated>
<author>
<name>Mike Fedosin</name>
<email>mfedosin@redhat.com</email>
</author>
<published>2018-01-04T16:49:28+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=ed1b59848fd2a6b7bed7618ab5ac0db00e8110dc'/>
<id>ed1b59848fd2a6b7bed7618ab5ac0db00e8110dc</id>
<content type='text'>
Now if Glance v2 cannot find image data it returns an empty
response with 204 status code, instead of raising an error.

Glance client handles this situation and wraps the response
with a RequestIdProxy object, whose 'wrapped' attribute is
None.

But when openstack client tries to parse this object using
glanceclient's save_image util function, it fails with
"NoneType object is not iterable" message, for the
object doesn't contain any data.

This patch adds additional check to prevent such behaviour
and raises SystemExit exception if no data was returned from
the server.

Glance v1 is not affected, because it raises an error if can't
find an image data.

Change-Id: I016a60462ba586f9fa7585c2cfafffd7be38de7b
Closes-Bug: #1741223
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now if Glance v2 cannot find image data it returns an empty
response with 204 status code, instead of raising an error.

Glance client handles this situation and wraps the response
with a RequestIdProxy object, whose 'wrapped' attribute is
None.

But when openstack client tries to parse this object using
glanceclient's save_image util function, it fails with
"NoneType object is not iterable" message, for the
object doesn't contain any data.

This patch adds additional check to prevent such behaviour
and raises SystemExit exception if no data was returned from
the server.

Glance v1 is not affected, because it raises an error if can't
find an image data.

Change-Id: I016a60462ba586f9fa7585c2cfafffd7be38de7b
Closes-Bug: #1741223
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Accept 0 for --min-disk and --min-ram"</title>
<updated>2017-10-21T00:40:48+00:00</updated>
<author>
<name>Zuul</name>
<email>zuul@review.openstack.org</email>
</author>
<published>2017-10-21T00:40:48+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=3abba6ede9ea01fbdfc94a13e3252b7b98d56c34'/>
<id>3abba6ede9ea01fbdfc94a13e3252b7b98d56c34</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Accept 0 for --min-disk and --min-ram</title>
<updated>2017-10-20T19:48:37+00:00</updated>
<author>
<name>ShogoAdachi</name>
<email>sho-adachi@xc.jp.nec.com</email>
</author>
<published>2017-09-07T10:10:24+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=4464109c7754a9287f75ec2af84398700d1450e6'/>
<id>4464109c7754a9287f75ec2af84398700d1450e6</id>
<content type='text'>
The current openstackclient implementation cannot accept 0
for --min-disk and --min-ram with the "openstack image set" command.
If theses options get set to 0, the option parser in openstackclient
wrongly interprets 0 as no option value. The 0 is valid for these
options if administrators want to make it the default(no minimum
requirements).

This patch fix the parser so that it avoids only 'None'.

Change-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3
Closes-bug: #1719499
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current openstackclient implementation cannot accept 0
for --min-disk and --min-ram with the "openstack image set" command.
If theses options get set to 0, the option parser in openstackclient
wrongly interprets 0 as no option value. The 0 is valid for these
options if administrators want to make it the default(no minimum
requirements).

This patch fix the parser so that it avoids only 'None'.

Change-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3
Closes-bug: #1719499
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix 'project purge' deletes ALL images problem</title>
<updated>2017-09-26T20:49:32+00:00</updated>
<author>
<name>lihaijing</name>
<email>lihaijing@fiberhome.com</email>
</author>
<published>2017-09-21T06:55:17+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=254dbf3294c0f1edc4a2a469f556b3c4b3123a00'/>
<id>254dbf3294c0f1edc4a2a469f556b3c4b3123a00</id>
<content type='text'>
Closes-Bug: #1717130
Change-Id: I33c6fc7897dfee85d1c197a1267bde4abfa5bbd9
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes-Bug: #1717130
Change-Id: I33c6fc7897dfee85d1c197a1267bde4abfa5bbd9
</pre>
</div>
</content>
</entry>
<entry>
<title>Use flake8-import-order plugin</title>
<updated>2017-08-17T06:55:00+00:00</updated>
<author>
<name>Akihiro Motoki</name>
<email>amotoki@gmail.com</email>
</author>
<published>2017-07-15T16:58:08+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=f3bbf52b3c7e731796aaf38294d08109859babe5'/>
<id>f3bbf52b3c7e731796aaf38294d08109859babe5</id>
<content type='text'>
In reviews we usually check import grouping but it is boring.
By using flake8-import-order plugin, we can avoid this.
It enforces loose checking so it sounds good to use it.
This flake8 plugin is already used in tempest.

Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.

Setup for unit tests of hacking rules is tweaked to disable
flake8-import-order checks. This extension assumes an actual file exists
and causes hacking rule unit tests.

Change-Id: I12b596820727aeeb379bee16c2bc993dee9eb637
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In reviews we usually check import grouping but it is boring.
By using flake8-import-order plugin, we can avoid this.
It enforces loose checking so it sounds good to use it.
This flake8 plugin is already used in tempest.

Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.

Setup for unit tests of hacking rules is tweaked to disable
flake8-import-order checks. This extension assumes an actual file exists
and causes hacking rule unit tests.

Change-Id: I12b596820727aeeb379bee16c2bc993dee9eb637
</pre>
</div>
</content>
</entry>
<entry>
<title>image-list should support filters 'name','status'</title>
<updated>2017-07-12T22:50:17+00:00</updated>
<author>
<name>nidhimittalhada</name>
<email>nidhimittal19@gmail.com</email>
</author>
<published>2017-06-19T06:07:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=bca8d57eb3963beb74baa5d75e61954c610369d0'/>
<id>bca8d57eb3963beb74baa5d75e61954c610369d0</id>
<content type='text'>
nova api support parameters like 'name', 'server', 'status',
etc in image-list(). So openstackclient should support this too.

DocImpact
Closes-Bug: #1698742
Change-Id: Ice66b409f989e6785aa3b2d42f2fdbf6e23fa0aa
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nova api support parameters like 'name', 'server', 'status',
etc in image-list(). So openstackclient should support this too.

DocImpact
Closes-Bug: #1698742
Change-Id: Ice66b409f989e6785aa3b2d42f2fdbf6e23fa0aa
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "To display image size in human friendly format"</title>
<updated>2017-06-01T17:48:11+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2017-06-01T17:48:11+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=3707717f8f36160994b11097924e9d2d1a60edff'/>
<id>3707717f8f36160994b11097924e9d2d1a60edff</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Trivial fix typos</title>
<updated>2017-05-30T09:38:27+00:00</updated>
<author>
<name>Vu Cong Tuan</name>
<email>tuanvc@vn.fujitsu.com</email>
</author>
<published>2017-05-30T09:37:01+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=b52bbe1eec23ab498cc9fcda87045bddb28264db'/>
<id>b52bbe1eec23ab498cc9fcda87045bddb28264db</id>
<content type='text'>
Change-Id: I72a1da209df38e226ec02d9dbd0142ed4020c0d2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I72a1da209df38e226ec02d9dbd0142ed4020c0d2
</pre>
</div>
</content>
</entry>
<entry>
<title>doc: Correct Sphinx warnings</title>
<updated>2017-03-28T15:41:54+00:00</updated>
<author>
<name>Stephen Finucane</name>
<email>sfinucan@redhat.com</email>
</author>
<published>2017-03-20T16:19:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=70170656fd4d3c8020391354b13dca63e9e024d1'/>
<id>70170656fd4d3c8020391354b13dca63e9e024d1</id>
<content type='text'>
- Fix option-describe typos
- Correct option and envvar markup, for commands that are using the
  reference form instead of the definition form or are marking up
  option arguments as options
- Avoid duplicate commands
- Fix some invalid docstrings
- Fix some invalid indentation
- Disable the murano plugin, which has invalid docs
- Correct issues with- and track the network-topology spec
- Include API modules in docs

Change-Id: I3d5ed5e872540fe13f3e4bd5e9335829dc9a5226
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Fix option-describe typos
- Correct option and envvar markup, for commands that are using the
  reference form instead of the definition form or are marking up
  option arguments as options
- Avoid duplicate commands
- Fix some invalid docstrings
- Fix some invalid indentation
- Disable the murano plugin, which has invalid docs
- Correct issues with- and track the network-topology spec
- Include API modules in docs

Change-Id: I3d5ed5e872540fe13f3e4bd5e9335829dc9a5226
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix image member unit tests occasional failures</title>
<updated>2017-01-12T16:50:07+00:00</updated>
<author>
<name>Dean Troyer</name>
<email>dtroyer@gmail.com</email>
</author>
<published>2017-01-12T15:41:43+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/openstack/python-openstackclient.git/commit/?id=96f3c7e78315e77ca4b550cff71b104095f8dbc3'/>
<id>96f3c7e78315e77ca4b550cff71b104095f8dbc3</id>
<content type='text'>
Let's try just unrolling the member status tests and not getting
too fancy here.

Change-Id: I30022ebd2da6d6cf1abba424d7d7fa679285f291
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Let's try just unrolling the member status tests and not getting
too fancy here.

Change-Id: I30022ebd2da6d6cf1abba424d7d7fa679285f291
</pre>
</div>
</content>
</entry>
</feed>
