delta/openstack/python-openstackclient.git/openstackclient/tests/unit/volume/v1, branch 6.1.0

tests: Remove unnecessary nesting of volume resources

2022-09-30T11:42:07+00:00

Change-Id: I210ce7534d161e89115e5cb96e42ab7f27170aa1
Signed-off-by: Stephen Finucane

tests: Remove duplicate FakeImagev1Client

2022-09-30T11:41:57+00:00

I guess this was defined to avoid a circular import. There are easier
ways to do this.

Change-Id: Iab215a53691298413ea9d10def792008ab9edbce
Signed-off-by: Stephen Finucane

tests: Move fake clients to top of file

2022-09-30T11:41:48+00:00

These are important and they're easier to identify at the top of the
file than nested deep inside.

Change-Id: I1569c855fadfe4cdacf83ee07d08922bf3edefbc
Signed-off-by: Stephen Finucane

Refactor "volume backup restore" command

2022-03-10T12:04:11+00:00

Make the positional argument "volume" optional and add a "--force"
option (volume v2 only) to the "volume backup restore" command.

Closes-Bug: #1597189
Change-Id: If944e10158bd18e8331be63e96187a23e23095d7

image: Remove FakeImage test helper

2021-11-17T11:34:42+00:00

We're no longer creating fake versions of glanceclient's 'Resource'
object but rather openstacksdk objects. As such, there's no point
nesting things under a fake resource class.

Change-Id: I39cd5302622f4542db9eebcccfad0cb90d077441
Signed-off-by: Stephen Finucane

Merge "volume: Add missing 'volume list --offset' parameter"

2021-08-26T08:00:40+00:00

Merge "Replace assertItemsEqual with assertCountEqual"

2021-08-23T21:20:16+00:00

volume: Add missing 'volume list --offset' parameter

2021-07-27T10:15:23+00:00

Looking at the code for the ancient v1 cinder API, we see that this
supported offset-style pagination [1][2][3]. Add this parameter,
simplifying a future patch to standardize pagination across OSC.

[1] https://github.com/openstack/cinder/blob/juno-eol/cinder/api/v1/volumes.py#L259
[2] https://github.com/openstack/cinder/blob/juno-eol/cinder/api/v1/volumes.py#L292
[3] https://github.com/openstack/cinder/blob/juno-eol/cinder/api/common.py#L120

Change-Id: Ifec208ea9ed7afb4bebced6132abb96a3af034b5
Signed-off-by: Stephen Finucane

tests: Rename 'FakeType' -> 'FakeVolumeType'

2021-06-03T14:52:18+00:00

There are more types than just volume types.

Change-Id: I6af66f966a221437ff79fabcb0b81fd38586fe67
Signed-off-by: Stephen Finucane

Replace assertItemsEqual with assertCountEqual

2021-05-03T20:07:39+00:00

assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277

Change-Id: I0bbffbec8889b8b3067cfe17d258f5cb16624f38