log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 4 insertions, 22 deletions

diff --git a/openstackclient/identity/v2_0/user.py b/openstackclient/identity/v2_0/user.py
index e2b285bd..3d848737 100644
--- a/openstackclient/identity/v2_0/user.py
+++ b/openstackclient/identity/v2_0/user.py
@@ -15,23 +15,18 @@
 
 """Identity v2.0 User action implementations"""
 
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
 from keystoneauth1 import exceptions as ks_exc
 
+from openstackclient.common import command
 from openstackclient.common import utils
 from openstackclient.i18n import _  # noqa
 
 
-class CreateUser(show.ShowOne):
+class CreateUser(command.ShowOne):
     """Create new user"""
 
-    log = logging.getLogger(__name__ + '.CreateUser')
-
     def get_parser(self, prog_name):
         parser = super(CreateUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -78,7 +73,6 @@ class CreateUser(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -130,8 +124,6 @@ class CreateUser(show.ShowOne):
 class DeleteUser(command.Command):
     """Delete user(s)"""
 
-    log = logging.getLogger(__name__ + '.DeleteUser')
-
     def get_parser(self, prog_name):
         parser = super(DeleteUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -142,7 +134,6 @@ class DeleteUser(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -155,11 +146,9 @@ class DeleteUser(command.Command):
         return
 
 
-class ListUser(lister.Lister):
+class ListUser(command.Lister):
     """List users"""
 
-    log = logging.getLogger(__name__ + '.ListUser')
-
     def get_parser(self, prog_name):
         parser = super(ListUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -174,7 +163,6 @@ class ListUser(lister.Lister):
             help=_('List additional fields in output'))
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -248,8 +236,6 @@ class ListUser(lister.Lister):
 class SetUser(command.Command):
     """Set user properties"""
 
-    log = logging.getLogger(__name__ + '.SetUser')
-
     def get_parser(self, prog_name):
         parser = super(SetUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -296,7 +282,6 @@ class SetUser(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -348,11 +333,9 @@ class SetUser(command.Command):
         return
 
 
-class ShowUser(show.ShowOne):
+class ShowUser(command.ShowOne):
     """Display user details"""
 
-    log = logging.getLogger(__name__ + '.ShowUser')
-
     def get_parser(self, prog_name):
         parser = super(ShowUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -362,7 +345,6 @@ class ShowUser(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity