log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 4 insertions, 25 deletions

diff --git a/openstackclient/identity/v3/user.py b/openstackclient/identity/v3/user.py
index 43a116cb..c694c6ae 100644
--- a/openstackclient/identity/v3/user.py
+++ b/openstackclient/identity/v3/user.py
@@ -16,24 +16,19 @@
 """Identity v3 User action implementations"""
 
 import copy
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
 from keystoneauth1 import exceptions as ks_exc
 
+from openstackclient.common import command
 from openstackclient.common import utils
 from openstackclient.i18n import _  # noqa
 from openstackclient.identity import common
 
 
-class CreateUser(show.ShowOne):
+class CreateUser(command.ShowOne):
     """Create new user"""
 
-    log = logging.getLogger(__name__ + '.CreateUser')
-
     def get_parser(self, prog_name):
         parser = super(CreateUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -91,7 +86,6 @@ class CreateUser(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -138,8 +132,6 @@ class CreateUser(show.ShowOne):
 class DeleteUser(command.Command):
     """Delete user(s)"""
 
-    log = logging.getLogger(__name__ + '.DeleteUser')
-
     def get_parser(self, prog_name):
         parser = super(DeleteUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -155,7 +147,6 @@ class DeleteUser(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -174,11 +165,9 @@ class DeleteUser(command.Command):
         return
 
 
-class ListUser(lister.Lister):
+class ListUser(command.Lister):
     """List users"""
 
-    log = logging.getLogger(__name__ + '.ListUser')
-
     def get_parser(self, prog_name):
         parser = super(ListUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -205,7 +194,6 @@ class ListUser(lister.Lister):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -280,8 +268,6 @@ class ListUser(lister.Lister):
 class SetUser(command.Command):
     """Set user properties"""
 
-    log = logging.getLogger(__name__ + '.SetUser')
-
     def get_parser(self, prog_name):
         parser = super(SetUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -334,7 +320,6 @@ class SetUser(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -383,8 +368,6 @@ class SetUser(command.Command):
 class SetPasswordUser(command.Command):
     """Change current user password"""
 
-    log = logging.getLogger(__name__ + '.SetPasswordUser')
-
     def get_parser(self, prog_name):
         parser = super(SetPasswordUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -399,7 +382,6 @@ class SetPasswordUser(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -436,11 +418,9 @@ class SetPasswordUser(command.Command):
         identity_client.users.update_password(current_password, password)
 
 
-class ShowUser(show.ShowOne):
+class ShowUser(command.ShowOne):
     """Display user details"""
 
-    log = logging.getLogger(__name__ + '.ShowUser')
-
     def get_parser(self, prog_name):
         parser = super(ShowUser, self).get_parser(prog_name)
         parser.add_argument(
@@ -455,7 +435,6 @@ class ShowUser(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity