diff options
| author | Tang Chen <chen.tang@easystack.cn> | 2016-06-03 12:21:45 +0800 |
|---|---|---|
| committer | Tang Chen <chen.tang@easystack.cn> | 2016-06-08 14:31:17 +0800 |
| commit | e3270cdfd8fce895b8f32b8e23e48399be6ac85c (patch) | |
| tree | 638ab2ef59028c1f01ed8d9a4d53cfbbb27ba1a3 /openstackclient/network/v2/router.py | |
| parent | 84506a6b71c103b50bbf5b5f0b534e2d35950780 (diff) | |
| download | python-openstackclient-e3270cdfd8fce895b8f32b8e23e48399be6ac85c.tar.gz | |
Make set/unset commands in network return normally when nothing specified
set/unset commands should ends up normally instead of raising
an exception when nothing is specified to modify. The main
reason is: When nothing is specified, the command sets/unsets
nothing, which is a normal behavior, and ends up normally.
No API call fails. No error happens.
This patch also adds a releasenote for both network, and volume
commands that fix patch has been merged.
Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef
Partial-bug: #1588588
Diffstat (limited to 'openstackclient/network/v2/router.py')
| -rw-r--r-- | openstackclient/network/v2/router.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/openstackclient/network/v2/router.py b/openstackclient/network/v2/router.py index a2f0df1d..25487149 100644 --- a/openstackclient/network/v2/router.py +++ b/openstackclient/network/v2/router.py @@ -18,7 +18,6 @@ import json import logging from openstackclient.common import command -from openstackclient.common import exceptions from openstackclient.common import parseractions from openstackclient.common import utils from openstackclient.i18n import _ @@ -426,10 +425,6 @@ class SetRouter(command.Command): route['nexthop'] = route.pop('gateway') attrs['routes'] = obj.routes + parsed_args.routes - if attrs == {}: - msg = _("Nothing specified to be set") - raise exceptions.CommandError(msg) - client.update_router(obj, **attrs) |