summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "zuul: Stop testing against Tempest" into stable/ussuriussuri-em5.2.2Zuul2021-06-021-1/+1
|\
| * zuul: Stop testing against TempestStephen Finucane2020-10-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | Neither Tempest itself nor any of the service projects use OSC. As such, there's no reason to run Tempest jobs here. It's simply a waste of resources. Change-Id: I74b0b196fe59e5e1462e3dadc659cf6680a53f80 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 671f73694a207b4b2b5a7cf377bc46dad7e79324) (cherry picked from commit 75847d1e968977d504420a8990f724e4917c2f4f)
* | Fix reverted osc-lib interface changeRoger Luethi2021-01-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The patch https://review.opendev.org/#/c/673389/ introduced a regression by changing the osc-lib interface. Two conflicting attempts to fix the regression were launched: 1) Reverting the patch. 2) The patch https://review.opendev.org/683119 changes the exception from the generic CommandError back to a specific Forbidden exception. The patch https://review.opendev.org/683118 catches this exception and passes on, i.e. re-implements the same behavior as before. The first idea was implemented, the initial patch reverted. The second idea was partially implemented. The change in python-openstackclient (683118) was merged. The change in osc-lib was approved but failed to merge because the initial change had been reverted. Now we have again a situation where the exception produced in osc-lib does not match the exception expected by the caller. It is unclear if the osc-lib interface will ever get a rebased version of https://review.opendev.org/683119 merged, so the safest way to address the issue is to also catch the exception that used to be thrown before the inital change and is again thrown after the inital change has been reverted. Change-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c (cherry picked from commit 0a8753dc3eaeda25554ccd769350de1e9792a62b)
* | Fix lower-constraints jobStephen Finucane2021-01-213-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pip 20.3 finally includes a proper dependency resolver. Its use is causing the following error messages on the lower-constraints job: ERROR: Cannot install ... because these package versions have conflicting dependencies. The conflict is caused by: bandit 1.1.0 depends on PyYAML>=3.1.0 cliff 3.4.0 depends on PyYAML>=3.12 openstacksdk 0.52.0 depends on PyYAML>=3.13 Bump our lower constraint for PyYAML to resolve this issue. With that resolved, we see a new issue: ERROR: Could not find a version that satisfies the requirement cryptography>=2.7 (from openstacksdk) ERROR: No matching distribution found for cryptography>=2.7 This is less self-explanatory but looking at the lower-constraints for openstacksdk 0.52.0 shows a dependency on cryptography 2.7 [1], meaning we need to bump this also. Next up, flake8-import-order seems to cause the dependency resolver to go nuts, eventually ending with the following error message in a Python 3.6 environment: Using cached enum34-1.1.2.zip (49 kB) ERROR: Command errored out with exit status 1: command: ... cwd: ... Complete output (9 lines): Traceback (most recent call last): File "<string>", line 1, in <module> File ".../lib/python3.6/site-packages/setuptools/__init__.py", line 7, in <module> import setuptools.distutils_patch # noqa: F401 File ".../lib/python3.6/site-packages/setuptools/distutils_patch.py", line 9, in <module> import re File "/usr/lib64/python3.6/re.py", line 142, in <module> class RegexFlag(enum.IntFlag): AttributeError: module 'enum' has no attribute 'IntFlag' ---------------------------------------- A quick Google suggests this is because the enum34 package is not complete [2]. We shouldn't even be using it since our base virtualenv should at least use Python 3.6, but I guess some dependency doesn't properly restrict the dependency to <= Python 3.4. This is moved from 'test-requirements.txt' to 'tox.ini' since we don't need to use our constraints machinery for linters. Finally, the versions of bandit and hacking that pip is bringing in both requires in a newer version of babel, which in turn requires a new version of pytz. Collecting hacking>=2.0.0 ... ERROR: Cannot install oslo.i18n because these package versions have conflicting dependencies. The conflict is caused by: babel 2.9.0 depends on pytz>=2015.7 babel 2.8.1 depends on pytz>=2015.7 babel 2.8.0 depends on pytz>=2015.7 babel 2.7.0 depends on pytz>=2015.7 Seeing as we shouldn't be tracking bandit in lower-constraints, I'm not sure why we're want to bump these dependencies for just that. As above, we move these dependencies out of 'test-requirements' and into 'tox.ini' since we can do that for linters. Conflicts: lower-constraints.txt test-requirements.txt NOTE(stephenfin): Conflicts are due to the absence of ddt and presence of mock in lower-constraints.txt and test-requirements.txt, respectively. Modifications: lower-constraints.txt NOTE(stephenfin): There's no need to bump cryptography here since we're using an older version of openstacksdk. [1] https://opendev.org/openstack/openstacksdk/src/tag/0.52.0/requirements.txt#L19 [2] https://github.com/iterative/dvc/issues/1995#issuecomment-491889669 Change-Id: I8ec738fbcabc8d8553db79a876e5592576cd18fa Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 20769cd7b27d51da84a324a17922427eba5c6eac) (cherry picked from commit 83cd9b5b9c3b4c471b41190675f880599b78e44e)
* | Merge "Bypass user and group verification in RemoveRole" into stable/ussuriZuul2020-11-113-32/+285
|\ \
| * | Bypass user and group verification in RemoveRoleLance Bragstad2020-08-193-32/+285
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keystone let's users remove role assignments that reference non-existent users and groups. This is nice when keystone backs to an identity store like LDAP and users or groups are removed. Previously, openstackclient would validate the user and group existed in keystone before sending the request to delete the role assignment. This commit updates the code to bypass that validation so that users can use IDs to forcibly cleanup role assignments. Change-Id: I102b41677736bbe37a82abaa3c5b3e1faf2475d5 Story: 2006635 Task: 36848 (cherry picked from commit e24673267093de85beee753860cda1fb224ce4bc)
* | | Merge "Add system role assignment tests for users and groups" into stable/ussuriZuul2020-11-021-0/+137
|\ \ \ | |/ / | | / | |/ |/|
| * Add system role assignment tests for users and groupsLance Bragstad2020-08-191-0/+137
| | | | | | | | | | | | | | | | | | I was writing some additional functionality and noticed these tests were missing. This commit adds tests for adding and removing system role assignments for users and groups. Change-Id: I30fdc6ec55e1eb1cfa55f4cbf92c3f001d89865f (cherry picked from commit a8aad9fec80bcb6c9917d2dd076373f06467849f)
* | Merge "Add API check for server_groups.list" into stable/ussuriZuul2020-10-143-4/+136
|\ \
| * | Add API check for server_groups.listLewis Denny2020-10-033-4/+138
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The policies parameter has been replaced with the policy parameter since Nova API version 2.64[1] This commit adds a check to make sure the correct parameter is used. [1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59 Change-Id: Ia37beb7790884d6d15bec45074f446e64af1a2aa Story: #2008041 Task: #40703 (cherry picked from commit ed6d8d941104c60f447de852582eb9388b9d2e73)
* | | Add API check for server_groups.createLewis2020-10-032-2/+30
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | The policies field has been replaced with the policy field since Nova API version 2.64[1] This commit adds a check to make sure the correct field is used. [1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59 Change-Id: I06d3211937d822c26070b7f8ad757c365dcbb1bb Story: #2007822 Task: #40101 (cherry picked from commit 51a1ea65f4d095b073381200e5268f909bf360de)
* | Make volume backup record commands available in v3Radosław Piliszek2020-07-072-0/+8
|/ | | | | | | | | | They work just fine in Volume API v3 but they were limited in OSC to v2. Change-Id: I510383f8e0cbf05ec24caa1cad330f12f82a913d Story: 2007896 Task: 40279 (cherry picked from commit b1fc587a6d4eac795a5bc27c2dffd2d876161caa)
* Replace assertItemsEqual with assertCountEqualAlfredo Moralejo2020-06-111-2/+2
| | | | | | | | | | | | | | | | assertItemsEqual was removed from Python's unittest.TestCase in Python 3.3 [1][2]. We have been able to use them since then, because testtools required unittest2, which still included it. With testtools removing Python 2.7 support [3][4], we will lose support for assertItemsEqual, so we should switch to use assertCountEqual. [1] - https://bugs.python.org/issue17866 [2] - https://hg.python.org/cpython/rev/d9921cb6e3cd [3] - testing-cabal/testtools#286 [4] - testing-cabal/testtools#277 Change-Id: I1ad0da8deda3a8cbec384b5a9c88860a526eb48c (cherry picked from commit a15b1addb41147415716417f385f8ee32aace64b)
* Client should parse string to boolean for value 'is_domain'5.2.1yanpuqing2020-06-103-0/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | When we use "--property" parameter, client get lists these the value is string type, but the type of the value 'is_domain' should be boolean, so we should judge it and parse it. The patch parse string to boolean for value 'is_domain'. Co-Authored-By: Lance Bragstad <lbragstad@gmail.com> Conflict: Direct backports of this patch fail because the original tests proposed to the Victoria (master) branch included keystone ``options``. Support for ``options`` was added in: I9c3bdd741f28bf558267fb217818d947597ce13e This backport removes the ``options`` key from the expected values in the tests since feature support for ``options`` isn't going to be backported. Otherwise, the functionality of this change is fully tested like it is on later releases. Change-Id: I37c9eb854524bde3a1530bfe2e3a03810fb1a676 Task: 30039 Story: 2005246 (cherry picked from commit 533af9f1b2de40d98f69e83cdf89ecf254cf3879)
* Update TOX_CONSTRAINTS_FILE for stable/ussuriOpenStack Release Bot2020-06-031-4/+4
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/ussuri branch, tests will continue to use the upper-constraints list on master. Change-Id: Ie762327f9127b2aa75c4e5a3dae5ad384e07b074
* Update .gitreview for stable/ussuriOpenStack Release Bot2020-06-031-0/+1
| | | | Change-Id: Ia2b7ec393620c0cc85b21918d621d9d0fa8120f0
* Fix ussuri jobsPete Zaitcev2020-06-033-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Squashed two changes together since both are needed to fix jobs: Resolve PEP8 No idea how this happened, but reviews started failing the pep8 gate job. The failures are legitimate, see the commit. I guess the pep8 tests became smarter and found these issues. (cherry picked from commit 52ff421e3d339f81c2625bff429e6829a2d9af67) Add libc6-dev to bindep The python-builder base image was updated to no longer install recommends. This is inline with the other Infra images and keeps image sizes smaller. gcc recommended libc6-dev - but it turns out we need that for limits.h for one of our depends. Add it to fix our image builds. (cherry picked from commit 97d027caecdb977779ff130bb9ee2b3204c5646c) Change-Id: Id9a0dad644134dafd68eed37fe8f41c583d7a619
* Merge "Don't look up project by id if given id"5.2.0Zuul2020-03-251-3/+8
|\
| * Don't look up project by id if given idDmitriy Rabotyagov2020-03-241-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | There is a much deeper and systemic issue going on here, but let's start with fixing the immediate issue which is that adding a project to an image fails trying to look up project information even if the user passes the project id by id. _is_uuid_like from sdk isn't perfect, but it'll be good enough for this. Change-Id: I541416d737b961c56aa2f584c172528632fd5537
* | Merge "Complete switch from glanceclient to SDK for image service"Zuul2020-03-256-229/+155
|\ \ | |/
| * Complete switch from glanceclient to SDK for image serviceArtem Goncharov2020-03-246-229/+155
| | | | | | | | | | | | | | | | | | In https://review.opendev.org/#/c/650374/ a work has been started to switch image service support from glanceclient with all it's dependencies to the SDK version. With this change version 1 (anyway deprecated since ages) is also being switched to SDK. Change-Id: Ic391500af02a73d81d64a9e9113cca85c9e24390
* | Merge "Switch image to use SDK"Zuul2020-03-2516-558/+660
|\ \ | |/
| * Switch image to use SDKArtem Goncharov2020-03-2316-558/+660
| | | | | | | | | | | | | | | | | | | | | | | | | | This is a work to switch OSC from using glanceclient to OpenStackSDK. With this change only v2 is using OpenStackSDK. V1 is still using glanceclient and will be switched in a separate change. Remove the direct depend on keystoneauth- let that flow through openstacksdk. Depends-on: https://review.opendev.org/#/c/698972 Change-Id: I36f292fb70c98f6e558f58be55d533d979c47ca7
* | Merge "Fix faulthy state argument choice"5.1.0Zuul2020-03-245-7/+25
|\ \
| * | Fix faulthy state argument choiceBram Verschueren2019-12-195-7/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The correct state name for a failing volume snapshot deletion is 'error_deleting' instead of 'error-deleting'. [1] [1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126 Task: #37844 Story: #2007037 Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556
* | | Merge "Add unit tests and release note for dns_publish_fixed_ip"Zuul2020-03-242-0/+46
|\ \ \
| * | | Add unit tests and release note for dns_publish_fixed_ipDean Troyer2020-01-142-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-up to https://review.opendev.org/#/c/679834/ which added the options and lacked both a release note and minimal option-handling unit tests. Change-Id: Ibb2820add9b2fedaf5a8b1a77babf043f6641724 Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* | | | Merge "Honor endpoint override from config for volume"Zuul2020-03-241-0/+4
|\ \ \ \
| * | | | Honor endpoint override from config for volumeMonty Taylor2020-03-241-0/+4
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm guessing we should do this for everyone, but we have volume on the brain right now. Rackspace is in the weird situation where they do support v2 but only have v1 in the catalog (wut) So we need to override the block-storage enpdoint by config. To do that, we need to actually honor the config setting over here in OSC. NOTE: We need to systemically overhaul how we're injesting config over here - because there's too much variation. But we can leave that for another day. Story: 2007459 Task: 39137 Change-Id: Ifddf1ddd5abaa768ab18049c09d18bc269f3a4f5
* | | | Merge "Bump lower constraint of MarkupSafe"Zuul2020-03-241-1/+1
|\ \ \ \
| * | | | Bump lower constraint of MarkupSafeBence Romsics2020-03-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | setuptools 46.0.0's drop of the Features feature broke python-openstackclient's lower-constraints job on master via the MarkupSafe package. Bump the lower constraint of MarkupSafe to fix lower-constraints on master. Change-Id: Ib0a6f94a6611b221efbf76f6f25b55c43782546f
* | | | | Merge "Add "fields" parameter to ListSecurityGroup query"Zuul2020-03-242-6/+15
|\ \ \ \ \
| * | | | | Add "fields" parameter to ListSecurityGroup queryRodolfo Alonso Hernandez2020-03-122-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This new query parameter will allow to send a query sending the "fields" parameter. This "fields" parameter contains the needed API fields, translated into OVO fields in Neutron server, that require to be retrieved from the DB. As commented in the related bug, the OSC "list" command only prints five parameters, none of them the security group rules. In systems with a reasonable amount of security groups, skipping the unnecessary rule load can save a lot of time. Depends-On: https://review.opendev.org/#/c/710820/ Change-Id: I16f48e292997d029d68f66365db949b9f4b5a0c8 Closes-Bug: #1865223
* | | | | | Merge "Fix network segment range "_get_ranges" function"Zuul2020-03-232-2/+15
|\ \ \ \ \ \
| * | | | | | Fix network segment range "_get_ranges" functionRodolfo Alonso Hernandez2020-03-232-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function should return an ordered set of ranges based on an unordered list of numbers (int or str). Change-Id: I918c8befc51236cc33d96a5c88fb6eafdd143e9c Story: 2007341 Task: 38878
* | | | | | | Merge "Remove trailing newline from dockerhub secret"Zuul2020-03-231-10/+10
|\ \ \ \ \ \ \
| * | | | | | | Remove trailing newline from dockerhub secretMonty Taylor2020-03-231-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When doing encrypt_secret, one should use echo -n not just echo. Change-Id: Iefbf0f13cd349b05de910f95b9467877cb53e46b
* | | | | | | | Merge "Change dockerhub password"Zuul2020-03-231-10/+10
|\ \ \ \ \ \ \ \ | |/ / / / / / / | | | | | / / / | |_|_|_|/ / / |/| | | | | |
| * | | | | | Change dockerhub passwordMonty Taylor2020-03-231-10/+10
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed it dockerhub side. Change-Id: I1befae9622fc1ef72cd77cfd5792aad3fa231a6a
* | | | | | Merge "Now we can add description for role creation in OSC"Zuul2020-03-207-3/+132
|\ \ \ \ \ \
| * | | | | | Now we can add description for role creation in OSCM V P Nitesh2018-09-187-3/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now user can add the description when user create's the role using OSC ``openstack role create`` command. User can add the description by adding `--description <Description>` to OSC ``openstack role create`` command. Co-Authored-By: Deepak Mourya<deepakmoriya7@gmail.com> Change-Id: I858e004c3b29c687b6a39c8a1ed5fb029eb19c67 Depends-on: I230af9cc833af13064636b5d9a7ce6334c3f6e9a Closes-Bug: #1669080
* | | | | | | Merge "Replace port 35357 with 5000 for "auth_url""Zuul2020-03-202-7/+7
|\ \ \ \ \ \ \
| * | | | | | | Replace port 35357 with 5000 for "auth_url"Nguyen Van Duc2018-09-172-7/+7
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Based on the change in Keystone Install Guide [1], this patch replace port 35357 with 5000 for "auth_url". For more details, please check similar changes which have been done on other projects: Nova [2], Neutron [3], Cinder [4], Glance [5]. [1] https://review.openstack.org/#/c/541857 [2] https://review.openstack.org/#/c/562812 [3] https://review.openstack.org/#/c/566491 [4] https://review.openstack.org/#/c/565464 [5] https://review.openstack.org/#/c/558932 Change-Id: I4faabbb107f912c7ed1cc5d3467ea5a94197d4a0
* | | | | | | Merge "Update the content about Import Format"Zuul2020-03-201-9/+12
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | |
| * | | | | | Update the content about Import Formatchenxing2018-05-221-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Following by https://git.openstack.org/cgit/openstack-dev/hacking/tree/HACKING.rst#n71 Change-Id: I2f32d773c12d484e8c0e435a78a3fe16d0eeae03
* | | | | | | Update image building jobsMonty Taylor2020-03-191-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're failing on promote but not upload. That's weird. Make sure the secret is appropriately encoded, and copy what zuul is doing. Also make promote a zero-node job. Change-Id: Ifcb5b4fe2486087a5ca1ff9609f7bf09ef026974
* | | | | | | Allow setting floating IP descriptionDaniel Strong2020-03-182-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: If664bfe3c9fdcb69c7046eb16c5d32602d1b3262 Story: 2007439 Task: 39094
* | | | | | | Merge "Build utility image for using osc"Zuul2020-03-163-0/+117
|\ \ \ \ \ \ \
| * | | | | | | Build utility image for using oscMonty Taylor2020-03-143-0/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | python-openstackclient currently has a non-zero number of dependencies, so for admins who would like to run it on laptops or similar it can get tricky. In opendev, for instance, admins have it installed into a venv on a jump host, but it's really wonky to keep up with. Use the opendev/python-builder opendev/python-base pair to make a minimal image that contains an install of python-openstackclient and publish it to the osclient org on dockerhub. There is an overall policy against having binary artifacts such as this appear to be official deliverables of the OpenStack project, which this is not. It's also only publishing images based on master, so no warranties should be implied. But if this makes life easier for a user somewhere, cool. Change-Id: I9a8bfc27c127e92b6856cb6a3e45b32c818db16c
* | | | | | | | Stop configuring install_command in tox and stop use pip.Daniel Bengtsson2020-03-163-18/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, we are overriding 'install_command' to use 'pip'. This is considered poor behavior and 'python -m pip' should be used instead: https://snarky.ca/why-you-should-use-python-m-pip/ It turns out that this is the the default value provided by tox: https://tox.readthedocs.io/en/latest/config.html#conf-install_command So we can remove the line and simply use the default value. Use the right way when it's necessary. Change-Id: I410173d5fdcd8c592d98eed2f48b98e06299e8b3
View Lorry Controller Status