| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently OS_ENDPOINT_TYPE and --os-interface are being ignored for
network commands. This means the public URL is always used.
Make sure that these are picked up correctly so we hit the correct
endpoint (internal/admin/etc.) for commands such as:
$ openstack --os-interface internal network list
Closes-bug: 1592368
(cherry picked from commit 7c603e4a67c3d44367afbf2f2f6811d2436295e0)
Change-Id: Iac05204e3056e386d84d3644b5da1a2bb322bb0a
|
| | |
| |
| |
| | |
Change-Id: I9c0da059ff6fd58a69f7b2775ae2155ac2b74314
|
| | |
| |
| |
| |
| |
| |
| | |
We changed to use Reno at release 2.0, add the old notes here and set up
for 2.0-2.3 notes.
Change-Id: I2243c9f035274de85d1d38ad831e40cfe95a65bc
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the openstackclient in Python2 passes command line arguments to a
subcommand it fails to pass the arguments as text
(e.g. Unicode). Instead it passes the arguments as binary data encoded
using the current locales encoding.
An easy way to see this is trying to pass a username with a non-ASCII
character.
% openstack user delete ñew
No user with a name or ID of 'ñew' exists.
What occurs internally is when the user data is retrieved it's it
properly represented in a Unicode object. However the username pased
from the command line is still a str object encoded in the locales
encoding (typically UTF-8). A string comparison is attempted between
the encoded data from the command line and the Unicode text found in
the user representation. This seldom ends well, either the comparison
fails to match or a codec error is raised.
There is a hard and fast rule, all text data must be stored in Unicode
objects and the conversion from binary encoded text to Unicode must
occur as close to the I/O boundary as possible. Python3 enforces this
behavior automatically but in Python2 it is the programmers job to do
so.
In the past there have been attempts to fix problems deep inside
internal code by attempting to decode from UTF-8. There are two
problems with this approach. First, internal code has no way to
accurately know what encoding was used to encode the binary data. This
is way it needs to be decoded as close to the I/O source as possible
because that is the best place to know the actual encoding. Guessing
UTF-8 is at best a heuristic. Second, there must be a canonical
representation for data "inside" the program, you don't want dozens of
individual modules, classes, methods, etc. performing conversions,
instead they should be able to make the assumption in what format text
is represented in, the format for text data must be Unicode. This is
another reason to decode as close to the I/O as possible.
In Python3 the argv strings are decoded from the locales encoding by
the interpreter. By the time any Python3 code sees the argv strings
they will be Unicode. However in Python2 there must be explicit code
added to decode the argv strings into Unicode.
The conversion of sys.argv into Unicode only occurs when argv is not
passed to OpenStackShell.run(). If a caller of OpenStackShell.run()
supplies their own arg it is their responsiblity to assure they are
passing actual text objects. Consider this a requirement of the API.
Note: This patch does not contain a unittest to exercise the behavior
because it is difficult to construct a test that depends on command
invocation from a shell. The general structure of the unit tests is to
pass fake argv into OpenStackShell.run() as if it came from a
shell. Because the new code only operates when argv is not passed and
defaults to sys.argv it conflicts with the unittest design.
Change-Id: I779d260744728eae8455ff9dedb6e5c09c165559
Closes-Bug: 1603494
Signed-off-by: John Dennis <jdennis@redhat.com>
(cherry picked from commit 756d2fac67b4128312e1d779648e62f1458b4ffc)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The network commands ignored the --insecure and --os-cacert
options and OS_CACERT environment variable which prevented
them from properly completing SSL/TLS verification. This
resulted in the network commands failing with
"An SSL error occurred."
Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1
Closes-Bug: #1560157
(cherry picked from commit b5f10f43eb9fd1a046a3e80db09d8bc8c350c218)
|
| |
|
|
|
|
|
|
|
|
|
| |
With the exception of releasenotes and cover, we should follow
upper constraints. The tox_install file was copied over from
python-neutronclient [1].
[1] http://git.openstack.org/cgit/openstack/python-neutronclient/tree/tools/tox_install.sh
Change-Id: I633fa149820efafd7b2acec0388fa8bc8d06c988
(cherry picked from commit e2a9fd29c118351cd2c99e40233c9eb31c760154)
|
| |
|
|
| |
Change-Id: Icf93a2a490eeb7e5d9989663f21aecd0710b3d20
|
| |
|
|
| |
Change-Id: I06b9609aae483b7632ae7e021b239cab99cbb968
|
| |
|
|
| |
Change-Id: I917683b445854eb809455e8fff7cb8c4f05a6bc2
|
| |
|
|
| |
Change-Id: I5b6c24ccfd6f945bba6370c2967d16e0b80caea7
|
| |
|
|
| |
Change-Id: Ic75280a8228f3a98c65acea790cd4da4859bac94
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nova API validation changes [1] appear to have broken the
'os aggregate create' and 'nova aggregate-create' commands when
an availability zone name is not specified. This patch set updates
the test_aggregate functional test to set the availability zone
name in order to unblock the osc gate while nova investigates
the issue.
[1] https://review.openstack.org/#/c/281143/
Change-Id: I00b497be61c4bc4bc467c66c1e49b2e0636ab841
Related-Bug: #1541691
|
| |\ |
|
| | |
| |
| |
| | |
Change-Id: I622123f68e2bb53f8767069e4a717fcc34e37b5c
|
| | |
| |
| |
| | |
Change-Id: Icc45c24eebbdd524254dc3200b016fe75b621b15
|
| |\ \ |
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of
these commands.
Change-Id: I237ea772f74fa52af2e9aacd35d4b9cfb225c94c
Partial-Bug: #1550636
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
This patch only provide network name and subnet setting for
"network create" command.
The other options, such as --project which depends on
identity v2 or v3, will make the unit tests too complicated.
So I prefer to implement them in other patches.
Change-Id: I9ec93f0af813c8fae4170c36e16bbe8f0f53cbb6
Partial-Bug: 1543672
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| | |
Add a developer reference for options with choices. This patch set
also includes RST doc formatting fixes.
Change-Id: I5fd6a699806edf1d2d95110f0b8a2b8a385028ab
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
six.moves.urllib already covers the py2 and py3 compatibility issues
of urlparse module, use six.moves.urllib.parse.urlparse is enough.
Change-Id: I785f4f872850e5d770fdcf4c0d3392be3978cc4a
|
| |\ \ \
| |_|/
|/| | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix typo introduced in OSprofiler intergation commit, that
leaded to non-working interactive mode of the CLI client.
Change-Id: If5dfc90dbbe64d4665c3e33e936f0cc674738351
Closes-Bug: 1551160
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Modify 'code-block' tag format so that the following python code
could be showed exactly, and reformat the more than 79 chars of lines.
Change-Id: Ic6721e4cc8f4c7a3e4a7c7dbd63d9089180cdc33
|
| |\ \ \ \
| |_|_|/
|/| | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This api doc is clearly copied from v1, we should update it to reflact v2 API.
Added 'shared' param description.
Change-Id: I73d36e3a2a0448c28edab788a9340fd46177f8ef
|
| |\ \ \ \
| |_|_|/
|/| | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
includes steps for both infra and osc changes.
Change-Id: I35ae2eb29cff87f5c971e64badd2927fc9a59bf4
|
| |\ \ \ \
| |_|_|/
|/| | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As per the comment given by Steve Martinelli in
https://review.openstack.org/#/c/278209/ , the
following patch just rearranges the classes
as per the Alphabetical order.
TrivialFix
Change-Id: Ib8f0f703df4ef7d7ee6180ff8bd8a47062ae5b0f
|
| |\ \ \ \ |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
"image set" command should return None. But in one path,
it returns ({}, {}). This patch fixes this.
Change-Id: I3847e661cb7e89863921a3f0a859d9b1a8077ede
|
| |\ \ \ \ \ |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
set/unset comamnd classes should inherit from cliff.Command class.
Also, this patch adds functional tests for aggregate.
And also, use utils.format_dict() to format the output of the
properties dict.
Change-Id: Idb50bef8990da95666960e2414dfd7c9be234bba
Partial-bug: #1519503
Closes-Bug: 1546065
|
| |\ \ \ \ \ \ |
|
| | | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Classes should be in alphabetical order.
Change-Id: I7a35c3a2dd6d36c49f0d54dec5c14609a9168bd0
|
| |\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Refactored the 'os security group list' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.
This refactor also removes the logic for displaying project names
instead of project IDs when the --all-projects option is specified.
This logic was removed because it is inconsistent with the other
network commands.
Since neutron will always display security groups across all
projects for an admin, the --all-projects option is now hidden
when neutron is enabled and the Project column is always
displayed.
Change-Id: I934a1f5084ef3c5f929d0ffd38ebf5064d799941
Partial-Bug: #1519511
Related-to: blueprint neutron-client
|
| |\ \ \ \ \ \ |
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix misusages of ArgumentTypeError which causes a tuple of
class instance and error message string to be printed rather than just the
error message string itsself.
Change-Id: I0e997f86bb6603930cc92e90efcb48155f62ffb5
Closes-bug: #1551426
|
| |\ \ \ \ \ \ |
|
| | | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This patch adds "subnet delete" command to osc using sdk.
Change-Id: I6be27406b16909c6db2b95417355be302e218a8d
Implements: blueprint neutron-client
Closes-bug: #1542362
|
| |\ \ \ \ \ \
| | |_|/ / /
| |/| | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
set/unset command classes should inherit from cliff.Command class.
Also, this patch adds functional tests for compute agent.
Change-Id: I25eafffd1167f82aa0d430628c22dee7516b1e19
Partial-Bug: 1546065
|
| |\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
Unit test classes should be in alphabetical order.
Change-Id: Ie741e1c170d8cc361d95d036115d0952e5108088
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | | |
|
