summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Replace assertItemsEqual with assertCountEqualwallaby-em5.5.1Dirk Mueller2021-08-2431-291/+291
| | | | | | | | | | | | | | | | | | | | assertItemsEqual was removed from Python's unittest.TestCase in Python 3.3 [1][2]. We have been able to use them since then, because testtools required unittest2, which still included it. With testtools removing Python 2.7 support [3][4], we will lose support for assertItemsEqual, so we should switch to use assertCountEqual. [1] - https://bugs.python.org/issue17866 [2] - https://hg.python.org/cpython/rev/d9921cb6e3cd [3] - testing-cabal/testtools#286 [4] - testing-cabal/testtools#277 Conflicts: openstackclient/tests/unit/volume/v2/test_volume_snapshot.py NOTE(jpena): This file is not present in stable/wallaby Change-Id: I0bbffbec8889b8b3067cfe17d258f5cb16624f38 (cherry picked from commit e82a05864f482acc485d1bd35a4db23452f8b2ac)
* Update TOX_CONSTRAINTS_FILE for stable/wallabyOpenStack Release Bot2021-03-201-4/+4
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/wallaby branch, tests will continue to use the upper-constraints list on master. Change-Id: I8285fd4d67487f6213ba03dcb6ebe673bd819e77
* Update .gitreview for stable/wallabyOpenStack Release Bot2021-03-201-0/+1
| | | | Change-Id: I2dc1ea5578a3b648a489830df64f010420cca8c1
* Merge "project cleanup"5.5.0Zuul2021-03-186-0/+343
|\
| * project cleanupArtem Goncharov2021-02-026-0/+343
| | | | | | | | | | | | | | | | | | New implementation of the project cleanup based on the sdk.project_cleanup. It is implemented as an additional OSC operation and will ideally obsolete the `openstack project purge` giving flexibility to extend services support, parallelization, filters, etc. Change-Id: Ie08877f182379f73e5ec5ad4daaf84b3092c829c
* | Update the file paths mentioned in README.rstTakashi Kajinami2021-03-151-7/+7
| | | | | | | | | | | | | | This change fixes the outdated file paths, which were renamed by commit 9599ffe65d9dcd4b3aa780d346eccd1e760890bf . Change-Id: I9ec4c49711a2fde24f5527086e495c86af9ef1ce
* | compute: Remove 'file://' prefix from '--block-device'Stephen Finucane2021-03-112-9/+6
| | | | | | | | | | | | | | | | | | There are a couple of other (networking-related) options which accept paths, none of which insist on a URI-style path. Let's just drop this bit of complexity before we release the feature. Change-Id: Ia7f781d82f3f4695b49b55a39abbb6e582cd879c Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | Merge "compute: Add support for loading BDMs from files"Zuul2021-03-112-10/+153
|\ \
| * | compute: Add support for loading BDMs from filesStephen Finucane2021-03-052-10/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The syntax of the '--block-device' parameter is complex and easily screwed up. Allow users to load a block device config from a file. For example: $ openstack server create ... --block-device file:///tmp/bdm.json ... This should alleviate the pain that is BDMv2 somewhat. No functional tests are provided since we already have tests for the CSV style of passing parameters and the unit tests show that the net result is the same. Change-Id: I3e3299bbdbbb343863b4c14fb4d9196ff3e1698d Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "compute: Add functional tests for --block-device"Zuul2021-03-113-53/+169
|\ \ \ | |/ /
| * | compute: Add functional tests for --block-deviceStephen Finucane2021-03-053-53/+169
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This mostly reuses the existing tests for '--block-device-mapping', which can hopefully be removed at some point in the future. This highlights two issues with the implementation of this option. Firstly, the 'boot_index' parameter is not required so don't mandate it. Secondly, and more significantly, we were defaulting the destination type for the 'image' source type to 'local'. Nova only allows you to attach a single image to local mapping [1], which means this default would only make sense if you were expecting users to use the '--block-device' option exclusively and omit the '--image' option. This is the *less common* case so this is a bad default. Default instead to a destination type of 'volume' like everything else, and require users specifying '--block-device' alone to pass 'destination_type=local' explicitly. [1] https://github.com/openstack/nova/blob/c8a6f8d2e/nova/block_device.py#L193-L206 Change-Id: I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "network: Add missing subnet unset --gateway <subnet-id>"Zuul2021-03-063-0/+15
|\ \ \
| * | | network: Add missing subnet unset --gateway <subnet-id>Bharat Kunwar2021-03-053-0/+15
| |/ / | | | | | | | | | | | | | | | Story: 2008695 Task: 42003 Change-Id: I9486a09531b11f27a9ff0d68fd4ad8c68a65cccf
* | | Merge "Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747"Zuul2021-03-061-0/+6
|\ \ \ | |/ / |/| |
| * | Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747Stephen Finucane2021-01-111-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 introduced some validation for the 'openstack server group create --policy' command. Call this out in the release notes. Change-Id: I7e00851a03470364db00f0f114fc724b0f686b72 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "compute: Remove deprecated 'server migrate --live' option"Zuul2021-03-043-219/+67
|\ \ \
| * | | compute: Remove deprecated 'server migrate --live' optionStephen Finucane2021-01-223-219/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's been long enough. Time to remove this. Change-Id: I37ef09eca0db9286544a4b0bb33f845311baa9b2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Deprecate 'server create --file'"Zuul2021-03-042-1/+18
|\ \ \ \ | |/ / /
| * | | compute: Deprecate 'server create --file'Stephen Finucane2021-01-222-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The parameter isn't actually deprecated, since we need to support older API microversion, however, we now emit an error if someone attempts to boot a server with the wrong microversion. This would happen server-side anyway since this parameter was removed entirely in API microversion 2.57. Change-Id: I73864ccbf5bf181fecf505ca168c1a35a8b0af3a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Stop silently ignore --(no-)disk-overcommit"Zuul2021-03-043-1/+57
|\ \ \ \ | |/ / /
| * | | compute: Stop silently ignore --(no-)disk-overcommitStephen Finucane2021-01-223-1/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These options are not supported from Nova API microversion 2.25 and above. This can be a source of confusion. Start warning, with an eye on erroring out in the future. Change-Id: I53f27eb3e3c1a84d0d77a1672c008d0e8bb8536f Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Auto-configure shared/block live migration"Zuul2021-03-043-48/+90
|\ \ \ \ | |/ / /
| * | | compute: Auto-configure shared/block live migrationStephen Finucane2021-01-223-48/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | API microversion 2.25 introduced the 'block_migration=auto' value for the os-migrateLive server action. This is a sensible default that we should use, allowing users to avoid stating one of the '--block-migration' or '--shared-migration' parameters explicitly. While we're here, we take the opportunity to fix up some formatting in the function, which is really rather messy. Change-Id: Ieedc77d6dc3d4a3cd93b29672faa97dd4e8c1185 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Add 'server create --block-device' option"Zuul2021-03-043-1/+383
|\ \ \ \ | |/ / /
| * | | compute: Add 'server create --block-device' optionStephen Finucane2021-01-223-1/+383
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the last big gaps with novaclient. As noted in the release note, the current '--block-device-mapping' format is based on the old BDM v1 format, even though it actually results in BDM v2-style requests to the server. It's time to replace that. Change-Id: If4eba38ccfb208ee186b90a0eec95e5fe6cf8415 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Remove references to optional extensions"Zuul2021-03-041-1/+1
|\ \ \ \ | |/ / /
| * | | compute: Remove references to optional extensionsStephen Finucane2021-01-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is no longer a thing in nova. Change-Id: I2413b826385792a4f33ff70e75621b48de65c799 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Add missing 'server create' options"Zuul2021-03-043-14/+335
|\ \ \ \ | |/ / /
| * | | compute: Add missing 'server create' optionsStephen Finucane2021-01-213-14/+335
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add some volume-related options, namely '--snapshot', '--swap', and '--ephemeral'. All are shortcuts to avoid having to use '--block-device-mapping'. Change-Id: I450e429ade46a7103740150c90e3ba9f2894e1a5 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Improve 'server create --block-device-mapping' option parsing"Zuul2021-03-042-86/+153
|\ \ \ \ | |/ / /
| * | | compute: Improve 'server create --block-device-mapping' option parsingStephen Finucane2021-01-212-86/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Once again, custom actions to the rescue. Change-Id: I6b4f80882dbbeb6a2a7e877f63becae7211b7f9a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Rename 'server migrate (confirm|revert)'"Zuul2021-03-044-4/+198
|\ \ \ \ | |/ / /
| * | | compute: Rename 'server migrate (confirm|revert)'Stephen Finucane2021-01-214-4/+198
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're confirming or reverting a server migration, not a server migrate. We've a number of 'server migration *' commands now so it makes sense to move them under here. Change-Id: Ib95bb36511dad1aafe75f0c88d10ded382e4fa5c Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Add 'server migration show' command"Zuul2021-03-045-1/+242
|\ \ \ \ | |/ / /
| * | | compute: Add 'server migration show' commandStephen Finucane2021-01-215-1/+242
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the 'server-migration-show' command provided by novaclient. Change-Id: I413310b481cc13b70853eb579417f6e6fad10d98 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "Rename FakeServerMigration to FakeMigration"Zuul2021-03-042-12/+12
|\ \ \ \ | |/ / /
| * | | Rename FakeServerMigration to FakeMigrationStephen Finucane2021-01-212-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Server migrations are (confusingly) a different thing returned by a different API. Change-Id: Ib6b7c8f9cc3d1521a993616f832d41651dc46f73 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Add support for 'server boot --nic ...,tag=<tag>'"Zuul2021-03-043-4/+133
|\ \ \ \ | |/ / /
| * | | compute: Add support for 'server boot --nic ...,tag=<tag>'Stephen Finucane2021-01-213-4/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has been around for a long time but was not exposed via OSC. Close this gap. Change-Id: I71aabf10f791f68ee7405ffb5e8317cc96cb3b38 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Improve 'server create --nic' option parsing"Zuul2021-03-042-140/+185
|\ \ \ \ | |/ / /
| * | | compute: Improve 'server create --nic' option parsingStephen Finucane2021-01-212-140/+185
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify the parsing of this option by making use of a custom action. Change-Id: I670ff5109522d533ef4e62a79116e49a35c4e8fa Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Shuffle options for 'server create'"Zuul2021-03-041-96/+102
|\ \ \ \ | |/ / /
| * | | compute: Shuffle options for 'server create'Stephen Finucane2021-01-211-96/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | argparse doesn't sort options by name, meaning we can use the opportunity to group closely related options together. Do that. Change-Id: I6714c8db1a549bd4206d2282d2876a406af65aa2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Add missing options for 'server event list'"Zuul2021-03-043-44/+375
|\ \ \ \ | |/ / /
| * | | compute: Add missing options for 'server event list'Stephen Finucane2021-01-213-44/+375
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add pagination parameters, '--limit' and '--offset', and filtering parameters, '--changes-since' and '--changes-before'. Change-Id: Ieca8267c3b204ae2db580502cc8fe72c95eddf09 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "Add --name to port list"Zuul2021-03-032-0/+27
|\ \ \ \
| * | | | Add --name to port listBrian Haley2021-02-232-0/+27
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The neutron API supports filtering ports by name, but the CLI was missing support for it like it does for other networking resources. Change-Id: I4ff339e18656013218a26f045b205cb7a02dd2fb Story: #2008654
* | | | Merge "compute: Add missing options for 'server group list'"Zuul2021-03-033-5/+85
|\ \ \ \ | | |/ / | |/| |
| * | | compute: Add missing options for 'server group list'Stephen Finucane2021-01-213-5/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add pagination parameters, '--limit' and '--offset'. It's unfortunate that we can't use '--marker' like elsewhere but that requires server-side support to be truly effective. Change-Id: I186adc8cdf28e9c540ad22bca6684d9dd892976a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Add 'server * --all-projects' option"Zuul2021-03-034-8/+136
|\ \ \ \ | |/ / /
View Lorry Controller Status